summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | keymgr: Add tests for ArtiNativeKeyStore::key_path.Gabriela Moldovan2023-06-293-0/+93
| | | |
| * | | keymgr: Derive Debug for ArtiNativeKeyStore.Gabriela Moldovan2023-06-291-0/+1
| | | |
| * | | keymgr: Add tests for ssh key handling.Gabriela Moldovan2023-06-294-0/+87
| | | | | | | | | | | | | | | | Part of #895
| * | | keymgr: Return the key, not Box<()>.Gabriela Moldovan2023-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | This fixes a bug which caused the function to always return a type-erased `()` instead of the actual key!
* | | | Merge branch 'netdir_todos' into 'main'Nick Mathewson2023-06-296-52/+82
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Resolve or defer most TODO HS items in tor-netdir. See merge request tpo/core/arti!1310
| * | | | netdir: Remove a TODO HSNick Mathewson2023-06-291-4/+0
| | | | | | | | | | | | | | | | | | | | The function this comment is asking us to write is `circtarget_from_pieces`.
| * | | | Downgrade TODO HS on HsDirParams::compute().expect()Nick Mathewson2023-06-292-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (Adding comments explaining that these errors are really unlikely to occur, unless there is a bug in our code or in Rust's time handling.)
| * | | | netdir: Defer a TODO HS but add a commentNick Mathewson2023-06-291-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue with walking over the ring is an issue we really must solve on the services timeframe, as is the one about looking only at the rings for which a blinded ID is germane.
| * | | | netdir: take n_replicas and spread_fetch from consensus parametersNick Mathewson2023-06-291-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | This makes them configurable, since we allow the user to override any consensus parameter.
| * | | | netdir: Downgrade/remove/defer some TODO hs entries.Nick Mathewson2023-06-292-7/+5
| | | | |
| * | | | netdir: remove some now-needless warning suppressions.Nick Mathewson2023-06-292-3/+0
| | | | |
| * | | | dirmgr: use voting_period.Nick Mathewson2023-06-291-4/+1
| | | | |
| * | | | netdir: remove unnecessary wraps from srv_interval, extract_srvsNick Mathewson2023-06-291-13/+12
| | | | |
| * | | | netdir: Move voting_period() to netdoc::LifetimeNick Mathewson2023-06-293-15/+20
| | |_|/ | |/| | | | | | | | | | | | | | I was going to add a comment about "doing this if we need the voting period anywhere else" but it turns out that we also use it in dirmgr.
* | | | Merge branch 'badonion_error_2' into 'main'Nick Mathewson2023-06-292-19/+10
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | arti_client: Move BadOnion from TorAddrError to ErrorDetail. Closes #932 See merge request tpo/core/arti!1331
| * | | arti_client: Add a warning comment to TorAddrError.Nick Mathewson2023-06-291-0/+3
| | | |
| * | | arti_client: Move BadOnion from TorAddrError to ErrorDetail.Nick Mathewson2023-06-292-19/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This variant can never be constructed when parsing a TorAddr, so it doesn't make sense to have it in TorAddrError: the use can never see it unless they enable `error_detail`. Not a semver break because the client feature is not yet stable. Closes #932.
* | | | Merge branch 'keymgr-x25519-keys' into 'main'gabi-2502023-06-292-29/+60
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | keymgr: Add support for x25519 keys. Closes #900 See merge request tpo/core/arti!1321
| * | | keymgr: Remove unneeded error variant.Gabriela Moldovan2023-06-271-5/+0
| | | | | | | | | | | | | | | | | | | | The `Unsupported` variant is no longer needed now that we support `KeyType::X25519StaticSecret`s.
| * | | keymgr: Add support for x25519 keys.Gabriela Moldovan2023-06-272-12/+10
| | | |
| * | | keymgr: Return a concrete type from read_ed25519_keypair.Gabriela Moldovan2023-06-271-8/+9
| | | | | | | | | | | | | | | | | | | | This also fixes a bug which caused the function to always return a type-erased `()` instead of the actual key!
| * | | keymgr: Move TODO closer to the code it refers to.Gabriela Moldovan2023-06-271-10/+9
| | | |
| * | | keymgr: Map KeyType::X25519StaticSecret to an SshKeyAlgorithm.Gabriela Moldovan2023-06-271-1/+1
| | | |
| * | | keymgr: Define an SshKeyAlgorithm enum.Gabriela Moldovan2023-06-271-2/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This previously just re-exported `ssh_key::Algorithm`. However, we will need to support x25519 keys (which aren't supported by the `ssh_key` crate), so we define our own enum for the key algorithm. In addition to the `Algorithm` variants from `ssh_key`, our enum also has an `X25519` variant.
* | | | Merge branch 'config-option' into 'main'gabi-2502023-06-291-35/+63
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | arti cfg tests: exception declaration improvements See merge request tpo/core/arti!1330
| * | | | arti cfg tests: Suppress an undesriable clippy lintIan Jackson2023-06-281-0/+1
| | | | |
| * | | | arti cfg tests: declare_exceptions: Annotate the types for clarity (fmt)Ian Jackson2023-06-281-6/+4
| | | | |
| * | | | arti cfg tests: declare_exceptions: Annotate the types for clarityIan Jackson2023-06-281-1/+6
| | | | |
| * | | | arti cfg tests: Point the reader to the types used in declarationsIan Jackson2023-06-281-0/+12
| | | | |
| * | | | arti cfg tests: Move InCode into declare_config_exampleIan Jackson2023-06-281-19/+19
| | | | | | | | | | | | | | | | | | | | It's used for declarations only, and they should all be here.
| * | | | arti cfg tests: Make declare_exception take distinguished old/new typesIan Jackson2023-06-281-15/+27
| | |/ / | |/| | | | | | | | | | | | | | | | | | As per discussion in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1320#note_2916689 and IRC followup.
* | | | Merge branch 'cleanup-todos-circmgr' into 'main'Nick Mathewson2023-06-281-32/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Resolve a few "TODO HS" items in circmgr. See merge request tpo/core/arti!1322
| * | | | circmgr: Refactor duplicate logic.Nick Mathewson2023-06-281-27/+21
| | | | | | | | | | | | | | | | | | | | | | | | | These two functions are only slightly different, and benefit from taking a Fn.
| * | | | circmgr: Remove a "TODO HS" about path restrictions.Nick Mathewson2023-06-281-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | I looked through the C tor source code and couldn't find any additional path restrictions.
| * | | | circmgr: Defer two "TODO HS" in hspoolNick Mathewson2023-06-281-2/+2
| | | | | | | | | | | | | | | | | | | | One of these is test-related; one is vanguards-related.
* | | | | Merge branch 'lifecycle_doc_tweaks' into 'main'Nick Mathewson2023-06-283-18/+65
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Documentation, mostly on channel and circuit lifecycles See merge request tpo/core/arti!1318
| * | | | | ChanMgr: Tweak documentation a bit.Nick Mathewson2023-06-281-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adjust formatting, add more references to lower-level APIs, and clarify lifetimes a little more.
| * | | | | proto: ClientCirc: remove now-obsolete note on Clone-nessNick Mathewson2023-06-281-5/+0
| | | | | |
| * | | | | proto: document ClientCirc lifecycle better.Nick Mathewson2023-06-281-0/+29
| | | | | |
| * | | | | proto: document channel lifecycle better.Nick Mathewson2023-06-281-5/+24
| |/ / / /
* | | | | Merge branch 'tor-cert-todos' into 'main'Nick Mathewson2023-06-281-6/+0
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Remove spurious todo-hs items in tor-cert. See merge request tpo/core/arti!1311
| * | | | Remove spurious todo-hs items in tor-cert.Nick Mathewson2023-06-281-6/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | I am not sure why we wrote these comments, but they are incorrect: I've investigated the C code and found only 3 key types. The "unimplemented" types that the TODO comment here complains about are in fact certificate types.
* | | | Merge branch 'more-keymgr-todos' into 'main'Alexander Færøy2023-06-283-5/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | keymgr: Downgrade "TODO hs" to "TODO HSS". See merge request tpo/core/arti!1334
| * | | | keymgr: Downgrade "TODO hs" to "TODO HSS".Gabriela Moldovan2023-06-283-5/+5
| | |_|/ | |/| | | | | | | | | | | | | | These TODOs can be deferred for now: we're not declaring the keymgr APIs stable until we add support for hidden services.
* | | | Merge branch 'relayids' into 'main'Nick Mathewson2023-06-281-10/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | tor-hsclient: Make RendPtIdentityForError use RelayIds See merge request tpo/core/arti!1335
| * | | tor-hsclient: Make RendPtIdentityForError use RelayIdsIan Jackson2023-06-281-6/+3
| | | | | | | | | | | | | | | | Since arti!1233 this is trivial.
| * | | tor-hsclient: Use RendPtIdentityForError in more placesIan Jackson2023-06-281-4/+4
|/ / / | | | | | | | | | | | | For some reason this wasn't used in the actual errors, although it *was* used in the types of the functions etc.
* | | Merge branch 'reuse' into 'main'Ian Jackson2023-06-281-1/+17
|\ \ \ | | | | | | | | | | | | | | | | tor-hsclient: Discuss intro circuit extend-and-reuse See merge request tpo/core/arti!1298
| * | | tor-hsclient: Add a TODO SPEC re HS intro extend-and-reuseIan Jackson2023-06-231-0/+2
| | | |
| * | | tor-hsclient: Discuss intro circuit extend-and-reuseIan Jackson2023-06-231-1/+15
| | | | | | | | | | | | | | | | This is a summary of a discussion I had on IRC.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 20:53:28 +0000