summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | keymgr: Make the dummy types non_exhaustive.Gabriela Moldovan2023-06-221-0/+3
| | | | |
| * | | | keymgr: Add a TODO regarding missing dummy impls.Gabriela Moldovan2023-06-221-1/+3
| | | | |
| * | | | keymgr: Update outdated docs.Gabriela Moldovan2023-06-221-23/+10
| | | | |
| * | | | keymgr: Remove outdated TODOs.Gabriela Moldovan2023-06-221-9/+0
| | | | |
| * | | | keymgr: Remove unnecessary dummy types.Gabriela Moldovan2023-06-222-19/+4
| | | | | | | | | | | | | | | | | | | | We don't need dummy impls for `Error` and `Result`.
| * | | | keymgr: Move dummy implementation to tor-keymgr.Gabriela Moldovan2023-06-2210-39/+58
| | | | |
| * | | | arti-client: Make all dummy APIs pub.Gabriela Moldovan2023-06-221-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | `dummy.rs` will be moved to `tor-keymgr`, which will export everything from the module.
| * | | | arti-client: Add a dummy KeyType.Gabriela Moldovan2023-06-221-0/+3
| | | | |
| * | | | keymgr: Remove unnecessary pub(crate).Gabriela Moldovan2023-06-221-5/+5
| | | | |
| * | | | keymgr: Define a `keymgr` feature.Gabriela Moldovan2023-06-222-0/+22
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | The dummy key manager impl from `arti-client` will be moved to `tor-keymgr` soon. This commit adds a `keymgr` feature flag to `tor-keymgr` which will eventually be used to choose between the real key manager API and the dummy one.
* | | | Merge branch 'proto-better-path' into 'main'Nick Mathewson2023-06-224-86/+218
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Better API for getting circuit paths Closes #787 See merge request tpo/core/arti!1286
| * | | | hspool: Use let-else pattern; our MSRV permits it.Nick Mathewson2023-06-221-6/+2
| | | | |
| * | | | proto: Resolve/downgrade some path-related "TODO HS" itemsNick Mathewson2023-06-222-4/+6
| | | | |
| * | | | proto: Implement Redactable and Display for PathEntry.Nick Mathewson2023-06-221-0/+23
| | | | |
| * | | | circmgr: Use path_ref() instead of path().Nick Mathewson2023-06-221-24/+45
| | | | |
| * | | | proto: Add ClientCirc::path_ref(), deprecate path().Nick Mathewson2023-06-221-13/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new path_ref() method returns an Arc<Path>, which gives a much better API for reasons discussed in the new documentation of path(). (We could just replace path() if we'd prefer, but IMO having path_ref() here isn't so bad.)
| * | | | proto: Make Path and PathEntry at least minimally usefulNick Mathewson2023-06-221-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | (I'm not 100% sure about having both hops() and iter(). Should I remove one?)
| * | | | proto: Expose an opaque PathEntry.Nick Mathewson2023-06-223-20/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new PathEntry struct wraps the old PathEntry enum, which has been renamed to HopDetail. It's an opaque struct because we want to be able to put new information in the enum as we think best.
| * | | | proto: Make Path publicNick Mathewson2023-06-222-4/+9
| | | | | | | | | | | | | | | | | | | | (You can't get one yet or do much with it.)
| * | | | proto: Remove Mutex from Path.Nick Mathewson2023-06-223-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Now Path is a regular struct with no interior mutability, and we use Arc::make_mut() for the case when we need to add a hop.
| * | | | proto: Move Path into a separate shared mutable structureNick Mathewson2023-06-222-14/+44
| | |_|/ | |/| | | | | | | | | | (We're about to remove the interior mutability from Path.)
* | | | Merge branch 'proto-todos' into 'main'Nick Mathewson2023-06-225-30/+43
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | tor-proto: resolve or defer the easier TODO HS items. See merge request tpo/core/arti!1282
| * | | proto: Downgrade a comment about unauthenticated SENDMEsNick Mathewson2023-06-211-5/+9
| | | | | | | | | | | | | | | | We never actually need to allow these again; see #914
| * | | proto::circuit::handshake: downgrade a "TODO HS".Nick Mathewson2023-06-211-2/+2
| | | |
| * | | proto: Put client and service hs_ntor behind individual featuresNick Mathewson2023-06-211-5/+17
| | | | | | | | | | | | | | | | | | | | This lets us keep the service-side hs-ntor handshake experiemental for now.
| * | | proto: Resolve some hs_ntor "TODO HS" comments.Nick Mathewson2023-06-211-10/+7
| | | |
| * | | proto: downgrade some "TODO HS" comments to "HSS"Nick Mathewson2023-06-212-8/+8
| |/ / | | | | | | | | | | | | These are all related to issues that will come up for the service side of the onion service implementation.
* | | Merge branch 'socks_errorkinds' into 'main'Nick Mathewson2023-06-2210-31/+75
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Generate correct-ish socks5 errors for onion service errors. Closes #736 See merge request tpo/core/arti!1279
| * | | arti: Resolve TODO HS items related to extended SOCKS5 errorsNick Mathewson2023-06-221-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This takes an approach discussed in #736: Instead of trying to distinguish INTRO/REND failures perfectly, we instead map our existing ErrorKinds as best we can, in respect to the fact that this distinction is not super important in practice. Closes #736
| * | | New ErrorKind for invalid onion addressesNick Mathewson2023-06-225-0/+28
| | | | | | | | | | | | | | | | Use this to emit HS_BAD_ADDRESS as appropriate.
| * | | socksproto: Add unspecified but documented socks5 extension codesNick Mathewson2023-06-221-0/+8
| | | |
| * | | Remove ErrorKind::OnionService{Intro,Rend}FailedNick Mathewson2023-06-222-25/+0
| | | | | | | | | | | | | | | | | | | | These errors are orthogonal to our actual error kinds. See discussion on #736.
| * | | Generate correct ErrorKinds for hsdesc decryption failures.Nick Mathewson2023-06-215-5/+36
| | | | | | | | | | | | | | | | Part of #736
* | | | Merge branch 'notes' into 'main'gabi-2502023-06-221-13/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-hsclient: Delete/rewrite out-of-date commentary See merge request tpo/core/arti!1288
| * | | | tor-hsclient: Delete/rewrite out-of-date commentaryIan Jackson2023-06-221-13/+5
| | |/ / | |/| |
* | | | Merge branch 'downgrade-todo' into 'main'Alexander Færøy2023-06-223-3/+2
|\ \ \ \ | |/ / / |/| | | | | | | | | | | keymgr: Remove/downgrade TODOs See merge request tpo/core/arti!1285
| * | | keymgr: Downgrade 2 "TODO hs" to "TODO HSS".Gabriela Moldovan2023-06-222-2/+2
| | | |
| * | | keymgr: Remove outdated TODO.Gabriela Moldovan2023-06-221-1/+0
|/ / / | | | | | | | | | This TODO talks about a change we've decided not to implement.
* | | Merge branch 'stderr' into 'main'Alexander Færøy2023-06-2147-1/+93
|\ \ \ | | | | | | | | | | | | | | | | lints: Promote clippy::print_stderr and clippy::print_stdout See merge request tpo/core/arti!1271
| * | | lints: Run maint/add_warning to actually apply new lints (again)Ian Jackson2023-06-211-0/+2
| | | | | | | | | | | | | | | | | | | | I prepared 161b9844d against an earlier version of main without the geoip crate. Run maint/add_warning again.
| * | | lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-2144-0/+88
| | | |
| * | | lints: Promote clippy::print_stderr and clippy::print_stdoutIan Jackson2023-06-212-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are available in our MSRV now, so we don't need to handle specially. We can just add them to the standard lint block. (Lint block in every crate will be updated automatically in the next commit.)
* | | | Merge branch 'keymgr-refactor-fs-ops-2' into 'main'Ian Jackson2023-06-213-18/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keymgr: Make ArtiNativeKeyStore::key_path() return a relative path. Closes #908 See merge request tpo/core/arti!1267
| * | | | keymgr: Fix clippy lints.Gabriela Moldovan2023-06-211-1/+1
| | | | |
| * | | | keymgr: Remove outdated TODO.Gabriela Moldovan2023-06-211-2/+0
| | | | | | | | | | | | | | | | | | | | This TODO was addressed in #899
| * | | | keymgr: Make ArtiNativeKeyStore::key_path() return a relative path.Gabriela Moldovan2023-06-211-15/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also updates `ArtiNativeKeyStore`'s `KeyStore::remove` implementation to build the absolute path of the file being removed, by joining `self.keystore_dir` and the relpath returned by `ArtiNativeKeyStore::key_path()`. This addresses #908
| * | | | keymgr: Derive Into for ArtiPath.Gabriela Moldovan2023-06-211-1/+1
|/ / / / | | | | | | | | | | | | | | | | Sometimes we need the underlying String (for example to create a PathBuf).
* | | | Merge branch 'keymgr-api-consistency' into 'main'Ian Jackson2023-06-215-44/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | keymgr: Remove Error::NotFound, update KeyMgr, KeyStore APIs. See merge request tpo/core/arti!1280
| * | | | keymgr: Remove Error::NotFound, update KeyMgr, KeyStore APIs.Gabriela Moldovan2023-06-215-44/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the `NotFound` `tor_keymgr::Error` variant. Since `KeyMgr` and `KeyStore` users will need to be able to distinguish between "not found" errors and other I/O errors, this also changes the return types of the `get()` and `remove()` functions of `KeyStore` and `KeyMgr`, which now return `Ok(None)` instead of `Error::NotFound`. This makes the `KeyStore` API consistent with `KeyMgr::get`, which already has a return type of `Result<Option<K>>` (rather than `Result<K>`). This also prepares us for #901, which will make key store errors opaque. Without this change: * we'd have to create a `struct NotFoundError;` error type. Its `HasKind` impl would need to return a new `ErrorKind::KeyStoreErrorNotFound` `ErrorKind` variant * callers would have to match the `error_kind()` of the error to figure out whether the key simply can't be found (`ErrorKind::KeyStoreErrorNotFound`), or if something went wrong (any other `ErrorKind`). Given the above, I think `Result<Option<()>>` makes for a more ergonomic API. Part of #901
* | | | | Merge branch 'keymgr-rm-cond' into 'main'Ian Jackson2023-06-211-10/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | keymgr: Remove unnecessary condition. See merge request tpo/core/arti!1277
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 21:45:32 +0000