summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Expose CompoundFactory for later exposure in APISaksham Mittal2023-07-051-1/+1
| | |
* | | Merge branch 'ci-full-build' into 'main'gabi-2502023-07-121-1/+29
|\ \ \ | | | | | | | | | | | | | | | | CI: Add a job for building arti with additional features. See merge request tpo/core/arti!1401
| * | | CI: Remove unnecessary --feature flag.Gabriela Moldovan2023-07-121-1/+1
| | | | | | | | | | | | | | | | | | | | `onion-service-client` is now a default feature, so we don't need to explicitly enable it anymore.
| * | | CI: Add a job for building arti with additional features.Gabriela Moldovan2023-07-111-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is needed for testing `experimental-api` features (such as the keymgr) in shadow and chutney. Prompted by this discussion: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1399#note_2921294
* | | | Merge branch 'remove-outdated-todo' into 'main'Nick Mathewson2023-07-121-3/+0
|\ \ \ \ | |/ / / |/| | | | | | | | | | | arti-client: Remove outdated TODO. See merge request tpo/core/arti!1400
| * | | arti-client: Remove outdated TODO.Gabriela Moldovan2023-07-111-3/+0
|/ / / | | | | | | | | | These errors aren't ignored anymore.
* | | Merge branch 'explain_952_fix' into 'main'Nick Mathewson2023-07-111-0/+3
|\ \ \ | | | | | | | | | | | | | | | | Explain the code for the #952 fix. See merge request tpo/core/arti!1391
| * | | Explain the code for the #952 fix.Nick Mathewson2023-07-101-0/+3
| | | | | | | | | | | | | | | | | | | | Let's explain what Trinity did in its fix for #952, so that we know why this code is here the next time we find it.
* | | | Merge branch 'clippy-allow' into 'main'Ian Jackson2023-07-11233-0/+265
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | clippy: Allow some of our existing code patterns See merge request tpo/core/arti!1396
| * | | | clippy: tor-error: Use convert::identity for into_internal!Ian Jackson2023-07-101-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This launders the closure so that clippy's clippy::redundant_closure_call can't see it. We can't have a local #[allow] because it would be on an expression, which isn't allowed on stable. This avoids having to use more clumsy idioms at call sites.
| * | | | tor-llcrypto: Add a missing instance of the standard lint blockIan Jackson2023-07-101-0/+10
| | | | | | | | | | | | | | | | | | | | This fixes a needless_vec lint on nightly.
| * | | | Run maint/add_warning to actually apply new lint allowsIan Jackson2023-07-10231-0/+249
| | | | |
| * | | | clippy: in tests, allow clippy::useless_vecIan Jackson2023-07-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a perf issue, only. If tests are too slow, we will notice and ca speed them up. We should optimise for clarity and convenience, rather than speed. Forbidding this can result in churn between vec![] and [] as tests are updated and changed.
| * | | | clippy: globally allow clippy::needless_raw_string_hashesIan Jackson2023-07-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rationale: no-one writes these by default without thinkinh. If they are unnecessary, then either the string must have had " in it before (in which case it might do again), or it is near other strings which *do* need it. And having it does no harm; indeed IMO it can increase clarity. Alternative to !1388's Fix new "needless_raw_string_hashes" lint from clippy +nightly
* | | | | Merge branch 'fix-chutney-ci' into 'main'Nick Mathewson2023-07-102-7/+15
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | fix chutney in CI See merge request tpo/core/arti!1393
| * | | | | make chutney setup script more portabletrinity-1686a2023-07-101-3/+1
| | | | | |
| * | | | | fix chutney in CItrinity-1686a2023-07-082-5/+15
| | | | | |
* | | | | | Merge branch 'range' into 'main'Ian Jackson2023-07-1012-16/+144
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Forbid use of panicky Rng::gen_range Closes #920 See merge request tpo/core/arti!1387
| * | | | | | rng docs: Fix two linksIan Jackson2023-07-101-2/+2
| | | | | | |
| * | | | | | rng ranges: Provide examples (doctests)Ian Jackson2023-07-101-0/+42
| | | | | | |
| * | | | | | rng ranges: Forbid use of panicky Rng::gen_rangeIan Jackson2023-07-102-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #920
| * | | | | | rng ranges: Use gen_range_infallible() for Duration::ZERO..=TIan Jackson2023-07-106-7/+10
| | | | | | |
| * | | | | | rng ranges: Introduce gen_range_infallibleIan Jackson2023-07-101-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a number of places where we generate random Durations in a range which starts at zero. These call sites currently (i) have to write out Duration::ZERO or equivalent, and (ii) would have to use gen_range_checked and expect the result, even though it can be statically proven to be OK. To make this slightly smoother, provide `GenRangeInfallible` and `gen_range_infallible`.
| * | | | | | rng ranges: Use gen_range_checked().unwrap() in test caseIan Jackson2023-07-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ideally we would be allowed to use vanilla gen_range() here, but there doesn't seem to be a way to allow a specific clippy-forbidden method using #[allow] and we probably don't want to make a blanket allow.
| * | | | | | rng ranges: Use gen_range_checked().expect() in obvious cases (fmt)Ian Jackson2023-07-102-3/+5
| | | | | | |
| * | | | | | rng ranges: Use gen_range_checked().expect() in obvious casesIan Jackson2023-07-103-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In each of these, it is locally obvious that the range is nonempty.
| * | | | | | tor-basic-utils: retry: Use and justify gen_range_checkedIan Jackson2023-07-101-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | delay_bounds's implementation ensures the postcondition, so the potential p[anic in next_delay_msec cannot happen.
| * | | | | | rng ranges: Introduce RngExt and gen_range_checkedIan Jackson2023-07-101-0/+27
|/ / / / / / | | | | | | | | | | | | | | | | | | We will use this in many places instead of gen_range.
* | | | | | Merge branch 'keymgr-erased-key' into 'main'gabi-2502023-07-106-10/+23
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keymgr: Use Box<dyn EncodableKey> instead of Box<dyn Any>. Closes #937 See merge request tpo/core/arti!1398
| * | | | | | keymgr: Add semver.md.Gabriela Moldovan2023-07-101-0/+2
| | | | | | |
| * | | | | | keymgr: Use Box<dyn EncodableKey> instead of Box<dyn Any>.Gabriela Moldovan2023-07-105-10/+21
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1337#note_2917701 This will make it harder to accidentally return the wrong value from `Keystore::get` (the returned value is now at least guaranteed to implement `EncodableKey`). Closes #937
* | | | | | Merge branch 's101-q2' into 'main'gabi-2502023-07-101-0/+26
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update s101 stats. See merge request tpo/core/arti!1397
| * | | | | | Update s101 stats.Alexander Færøy2023-07-101-0/+26
| | |_|/ / / | |/| | | |
* | | | | | Merge branch 'conversation' into 'main'Alexander Færøy2023-07-106-132/+233
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overhaul send_control_message See merge request tpo/core/arti!1367
| * | | | | | tor-proto: run rustfmtIan Jackson2023-06-304-9/+21
| | | | | | |
| * | | | | | tor-proto conversations: semverIan Jackson2023-06-301-0/+1
| | | | | | |
| * | | | | | tor-proto conversations: Update a TODOIan Jackson2023-06-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The feature name is wrong now.
| * | | | | | tor-proto conversations: Drop a TODOIan Jackson2023-06-301-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I think this name is fine.
| * | | | | | tor-proto conversation API: Provide ConversationInHandlerIan Jackson2023-06-304-7/+61
| | | | | | |
| * | | | | | tor-proto circuit: Plumb async Context throughIan Jackson2023-06-302-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | handle_msg is going to want this in a moment.
| * | | | | | tor-proto conversation API: Soften a warningIan Jackson2023-06-301-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the circuit is just being used by us (which is likely, if we're using this API) then the only reactor we're blocking is our own.
| * | | | | | tor-proto conversation API: Implement ConversationIan Jackson2023-06-301-89/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now, after you call start_conversation_last_hop, you can send more messages if you like.
| * | | | | | tor-proto: Make the handler in SendMsgAndInstallHandler optionalIan Jackson2023-06-302-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to want to do almost-the-same thing but without installing a new handler.
| * | | | | | tor-proto conversation API: Return a ConversationIan Jackson2023-06-303-13/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is just a placeholder for now, but it'll be a thing you can send more messages with.
| * | | | | | tor-proto conversation API: Rename to start_conversation_last_hopIan Jackson2023-06-304-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Was send_control_message.
| * | | | | | tor-proto conversation API: Make starting message optionalIan Jackson2023-06-303-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to let people start a conversation and either expect to receive first, or send messages ad-hoc later.
| * | | | | | tor-proto conversation API: Rename to ConversationFinishedIan Jackson2023-06-302-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Was UninstallHandler. We are going to talk more about conversations and less about handlers (although, the fact of there being a handler will still be visible).
| * | | | | | tor-proto circuit: Make reactor::run_once modulae-privateIan Jackson2023-06-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Nothing else wants this and having it pub(super) is confusing.
* | | | | | | Merge branch 'recurse' into 'main'Alexander Færøy2023-07-101-26/+37
|\| | | | | | | |_|/ / / / |/| | | | | | | | | | | | | | | | | tor-hsclient: Mock traits: Work around an async boobytrap See merge request tpo/core/arti!1365
| * | | | | tor-hsclient: Mock traits: Work around an async boobytrapIan Jackson2023-06-301-26/+37
| | | | | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 19:20:39 +0000