summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | tor-hsclient: Add docs and comments about HasRetryTime for InvalidTargetIan Jackson2023-06-141-0/+18
| | |
| * | tor-cell: HasRetryTime for IntroduceAckStatus: Confirm re CANT_RELAY (fmt)Ian Jackson2023-06-141-1/+1
| | | | | | | | | | | | | | | rustdoc insisted on misindenting this before, and now it insists on un-mis-indenting it.
| * | tor-cell: HasRetryTime for IntroduceAckStatus: Confirm re CANT_RELAYIan Jackson2023-06-141-1/+1
| | | | | | | | | | | | | | | Remove this todo as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1246#note_2912104
| * | tor-cell: Add a doc comment for impl tor_error::HasRetryTime for ↵Ian Jackson2023-06-141-0/+4
| | | | | | | | | | | | IntroduceAckStatus
| * | tor-hsclient: impl HasRetryTime for FailedAttemptErrorIan Jackson2023-06-142-2/+25
| | |
| * | tor-hsclient: impl HasRetryTime for InvalidTargetIan Jackson2023-06-141-1/+14
| | |
| * | tor-cell: impl HasRetryTime for IntroduceAckStatusIan Jackson2023-06-141-0/+14
|/ /
* | Merge branch 'tor-cell-todos' into 'main'Nick Mathewson2023-06-137-53/+10
|\ \ | | | | | | | | | | | | Resolve most TODO HS comments in tor-cell See merge request tpo/core/arti!1245
| * | cell: Downgrade a couple more TODO HS comments.Nick Mathewson2023-06-132-3/+3
| | |
| * | cell: Remove relaycell::restrictNick Mathewson2023-06-133-35/+1
| | | | | | | | | | | | | | | This module didn't have anything in it; nonetheless, removing it does count as an API break since it was public.
| * | cell: Remove some TODOsNick Mathewson2023-06-133-10/+2
| | | | | | | | | | | | | | | Yes, we still will need more accessors for onion services, but we can add them as we find the need.
| * | cell: remove/localize "allow(dead-code)"Nick Mathewson2023-06-133-5/+4
| | |
* | | Merge branch 'hscrypto-todos' into 'main'gabi-2502023-06-136-60/+103
|\ \ \ | | | | | | | | | | | | | | | | hscrypto: Resolve all but one TODO HS comment. See merge request tpo/core/arti!1244
| * | | hscrypto: fix TODOs in time-period code.Nick Mathewson2023-06-133-39/+63
| | | | | | | | | | | | | | | | | | | | | | | | * Return a more informative error type (instead of Option) * Check that time periods are an integer number of seconds * Decide not to change the semantics of an argument.
| * | | hscrypto: remove compatibility note about time periods.Nick Mathewson2023-06-131-9/+0
| | | | | | | | | | | | | | | | | | | | We updated and clarified the spec in arti!107, and noted the remaining infelicities in proposal 342.
| * | | hscrypto: write a READMENick Mathewson2023-06-131-1/+20
| | | |
| * | | hscrypto: note that hs_mac is not a good choice for new protocolsNick Mathewson2023-06-131-1/+4
| | | |
| * | | hscrypto: comment out an unused key type.Nick Mathewson2023-06-131-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (I'm not removing it entirely since maybe we _should_ use it, and maybe we _will_ as we do services. I've added a TODO HS for removing it or using it, and removed the TODO HS at the head of pk.rs about making sure that all the key types in the module really belong there.)
| * | | hscrypto: Remove a TODO about extending an internal macro.Nick Mathewson2023-06-131-2/+0
| | | |
| * | | hscrypto: Remove a TODO about implementing ErrorKind.Nick Mathewson2023-06-131-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | I think it isn't actually a great idea for HsIdParseError to implement ErrorKind, since the actual ErrorKind would depend entirely on where the problematic ID came from.
| * | | hscrypto: clarify and downgrade TODOs about blinding secretsNick Mathewson2023-06-131-2/+10
| | | |
* | | | Merge branch 'rotten-chutney' into 'main'Nick Mathewson2023-06-131-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | CI: integration-chutney: Turn into a warning See merge request tpo/core/arti!1243
| * | | | CI: integration-chutney: Turn into a warningIan Jackson2023-06-131-0/+1
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | This test is known to fail "when the load is high". Recently I had to press the "merge unverified changes" button to merge !1238, after four consecutivew spurious failures. IMO this is intolerable.
* | | | Merge branch '20_byte_sendme_digest' into 'main'Ian Jackson2023-06-131-3/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | proto: Make sure that auth tags are truncated to 20 bytes See merge request tpo/core/arti!1242
| * | | | proto: Make sure that auth tags are truncated to 20 bytesNick Mathewson2023-06-131-3/+13
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Onion service hops (pointlessly) use SHA3-256 for their authentication, but they truncate it to 20 bytes (assuming I'm reading the C right.) See torspec#204 for clarification here.
* | | | Merge branch 'hs' into 'main'gabi-2502023-06-134-45/+155
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | tor-hsclient: Finish(?) plumbing up first cut of HS client connection See merge request tpo/core/arti!1240
| * | | tor-hsclient: Add some more debuggingIan Jackson2023-06-131-2/+39
| | | |
| * | | tor-hsclient: Return the circuitIan Jackson2023-06-131-4/+1
| | | |
| * | | tor-hsclient: Conduct the INTRODUCE1 exchangeIan Jackson2023-06-133-6/+69
| | | |
| * | | tor-hsclient: Remove an already-done TODOIan Jackson2023-06-131-3/+0
| | | | | | | | | | | | | | | | Since !1238 we do pass the handshake_state along.
| * | | tor-cell: IntroduceAck: Add .success() function to give a ResultIan Jackson2023-06-131-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | The type is a bit odd but this is a result of the underlying protocol. I don't feel like inventing `IntroduceAckSuccess` that contains only the extensions.
| * | | tor-hsclient: Rename some errors for greater consistencyIan Jackson2023-06-132-15/+15
| | | |
| * | | tor-hsclient: Reorder timeout errors to be "less interesting"Ian Jackson2023-06-131-21/+21
| | | | | | | | | | | | | | | | | | | | If something *other* than a timeout went wrong, then that is less expected so more interesting.
* | | | Merge branch 'hs3' into 'main'Ian Jackson2023-06-134-73/+177
|\| | | | |/ / |/| | | | | | | | tor-hsclient: Plumb some needed values through etc. See merge request tpo/core/arti!1238
| * | tor-hsclient: Improve proto_oneshot docsNick Mathewson2023-06-131-1/+1
| | |
| * | tor-hsclient: Pass handshake_state to complete_handcshake (fmt)Ian Jackson2023-06-131-1/+4
| | |
| * | tor-hsclient: Pass handshake_state to complete_handcshakeIan Jackson2023-06-131-7/+21
| | | | | | | | | | | | | | | Pass Introduced to complete_handshake. The lack of this was a slip. Add handshake_state to Introduced, and use it.
| * | tor-hsclient: Add a missing docIan Jackson2023-06-131-1/+1
| | | | | | | | | | | | Requested in !1228 but overlooked
| * | tor-hsclient: Introduce proto_oneshot, to help with message handling (fmt)Ian Jackson2023-06-131-12/+5
| | |
| * | tor-hsclient: Introduce proto_oneshot, to help with message handlingIan Jackson2023-06-133-57/+120
| | | | | | | | | | | | | | | This gets rid of a lot of repeated `oneshot::<...<Result, ...>>` and a bit of repeated functional code, etc.
| * | tor-hsclient: (try to) receive the RENDEZVOUS2 messageIan Jackson2023-06-132-7/+38
| | |
| * | tor-hsclient: Fix a botched doc commentIan Jackson2023-06-131-1/+1
| | |
* | | Merge branch 'fix' into 'main'Nick Mathewson2023-06-131-0/+1
|\ \ \ | |/ / |/| | | | | | | | RPC: Suppress a warning to do with RPC and SOCKS See merge request tpo/core/arti!1237
| * | RPC: Suppress a warning to do with RPC and SOCKSIan Jackson2023-06-131-0/+1
|/ / | | | | | | Fixes `cargo check`
* | Merge branch 'msg_in_handler' into 'main'Ian Jackson2023-06-135-31/+49
|\ \ | | | | | | | | | | | | | | | | | | proto: Convert MsgHandler API to expect a message, not a cell. Closes #887 See merge request tpo/core/arti!1236
| * | proto: Convert MsgHandler API to expect a message, not a cell.Nick Mathewson2023-06-125-31/+49
| | | | | | | | | | | | Closes #887.
* | | Merge branch 'rpc_pseudomethods_v6' into 'main'Nick Mathewson2023-06-128-33/+518
|\ \ \ | | | | | | | | | | | | | | | | RPC: Functionality to downcast dyn Object to a dyn Trait. See merge request tpo/core/arti!1225
| * | | RPC: Functionality to downcast dyn Object to a dyn Trait.Nick Mathewson2023-06-126-27/+518
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a rather tricky piece of functionality. It works as follows. We introduce a `CastTable` type. Each `CastTable` tells us how to downcast `dyn Object` for objects of a single concrete type. The `Object` type now has a `get_casttable` method that returns an empty `CastTable` by default. `CastTable` is, internally, a map from the `TypeId` of the target dyn Trait reference type to a function `fn(&dyn Object) -> &dyn Trait`. These functions are stored as `Box<dyn Any + ...>`. (They are Boxed because they may refer to generic functions, which you can't get a static reference to, and they're Any because the functions have different types.) The `decl_object!` macro now implements `get_casttable` as appropriate. (The syntax is a bit janky, but that's what we get for not using derive_adhoc.) For non-generic types, `get_casttable` uses a Lazy<CastTable>`. to initialize a CastTable exactly once. For generic types, it use a `Lazy<RwLock<HashMap<..>>` to build one CastTable per instantiation of the generic type. This could probably be optimized a bit more, the yaks could be shaved in a more scintillating hairstyle, and the syntax for generic `decl_object` could definitely be improved.
| * | | rpc: make decl_object! responsible for writing impl Object {} blocks.Nick Mathewson2023-06-076-9/+3
| | | |
* | | | Merge branch 'desc-validation-err-doc' into 'main'gabi-2502023-06-121-1/+5
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | tor-error: Document another potential cause for OnionServiceDescriptorValidationFailed. See merge request tpo/core/arti!1215