| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
|
| |/ /
| |
| |
| |
| | |
It turns out that phf 0.11 depends on Rust 1.60, which is above our
MSRV.
|
| |\ \
| | |
| | |
| | |
| | | |
Teach check_licenses to accept license on `unicode-ident`.
See merge request tpo/core/arti!635
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The license there is `(MIT OR Apache-2.0) AND Unicode-DFS-2016`,
which fine, but the existing shell script doesn't actually handle
"AND" correctly. This commit adds a workaround for licenses that
are "AND", and some comments about weaknesses in our (lack of)
boolean expression parsing.
This should fix CI.
|
| |\ \
| | |
| | |
| | |
| | | |
disable-fs-permission-checks: remove variable from help message
See merge request tpo/core/arti!633
|
| | | |
| | |
| | |
| | |
| | | |
This option doesn't take an argument. This change drops the argument
from the `--help` message.
|
| |/ / |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Move environment-variable checking into fs-mistrust
Closes #483
See merge request tpo/core/arti!630
|
| | | | |
|
| | | |
| | |
| | |
| | | |
These aren't user facing comments, but getting them
right will help us write better changelogs.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This logic can now be adjusted via the config object so that it does
its own overriding by looking at the environment as appropriate.
Removing these methods helps simplify the code a bit.
Enabled by #483.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Now that configuring the environment variables related to fs
permissions works properly, we don't need to use the "override"
feature any more: we can just add the option to the configuration
when appropriate.
With this design, `--disable-fs-permission-checks` is now mostly an
alias for
`--option storage.permissions.dangerously_trust_everyone=true`
Enabled by #483.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The variable is now handled when building the configuration, and no
longer needs to be special-cased.
Closes #483.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
By default we look at `$FS_MISTRUST_DISABLE_PERMISSIONS_CHECKS`.
Optionally, the user can provide another variable as well, or
disable looking at the environment entirely.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Revise tor_bytes::Writer::write to return a Result.
Closes #513
See merge request tpo/core/arti!623
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Now that everything has been converted to fallible writers, we get
to finally remove write_infallible() from tor_bytes.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This change was a bit annoying, since most of this code _can't_ fail,
and so the only reasonable response is to wrap the input in an
internal error... except for one case where we're actually encoding
a caller-provided message, so we _do_ want to wrap the EncodeError
from tor_bytes.
|
| | | | |
| | | |
| | | |
| | | | |
Also, stop using "expect" and "assert!" to check for errors.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
This lets us remove a few TODOs.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Also, make private a function that had formerly been `pub`.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There were only a few of these. Removing it required porting
everything to use `write_and_consume` instead, and handling its
(potential) errors.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
(There was only one.)
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This comprises four renames:
```
write_onto -> write_onto_infallible
write_into -> write_into_infallible
write -> write_infallible
writer_and_consume -> write_and_consume_infallible.
```
The rest of this branch will be concerned with replacing these
`_infallible` methods with ones that return a `Result`. This is
part of #513.
|
| | | | |
| | | |
| | | |
| | | | |
This will help down the line as we make more writers fallible.
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
tor-cell: Derive Eq for NtorV3Extension
See merge request tpo/core/arti!631
|
| | | | |
| | | |
| | | |
| | | | |
Apropos clippy complaint.
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Make dormant be a postage::watch
See merge request tpo/core/arti!632
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In answer to
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/632#note_2822107
I think this is subtle enough that it deserves a comment.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This means that it is no longer possible to write code which updates
the dormant mode but forgets to notify the periodic tasks.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This will allow receivers (which we are about to introduce) to
terminate when the last client is dropped.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There are going to be some tasks (well, right away, one task) which
will want to go away when the sender is dropped.
The docs in postage are silent, but postage::watch::Sender does not
have a Drop impl so I don't think we can rely on the Receivers getting
None from their Stream impl.
So we're going to have the watch send Options, which are None only
when the sender is dropped.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We are going to want to be able to wake up other tasks elsewhere in
Arti, that need to know about dormancy. We will give them a postage
watch Receiver.
Right now there are no such things yet.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
We're going to want this in a moment.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We need to replace the AtomicBool for dormant mode with something that
can wake up tasks. postage::watch is the right shape.
But we want to be able to update it but suppress no-op updates.
(There is going to be a call site where no-op updates can occur.)
In the absence of a suitable upstream method as requested here
https://github.com/austinjones/postage-rs/issues/56
we introduce this facility via an extension trait.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clean up some errors in tor-dirmgr
Closes #521
See merge request tpo/core/arti!628
|
| | | | | |
|
| | | | | |
|
| | | | | |
|