summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Document StorageConfig defaults better.Nick Mathewson2021-11-292-11/+28
| | | | | | | | | | | | | | | | | | | | (Also fix a couple of typos)
| * | | | Add basic tests for high-level buildersNick Mathewson2021-11-254-4/+111
| | | | | | | | | | | | | | | | | | | | | | | | | Make sure that we can change elements, and we can reconstruct builders that give us the same thing.
| * | | | Implement builder patterns for ArtiConfig.Nick Mathewson2021-11-252-6/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements the "metabuilder" pattern and the "builder reconstruction" pattern for the ArtiConfig type. I'm not 100% that this will be necessary, but it will certainly help with testing.
| * | | | Resolve some warnings in tor-config testNick Mathewson2021-11-251-0/+4
| | | | |
| * | | | Impl and test Default for high-level configsNick Mathewson2021-11-252-3/+42
| | | | |
| * | | | Ensure that all config sections have deny_unknown_fieldsNick Mathewson2021-11-252-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | When we deserialize a configuration, we should reject unknown variables (except when we have an explicit reason to allow them).
| * | | | Make directory accessors crate-private.Nick Mathewson2021-11-251-4/+2
| | | | | | | | | | | | | | | | | | | | These don't need to be exposed any longer.
| * | | | Define defaults for StorageConfigNick Mathewson2021-11-251-19/+18
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm still not 100% sure this is the right move: should we encourage app developers to always pick their own directories? Or should we make it easy for them to use, well, `sane_defaults`? This patch takes the second approach.
* | | | Merge branch 'coverage-ux' into 'main'eta2021-11-291-14/+118
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | UX improvements to with_coverage script See merge request tpo/core/arti!143
| * | | | with_coverage: port to work with mawkNick Mathewson2021-11-241-5/+7
| | | | | | | | | | | | | | | | | | | | The syntax is kinda minimal, but it seems to work okay.
| * | | | with_coverage: detect missing llvm-tools-previewNick Mathewson2021-11-241-0/+6
| | | | | | | | | | | | | | | | | | | | Applies a suggestion from @trinity-1686a
| * | | | with_coverage: include command log in index.htmlNick Mathewson2021-11-231-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | This is a slight kludge, but it helps a lot to keep track of what exactly was tested for coverage.
| * | | | with_coverage: Add flags to accumulate data over runs (or not)Nick Mathewson2021-11-231-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the -c flag is provided, we _continue_ with the previous consensus_meta data (without deleting it). If the -s flag is provided, we _skip_ generating the final report (since we're going to be doing more profiling.)
| * | | | with_coverage: Don't try to delete absent directoriesNick Mathewson2021-11-231-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | If the directories are absent, then deleting them gives you a line in stderr, even if you do "rm -f foo || true".
| * | | | Let with_coverage take command-line flags.Nick Mathewson2021-11-231-8/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the shell is controlled by the presence of an -i flag, and can be combined with a command. This commit also adds usage messages and better reports for a couple of kinds of setup errors.
| * | | | with_coverage: Wipe coverage_meta at the start of each run.Nick Mathewson2021-11-231-0/+6
| | | | | | | | | | | | | | | | | | | | Also improve comments and stdout slightly...
* | | | | Mark a test as #[ignore]Nick Mathewson2021-11-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test seems unreliable on CI: we've got to disable them for now so that we have a working CI system. The CI failure is #238; the ticket to repair them is #244.
* | | | | Merge remote-tracking branch 'origin/mr/149'Nick Mathewson2021-11-292-23/+0
|\ \ \ \ \
| * | | | | Remove address from VoterInfoBuilderNeel Chauhan2021-11-281-12/+0
| | | | | |
| * | | | | Remove unused 'address' field from DirSource structNeel Chauhan2021-11-282-11/+0
| | |/ / / | |/| | |
* | | | | Merge remote-tracking branch 'origin/mr/148'Nick Mathewson2021-11-291-10/+2
|\ \ \ \ \
| * | | | | In struct PendingEntry, remove circ_specNeel Chauhan2021-11-281-10/+2
| |/ / / /
* | | | | Merge branch 'bad_exit_test'Nick Mathewson2021-11-291-6/+20
|\ \ \ \ \
| * | | | | tor-circmgr: Write a test for BadExit support.Neel Chauhan2021-11-291-6/+20
|/ / / / /
* | | | | Merge remote-tracking branch 'origin/mr/145'Nick Mathewson2021-11-2967-188/+205
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | add semicolons if nothing returnedDaniel Eades2021-11-2561-108/+137
| | | | |
| * | | | deglob some enums, use concise iteration syntaxDaniel Eades2021-11-2515-80/+68
|/ / / /
* | | | Resolve a pair of rustdoc warnings.Nick Mathewson2021-11-242-2/+4
| | | |
* | | | More typo fixes that I forgot to save :(Nick Mathewson2021-11-2411-16/+16
| | | |
* | | | Fix a clippy issue on nightlyNick Mathewson2021-11-241-0/+1
| | | |
* | | | Fix a few typos.Nick Mathewson2021-11-2415-22/+22
| | | | | | | | | | | | | | | | Also fix some commonwealth spellings that had slipped in.
* | | | More tests for tor-config.Nick Mathewson2021-11-242-2/+71
| | | |
* | | | Remove a couple more eprintln! calls.Nick Mathewson2021-11-232-2/+1
|/ / /
* | | Avoid a warning about retain_mut() in nightly.Nick Mathewson2021-11-231-2/+2
| | | | | | | | | | | | | | | | | | | | | Rust nightly claims that Vec might get its own retain_mut method, which would potentially conflict with the extension method we've grabbed from the retain_mut crate. To solve this, we're calling the method explicitly.
* | | Add coverage_meta to .gitignoreNick Mathewson2021-11-231-0/+1
| | |
* | | Merge remote-tracking branch 'origin/mr/140'Nick Mathewson2021-11-231-1/+13
|\ \ \
| * | | Use guard-extreme-restriction-percentNeel Chauhan2021-11-231-3/+8
| | | |
| * | | In guard filtering code, warn if the filter is too small according to guard ↵Neel Chauhan2021-11-221-1/+8
| | | | | | | | | | | | | | | | params
* | | | Merge branch 'begindir_test_fix' into 'main'eta2021-11-231-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Try to make the tor_proto::circuit::begindir test more reliable. See merge request tpo/core/arti!142
| * | | | Try to make the tor_proto::circuit::begindir test more reliable.Nick Mathewson2021-11-231-2/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I traced the problem here to the fact that sometimes "rx" in this test would be dropped before the test was done. When "rx" is dropped, the channel reactor shuts down, which in turn kills off the circuit reactor. This bug may exist in other cases in these tests. This patch may fix one case of #238.
* | | | Add usage string from commit message to with_coverage.Nick Mathewson2021-11-231-0/+3
| | | |
* | | | add with_coverage scriptTrinity Pointard2021-11-231-0/+30
| |/ / |/| | | | | | | | | | | usage: with_coverage <command> [args...]: run <command> with [args...] with_coverage : run bash
* | | Merge branch 'event-warnings' into 'main'eta2021-11-232-0/+40
|\ \ \ | | | | | | | | | | | | | | | | Add and resolve clippy warnings in tor-events. See merge request tpo/core/arti!138
| * | | Add and resolve clippy warnings in tor-events.Nick Mathewson2021-11-222-0/+40
| |/ / | | | | | | | | | | | | Here we add the same array of clippy warnings as usual to the new tor-event crate, and resolve the issues that triggered any of them.
* / / Fix typo in tor-guardmgr comment related to suspicious guardsNeel Chauhan2021-11-221-1/+1
|/ /
* | Merge branch 'arti-client-config' into 'main'eta2021-11-2214-179/+532
|\ \ | | | | | | | | | | | | Further configuration refactoring See merge request tpo/core/arti!137
| * | Implement meta-builder pattern for TorClientConfigNick Mathewson2021-11-223-21/+187
| | | | | | | | | | | | | | | This should be ergonomic than having to construct every section of the configuration separately.
| * | Make every Config type implement Eq.Nick Mathewson2021-11-218-17/+17
| | | | | | | | | | | | | | | Doing this is necessary for reconfiguration support, and will help a lot with testing, too.
| * | For every* config type, make defaults consistent.Nick Mathewson2021-11-213-7/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch makes sure that for every* config type we have, the defaults you get from a Builder match those you get from Serde, and that both match the value that you get from arti_defaults.toml. Later down the line I'll be adding some tests to keep these in sync. * StorageConfig still has no defaults of its own, since we aren't so sure we want other applications to use Arti's directories by default.
| * | Rename .gitignore APP_FOO to ARTI_FOO.Nick Mathewson2021-11-214-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | Since these shell-variables are hardwired to use org.torproject.Arti as the program name, it isn't appropriate to call them "app-specific". If we someday reinstate APP_FOO, it should be based on a user-provided application name.