summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | lints: Add let_unit_value allow to all cratesIan Jackson2022-05-3135-1/+35
| | | | | | | | | | | | | | | | | | | | From running add_warning, with manual picking of the right hunks/lines.
| * | | lints: Add let_unit_value allow to add_warningIan Jackson2022-05-311-0/+1
| | | | | | | | | | | | | | | | | | | | add_warning can now add allows. This one was agreed in some other MR for one crate. Allow it everywhere.
| * | | lints: Add two missing ones to add_warningIan Jackson2022-05-311-0/+2
| | | | | | | | | | | | | | | | | | | | These were in some crates, but not all. Put them in add_warning where they will propagate everywhere.
| * | | lints: arti: Move some allows outside the auto blockIan Jackson2022-05-311-2/+4
| | | | | | | | | | | | | | | | These need to survive.
| * | | lints: maint/add_warning: New marker-based modeIan Jackson2022-05-311-35/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't process the in-script lint block, just paste it in, now. This is less complicated. This reverts/replaces "maint/add_warnings: Make it add the markers for its future self"
| * | | lints: Add lint block delimiters to every crateIan Jackson2022-05-3136-0/+72
| | | | | | | | | | | | | | | | | | | | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
| * | | maint/add_warnings: Make it add the markers for its future selfIan Jackson2022-05-311-0/+6
| | | | | | | | | | | | | | | | We'll run this in a moment. Then we'll revert it.
| * | | lints: arti-config: Re-add standard lint listIan Jackson2022-05-311-0/+30
| | | | | | | | | | | | | | | | We are going to make lints the same for every crate.
| * | | lints: maint/add_warning: Improve orderingIan Jackson2022-05-311-1/+1
| | | | | | | | | | | | | | | | | | | | The crates we have aren't consistent. But changing this means the deltas resulting from the script are smaller.
| * | | maint/add_warnings: Tidy up, and add some commentaryIan Jackson2022-05-311-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | This puts the actually-used lint list at the top. No functional change.
| * | | lints: Suppress unknown lints in a way that works on nightly tooIan Jackson2022-05-311-2/+4
| | |/ | |/| | | | | | | This is ridiculous.
* | | Merge branch 'data-stream-err' into 'main'Nick Mathewson2022-05-311-1/+4
|\ \ \ | | | | | | | | | | | | | | | | proto: Only ready a DataStream if CONNECTED was succesfully received See merge request tpo/core/arti!556
| * | | proto: Only ready a DataStream if CONNECTED was succesfully receivedDavid Goulet2022-05-311-1/+4
| | | | | | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
* | | | Merge branch 'config-test' into 'main'Ian Jackson2022-05-319-25/+275
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | arti config: Check that example config is exhaustive See merge request tpo/core/arti!546
| * | | | tor-config: Suppress unwrap lint in testsIan Jackson2022-05-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/546#note_2808892
| * | | | tor-config: resolve_option tests: disable rsutfmtIan Jackson2022-05-311-0/+1
| | | | |
| * | | | tor-config: Add comprehensive tests for resolve_optionIan Jackson2022-05-311-0/+71
| | | | |
| * | | | arti: Demote itertools back to dev-dependencyIan Jackson2022-05-311-1/+1
| | | | |
| * | | | arti config: Check that example config is exhaustiveIan Jackson2022-05-303-0/+120
| | | | | | | | | | | | | | | | | | | | This is the final piece of #457.
| * | | | mistrust: Canonicalise prefix from Some("") to NoneIan Jackson2022-05-302-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | This allows us to add the proper default example to the arti example config file.
| * | | | arti: config: Canonicalise ports, and provide example dns_portIan Jackson2022-05-302-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the validated configuration will never be `Some(0)`, even if that is what was written in the config file. The arti CLI parser can still produce this, so we don't touch the code that actually uses this. (Without the canonicalisation the default builder produces `None` for the `dns_port`, but the example would produce `Some(0)`, which is semantically identical but fails the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
| * | | | config: Provide tor_config::resolve_option and resolve journaldIan Jackson2022-05-303-3/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Canonicalise the `logging.journald` setting in the validated configuration. Now it will never be `Some("")`, even if that is what was written in the config file. This allows us to write `journald = ""` in the example configuration. (Without the canonicalisation the default builder produces `None` and the example would produce `Some("")`, which are semantically identical but fail the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
| * | | | arti: config example: Add entries for tor_network fieldsIan Jackson2022-05-301-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | These weren't previously discussed. It's not practical or useful to show the actual default values here.
| * | | | arti: config example: Add some missing defaultsIan Jackson2022-05-301-3/+17
| | | | | | | | | | | | | | | | | | | | Found by my forthcoming test.
| * | | | arti: example config: Arrange to uncomment logfilesIan Jackson2022-05-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | This makes the config default parser see just "[ ]", an empty list, which is indeed the default.
| * | | | tor-config: Drop Serialize and Deserialize from a test typeIan Jackson2022-05-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | These violate our rule that *built* structs ought not to be desr. But this is just in a test.
| * | | | arti: Make ProxyConfig no longer DeserializeIan Jackson2022-05-301-4/+1
| | | | | | | | | | | | | | | | | | | | That this remained was an oversight.
| * | | | arti: cfg: Actually uncomment *all* the things in the exampleIan Jackson2022-05-301-1/+1
| | | | |
| * | | | tor-dirmgr: Fix DirSkewToleranceIan Jackson2022-05-301-2/+2
| | |/ / | |/| | | | | | | | | | | | | | | | | | This was upposed to be one day, I presume! Also complete a truncated sentence in the docs.
* | | | Merge branch 'self_digests_error_if_0' into 'main'Ian Jackson2022-05-312-2/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-dirclient: Require that self.digests is nonempty See merge request tpo/core/arti!553
| * | | | tor-dirclient: Require that self.digests is nonemptyNeel Chauhan2022-05-302-2/+11
| |/ / /
* | | | Merge branch 'config-desc' into 'main'Nick Mathewson2022-05-311-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | arti-config: Change description of tombstone crate See merge request tpo/core/arti!558
| * | | | arti-config: Change description of tombstone crateIan Jackson2022-05-311-1/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was looking to see if we could delete this altogether but I discovered that on lib.rs the description does not say it's a removed crate, in the summaries. Fix this.
* | | | Merge branch 'tor-config-tests' into 'main'Nick Mathewson2022-05-314-1/+122
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | Add a few coverage-based tests to tor-config. See merge request tpo/core/arti!540
| * | | Add a few coverage-based tests to tor-config.Nick Mathewson2022-05-314-1/+122
| | | | | | | | | | | | | | | | There's nothing major here, but it does fill in a few gaps.
* | | | Merge branch 'dbg' into 'main'Nick Mathewson2022-05-311-0/+5
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | Revert "Remove dbg!()s in tor-config" See merge request tpo/core/arti!552
| * | | Revert "Remove dbg!()s in tor-config"Ian Jackson2022-05-271-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was done because Nightly Rust complained about these, despite them all being in tests. That is now fixed upstream: https://github.com/rust-lang/rust-clippy/issues/8758 https://github.com/rust-lang/rust-clippy/pull/8838 This reverts commit 9d26a91886990b08dc5b6033c290d417489c61fc.
* | | | Merge branch 'post-release-fix-20220527' into 'main'Ian Jackson2022-05-302-1/+2
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | Fix minor issues found while publishing crates for Arti 0.4.0 See merge request tpo/core/arti!547
| * | | tor-rtcompat: Fix a warning when building with no backends.Nick Mathewson2022-05-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cargo publish (and probably nobody else!) builds this crate with no features enabled. When you do that, you get a warning about an unused `use std::io`. Fixing that.
| * | | Move tor-error crate to the "rust-patterns" category.Nick Mathewson2022-05-271-1/+1
| | | | | | | | | | | | | | | | There is no "tor" category; crates.io warned about this.
* | | | Merge branch 'bug487' into 'main'Ian Jackson2022-05-301-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fs-mistrust: add getegid() to getgrouplist() output. Closes #487 See merge request tpo/core/arti!548
| * | | | fs-mistrust: add getegid() to getgrouplist() output.Nick Mathewson2022-05-271-0/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a unit test failure in weird environments (like some containers) where the current effective GID is not included in the list of current groups. Closes #487. Bug reported by @sjm217.
* | | | Merge branch 'arti-cfg-tests' into 'main'Ian Jackson2022-05-301-0/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | add unit tests for ArtiConfig public functions See merge request tpo/core/arti!551
| * | | | add unit tests for ArtiConfig public functionsmichael mccune2022-05-281-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | this change adds some simple tests for the ArtiConfig public getter functions to help expand coverage in this crate.
* | | | | Merge branch 'chore/integrate_cargo_sort' into 'main'Ian Jackson2022-05-3035-258/+262
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lexically sort Cargo.toml dependencies Closes #490 See merge request tpo/core/arti!549
| * | | | | Lexically sort Cargo.toml dependenciesOrhun Parmaksız2022-05-2835-258/+262
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Utilize cargo-sort: https://github.com/DevinR528/cargo-sort Signed-off-by: Orhun Parmaksız <[email protected]>
* | | | | Merge branch 'per_crate_semver' into 'main'Ian Jackson2022-05-301-13/+35
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Update semver_status.md with new procedure. See merge request tpo/core/arti!545
| * | | | | Update semver_status.md with new procedure.Nick Mathewson2022-05-271-13/+35
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Now (per discussion on #471) we use one file per crate. I've tried to be more explicit about the format to use, and what to add when.
* | | | | Merge branch 'mistrust_osstring_limitation' into 'main'Ian Jackson2022-05-302-4/+13
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | fs-mistrust: Document problems with non-UTF8 OsString in toml See merge request tpo/core/arti!538
| * | | | | fs-mistrust: Document problems with non-UTF8 OsString in tomlNick Mathewson2022-05-262-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that the `toml` crate can't handle OsString, since `toml` doesn't support serialize_newtype_variant, and the `serde` crate tries to serialize OsString using that method. In this commit we document that limitation, and test that we can at least round-trip through json. Found by inspecting test coverage.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 18:18:08 +0000