| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Merge branch 'clippy' into 'main' | Ian Jackson | 2022-06-24 | 50 | -27/+267 |
| |\ | | | | | | | | | Fix clippy nightly again See merge request tpo/core/arti!603 | ||||
| | * | maint/add_warning: Fix parsing of --check | Ian Jackson | 2022-06-24 | 1 | -1/+1 |
| | | | | | | | | | Previously this would eat the first filename! | ||||
| | * | clippy: Consolidate many lints in maint/add_warning | Ian Jackson | 2022-06-24 | 13 | -7/+66 |
| | | | | | | | | | | | | | Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. | ||||
| | * | clippy: Add standard test lint block to several examples | Ian Jackson | 2022-06-24 | 5 | -0/+30 |
| | | | |||||
| | * | maint/add_warning: Add two lints via add_warning as a test case | Ian Jackson | 2022-06-24 | 2 | -0/+4 |
| | | | |||||
| | * | maint/add_warning: Add ability maintain test lint blocks | Ian Jackson | 2022-06-24 | 2 | -8/+37 |
| | | | |||||
| | * | maint/add_warning: Scan all files by default, but insist only in some | Ian Jackson | 2022-06-24 | 2 | -10/+17 |
| | | | | | | | | | | | | | | | This will allow us to have add_warning manage test lint blocks. We have to stop printing all the filenames because there are too many. Filenames still come out on error of course. | ||||
| | * | Run maint/add_warning crates/*/src/{lib,main}.rs | Ian Jackson | 2022-06-23 | 36 | -0/+108 |
| | | | | | | | | | Update all lint blocks | ||||
| | * | clippy: Supresss clippy::significant_drop_in_scrutinee | Ian Jackson | 2022-06-23 | 1 | -0/+1 |
| | | | | | | | | | As per the linked discussion. | ||||
| | * | lints: Scheme for allowing us to name nightly lints | Ian Jackson | 2022-06-23 | 1 | -1/+3 |
| | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/issues/501 | ||||
| | * | ci: Pass --cfg ci_arti_stable to stable clippy | Ian Jackson | 2022-06-23 | 1 | -1/+1 |
| | | | | | | | | | We're going to use this to control lints etc. | ||||
| * | | Merge branch 'dirmgr' into 'main' | Nick Mathewson | 2022-06-24 | 1 | -53/+49 |
| |\ \ | | | | | | | | | | | | | | | | | | | dirmgr: followups to !587, mostly using iterators Closes #468 See merge request tpo/core/arti!599 | ||||
| | * | | dirmgr: Use ... .find().is_none() rather than clippy's suggestion | Ian Jackson | 2022-06-23 | 1 | -2/+4 |
| | | | | |||||
| | * | | dirmgr: DirBootstrapStatus: Refactor mut_status_for using entries_mut | Ian Jackson | 2022-06-22 | 1 | -27/+25 |
| | | | | | | | | | | | | | IMO this is rather less confusing. | ||||
| | * | | dirmgr: Use new statuses() helper method | Ian Jackson | 2022-06-22 | 1 | -21/+6 |
| | | | | | | | | | | | | | The two call sites become clearer, IMO. | ||||
| | * | | dirmgr: DirBootstrapStatus: Provide statuses and entries_mut | Ian Jackson | 2022-06-22 | 1 | -3/+18 |
| | | | | | | | | | | | | | | | | | | | | | | We're going to use these in a moment. One returns entries and the other statuses simply because that's what's actually going to be wanted. | ||||
| | * | | dirmgr: Remove a TODO comment | Ian Jackson | 2022-06-22 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/587#note_2815945 | ||||
| * | | | Start a changelog for Arti 0.5.0 | Nick Mathewson | 2022-06-24 | 1 | -0/+88 |
| | | | | |||||
| * | | | Merge branch 'error_cleanup_2' into 'main' | eta | 2022-06-24 | 24 | -162/+303 |
| |\ \ \ | | | | | | | | | | | | | | | | | Error refactoring: bytes, cert, proto. See merge request tpo/core/arti!604 | ||||
| | * | | | tor-proto: split and elaborate tor_bytes::Error instances | Nick Mathewson | 2022-06-23 | 14 | -55/+145 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some of these were for decoding particular objects (we now say what kind of objects), and some were unrelated tor_cert errors that for some reason we had shoved into a tor_bytes::Error. There is now a separate tor_cert::CertError type, independent from tor_cert's use of `tor_bytes::Error` for parsing errors. | ||||
| | * | | | tor-proto: Split CellErr based on activity. | Nick Mathewson | 2022-06-23 | 6 | -18/+54 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Failing to encode is fundamentally different from failing to decode. We now treat those separately, and describe _what_ we failed to encode or decode. | ||||
| | * | | | tor-proto: clean up error names and messages | Nick Mathewson | 2022-06-23 | 12 | -85/+90 |
| | | | | | | | | | | | | | | | | | | | | | This avoids adding additional information for now; that will come on the next commits. | ||||
| | * | | | tor-bytes: Split EncodeError from Error | Nick Mathewson | 2022-06-23 | 3 | -8/+18 |
| | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since there is currently only one error type that can occur when encoding, it doesn't make sense to use the full Error type here. This split will help us downstream, as we no longer need to categorize tor_bytes::Error as "an error in encoding or decoding". I considered renaming Error to DecodeError, but that had pretty huge downstream effects, and didn't seem to be worth it. | ||||
| * | | | Fix a couple of typos in rustdoc comments. | Nick Mathewson | 2022-06-24 | 2 | -2/+2 |
| | | | | |||||
| * | | | Update README.md files from rustdoc. | Nick Mathewson | 2022-06-24 | 5 | -127/+199 |
| | | | | |||||
| * | | | Run cargo upgrade in preparation for release. | Nick Mathewson | 2022-06-24 | 1 | -10/+10 |
| | | | | |||||
| * | | | Merge branch 'tor-netdoc/use-base64ct' into 'main' | Ian Jackson | 2022-06-23 | 4 | -14/+83 |
| |\ \ \ | |/ / |/| | | | | | | | | Replace `base64` crate with `base64ct` crate in `tor-netdoc` See merge request tpo/core/arti!600 | ||||
| | * | | base64: Move some tests into a separate function, placating clippy | Ian Jackson | 2022-06-23 | 1 | -11/+15 |
| | | | | |||||
| | * | | base64: Add yet more test cases | Ian Jackson | 2022-06-23 | 1 | -0/+17 |
| | | | | |||||
| | * | | Add some more test cases for base64 | Arturo Marquez | 2022-06-22 | 1 | -0/+17 |
| | | | | | | | | | | | | | | | | These tests are borrowed from other parts of the `tor-netdoc` crate. | ||||
| | * | | Improve base64 tests | Arturo Marquez | 2022-06-22 | 1 | -1/+13 |
| | | | | | | | | | | | | | Request for changes: `https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/600#note_2816252` | ||||
| | * | | Add link to upstream issue | Arturo Marquez | 2022-06-22 | 1 | -1/+3 |
| | | | | | | | | | | | | | As per request, here: `https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/600#note_2816252` | ||||
| | * | | Remove unused `base64` crate | Arturo Marquez | 2022-06-21 | 2 | -2/+0 |
| | | | | |||||
| | * | | Replace `base64` crate with `base64ct` crate | Arturo Marquez | 2022-06-21 | 4 | -11/+30 |
| | |/ | | | | | | | | | | | | | Note: the `base64ct` crate rejects invalid characters when the decoding is done on padded strings. However, the `FromStr` impl for `B64` can have both padded **and** unpadded inputs, so all inputs are now padded first, before decoding. | ||||
| * | | Merge branch 'error_cleanup' into 'main' | Nick Mathewson | 2022-06-22 | 28 | -81/+128 |
| |\ \ | |/ |/| | | | | | Error cleanup, part 1 See merge request tpo/core/arti!601 | ||||
| | * | fs-mistrust: convert Io error variant to a struct. | Nick Mathewson | 2022-06-22 | 2 | -6/+18 |
| | | | |||||
| | * | tor-cell: convert BytesErr to a struct variant | Nick Mathewson | 2022-06-22 | 4 | -7/+22 |
| | | | |||||
| | * | tor-cell: error usefulness and style fixes | Nick Mathewson | 2022-06-22 | 6 | -17/+26 |
| | | | |||||
| | * | Improve error messages in tor-checkable. | Nick Mathewson | 2022-06-22 | 3 | -3/+5 |
| | | | |||||
| | * | tor-socksproto: Style and info fixes in errors. | Nick Mathewson | 2022-06-22 | 4 | -9/+16 |
| | | | | | | | | | | | (The use of Cow<> in the error message isn't strictly necessary here, but it's a pattern I want to encourage.) | ||||
| | * | Style fixes to tor-bytes errors. | Nick Mathewson | 2022-06-22 | 1 | -5/+9 |
| | | | | | | | | | | | Also note an issue with the design of tor-bytes::Error that should probably go in a separate MR. | ||||
| | * | Style fixes to tor-protover errors. | Nick Mathewson | 2022-06-22 | 1 | -3/+3 |
| | | | |||||
| | * | tor-llcrypto: style fixes on BlindingError | Nick Mathewson | 2022-06-22 | 1 | -2/+2 |
| | | | |||||
| | * | Style fixes to tor-units errors. | Nick Mathewson | 2022-06-22 | 1 | -2/+2 |
| | | | |||||
| | * | Style fixes to tor-events errors. | Nick Mathewson | 2022-06-22 | 1 | -2/+2 |
| | | | |||||
| | * | tor-config: style fixes on CfgPathError. | Nick Mathewson | 2022-06-22 | 1 | -6/+6 |
| | | | |||||
| | * | tor-config: Don't format source error as part of error message | Nick Mathewson | 2022-06-22 | 1 | -2/+2 |
| | | | | | | | | | This is one I missed earlier. | ||||
| | * | Style fixes to retry-error error messages. | Nick Mathewson | 2022-06-22 | 1 | -3/+3 |
| | | | |||||
| | * | Style fixes to safelog errors. | Nick Mathewson | 2022-06-22 | 1 | -3/+3 |
| | | | |||||
| | * | Editorial improvements on fs-mistrust errors | Nick Mathewson | 2022-06-22 | 6 | -24/+22 |
| | | | | | | | | | | | | | These changes make sure that the errors conform to our preferred style, and include a description of what exactly we were doing when something went wrong. | ||||
