summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | tor-llcrypto: Put currently unused functions behind features.Nick Mathewson2021-11-125-9/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't currently need a couple of the key manipulation features that we have, since we aren't yet doing relays or onion service clients. Part of #125
* | | | Merge branch 'issue_222' into 'main'eta2021-11-169-730/+804
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use tor_rtcompat::test_with_all_runtimes!() in place of #[tokio::test] Closes #222 See merge request tpo/core/arti!130
| * | | | tor-proto: Use tor-rtcompat macros for testing, not tokio.Nick Mathewson2021-11-157-712/+790
| | | | | | | | | | | | | | | | | | | | Closes #222.
| * | | | tor-proto: Stop using async_test in halfstream.rs and sendme.rsNick Mathewson2021-11-152-18/+14
|/ / / / | | | | | | | | | | | | Thanks to eta's refactoring, these tests no longer need to be async.
* | / / Update to simple_asn1 0.6.1.Nick Mathewson2021-11-142-3/+3
| |/ / |/| | | | | | | | | | | | | | This is a security fix for a panic. Closes #236
* | | A few more eprintln!() removals that I missed.Nick Mathewson2021-11-131-4/+0
| | |
* | | Replace or remove testing eprintln!()s.Nick Mathewson2021-11-131-3/+4
| | | | | | | | | | | | | | | The clippy code for warning about these on nightly CI can't tell the difference between cfg(test) and no cfg(test).
* | | Resolve a dead-code warning on nightly.Nick Mathewson2021-11-131-0/+2
| | | | | | | | | | | | The `circid` field in `ClientCirc` is now testing-only.
* | | Remove the unused `published` field from GenericRouterStatus.Nick Mathewson2021-11-123-23/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | This field isn't used in modern Tor, and has never been used in Arti. If tor!489 is merged, then it will no longer contain a useful value in future consensuses. We shouldn't store it, or else somebody else will get the smart idea of using it for something. This commit breaks API compatibility for tor-netdoc with the `build_docs` feature enabled. I haven't entered that into the semver_status.md file, since we already have a pending tor-netdoc API breaker in !129.
* | Merge remote-tracking branch 'origin/mr/128'Nick Mathewson2021-11-121-4/+8
|\ \ | |/ |/|
| * normalize --target to better reuse build artifactsTrinity Pointard2021-11-121-3/+3
| | | | | | | | | | | | | | testing was done on a different target than building, so everything was compiled twice (actually, it's the same target, but rust doesn't realize that) makes build+test about 20% faster
| * try to cache cargo-auditTrinity Pointard2021-11-121-1/+5
| |
* | Merge branch 'proto-circuit-refactor' into 'main'eta2021-11-1216-1378/+1553
|\ \ | |/ |/| | | | | Completely overhaul the tor-proto circuit reactor See merge request tpo/core/arti!126
| * Get rid of unbounded stream sender, and RawCellStreameta2021-11-129-149/+183
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the reactor would use an `UnboundedSender` to send things to the `RawCellStream`, in order that the reactor wouldn't block if you failed to read from the latter. This is bad, though, since it means people can just run us out of memory by sending lots of things. To fix this, we make the new `StreamReader` type (which does the reading parts from `RawCellStream`) keep track of the stream's receive window and issue SENDMEs once *it* has consumed enough data to require it, thus meaning that we shouldn't get sent enough data to fill the channel between reactor and `StreamReader` (and, if we do, that's someone trying to flood us, and we abort the circuit). As hinted to above, the `RawCellStream` was removed and its reading functionalities replaced by `StreamReader`; its writing functionalities are handled by `StreamTarget` anyway, so we just give out one of those for the write end. This now means we don't need any mutexes! note: this commit introduces a known issue, arti#230
| * Completely overhaul the tor-proto circuit reactoreta2021-11-1212-1298/+1439
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather like e8e9699c3c239d6c30f9ad414f15d3bad6ec03fd ("Get rid of tor-proto's ChannelImpl, and use the reactor more instead"), this admittedly rather large commit refactors the way circuits in `tor-proto` work, centralising all of the logic in one large nonblocking reactor which other things send messages into and out of, instead of having a bunch of `-Impl` types that are protected by mutexes. Congestion control becomes a lot simpler with this refactor, since the reactor can manage both stream- and circuit-level congestion control unilaterally without having to share this information with consumers, meaning we can get rid of some locks. The way streams work also changes, in order to facilitate better handling of backpressure / fairness between streams: each stream now has a set of channels to send and receive messages over, instead of sending relay cells directly onto the channel (now, the reactor pulls messages off each stream in each map, and tries to avoid doing so if it won't be able to forward them yet). Additionally, a lot of "close this circuit / stream" messages aren't required any more, since that state is simply indicated by one end of a channel going away. This should make cleanup a lot less brittle. Getting all of this to work involved writing a fair deal of intricate nonblocking code in Reactor::run_once that tries very hard to be mindful of making backpressure work correctly (and congestion control); the old code could get away with having tasks .await on things, but the new reactor can't really do this (as it'd lock the reactor up), so has to do everything in a nonblocking manner.
* Merge branch 'typos' into 'main'eta2021-11-126-7/+7
|\ | | | | | | | | Fix typos See merge request tpo/core/arti!127
| * Fix typosDimitris Apostolou2021-11-126-7/+7
| |
* | Upgrade to async-native-tls 0.4.0Nick Mathewson2021-11-122-4/+4
|/
* Remove usage of tracing-test 0.1Nick Mathewson2021-11-113-84/+4
| | | | | | | | It requires tracing-subscriber 0.2, which is a lower version than we want, and which causes trouble with our minimal-versions CI test. There is a pending issue to fix this; we can reinstate tracing-test once it is merged: https://github.com/dbrgn/tracing-test/pull/11
* Document that the "experimental-api" feature is not semver-covered.Nick Mathewson2021-11-113-0/+14
|
* Document that the "testing" feature is not semver-covered.Nick Mathewson2021-11-113-0/+8
|
* Add a file to track per-crate semver status.Nick Mathewson2021-11-111-0/+25
|
* Tests for tor-dirmgr::bootstrapNick Mathewson2021-11-115-5/+305
|
* Minor tests for DirMgr::query_into_requestsNick Mathewson2021-11-111-0/+39
|
* Merge IpVersionPreferences and the optimistic flag into one type.Nick Mathewson2021-11-104-25/+100
| | | | | It seems like a good time to do this, before we add a zillion other arguments to begin_stream.
* Refactor wait_for_connection a bit.Nick Mathewson2021-11-101-12/+14
| | | | | | | * Make it crate-visible only. * Make it idempotent * Have it be an internal error if it's called at the wrong time. * Simplify the return logic.
* Merge remote-tracking branch 'origin/mr/116'Nick Mathewson2021-11-103-24/+63
|\
| * Implement optimistic streamYuan Lyu2021-11-093-24/+63
| |
* | Require consensus-diff line 2 to start with "hash "Nick Mathewson2021-11-101-1/+1
| | | | | | | | | | | | Previously we didn't check for the space. Closes #225.
* | tor-dirmgr: tests for making and expanding consensus requests.Nick Mathewson2021-11-101-0/+125
| |
* | tor-dirmgr: Tests for high-level loading functions.Nick Mathewson2021-11-101-3/+152
|/
* Merge branch 'binary_size_script'Nick Mathewson2021-11-091-0/+33
|\
| * Add a shell script to find binary size and download size.Nick Mathewson2021-11-091-0/+33
| | | | | | | | | | | | | | It formats them in a nice little json object, which it writes to stdout. Part of arti#172
* | Merge branch 'S0AndS0/arti-cargo-husky' into HEADeta2021-11-093-3/+34
|\ \
| * | Reorder Cargo Husky hooksS0AndS02021-08-252-6/+6
| | | | | | | | | | | | | | | | | | Format checks seem to be the fastest operation, and tests are the slowest. Reordering Git hook tasks from swiftest to slowest should provide quicker automated feedback when committing and/or pushing.
| * | Add custom "cargo-husky" hook scriptsS0AndS02021-08-173-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Check the Read Me file for Cargo Husky crate for details > > https://github.com/rhysd/cargo-husky#readme These changes allow for local `git commit` and `git push` related hooks to more closely match remote CI/CD operations. Most notably the `cargo clippy...` lint command from ".gitlab-ci.yml" file now may guard against committing/pushing code that would otherwise cause CI/CD pipeline failures.
* | | Merge branch 'binary_size' into 'main'eta2021-11-091-1/+20
|\ \ \ | | | | | | | | | | | | | | | | Tune the 'profile.release' options for a smaller compile size. See merge request tpo/core/arti!124
| * | | Tune the 'profile.release' options for a smaller compile size.Nick Mathewson2021-11-081-1/+20
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By enabling link-time optimization, setting 'opt-level=s', and setting compilation-units=1, we can get a much smaller download size, which is one of our objectives. Making these changes reduces the binary size for me (on x86_64) by about 42%. If you also run "strip --strip-debug" on the resulting binary, the resulting size is 55% smaller than the original binary size. These effects persist if you compress the binary. Supposing that we use xz compression, these options make save 32% of compressed binary size. If we also "strip --strip-debug" before compressing, the compressed binary saves 43% from the original binary size. With all of these options applied, on x86_64 linux with xz compression, we're at a nice 1.5 MiB download. If we statically link to openssl and sqlite, we're still only at a 2.8 MiB download. There is a build time cost to these changes: for me, it comes to a 10%-25% build time increase. This is part of arti#172.
* | | Remove doubly incorrect entry from WANT_FROM_OTHER_CRATESNick Mathewson2021-11-081-3/+0
| | |
* | | Add a couple of pieces of missing documentation.Nick Mathewson2021-11-082-4/+6
|/ /
* | More tests on tor-dirmgr::stateNick Mathewson2021-11-083-27/+113
| | | | | | | | | | These test our download schedules, resetting to the original state, and storing downloaded objects.
* | Merge branch 'ci-no-printf' into 'main'eta2021-11-052-1/+5
|\ \ | | | | | | | | | | | | | | | | | | In rust-nightly CI, forbid debugging prints. Closes #218 See merge request tpo/core/arti!123
| * | In rust-nightly CI, forbid debugging prints.Nick Mathewson2021-11-042-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch makes the rust-nightly CI task fail if it detects any dbg!(), println!(), or eprintln!() calls in production code. Because of clippy limitations, it may also gripe about calls to these macros in our tests. The preferred workarounds are to either instead. Both are acceptable. We're doing this check in CI rather than unconditionally with clippy directives, since we often want to have these calls in our code temporarily while we're developing. Some day we might want this test to go into a pre-push hook. This patch also adds #![allow()] directives for println!() and eprintln!() in the arti crate. Since that one isn't a library, it's okay for it to speak to stdout/stderr. Closes #218.
* | | Merge branch 'osx_sdk_10.12'Nick Mathewson2021-11-041-3/+10
|\ \ \ | |/ / |/| |
| * | Update reproducible_build.sh to use OSX SDK 10.12Nick Mathewson2021-11-041-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need this for clock_gettime_nsec_np(). The source is not canonical, but neither was the one we were using before. To mitigate this, I've added a digest check on the SDK after downloading it. A 100% real canonical reproducible build process will probably require Apple hardware anyway. Closes #221
* | | Remove one more test println!().Nick Mathewson2021-11-041-1/+0
| | |
* | | Replace all println/eprintln calls outside of arti CLI with trace.Nick Mathewson2021-11-048-30/+40
| | |
* | | Remove all remaining dbg! instances.Nick Mathewson2021-11-044-11/+0
| | |
* | | tor-dirmgr: tests for docid module.Nick Mathewson2021-11-041-1/+156
|/ /
* | Basic tests for readonly estimators, and estimator migration.Nick Mathewson2021-11-032-2/+92
| | | | | | | | | | Also add a comment about a possible problem behavior in read-only estimators.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 15:55:16 +0000