summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Explain problems with APIs in linkspec::traits.Nick Mathewson2020-10-181-2/+6
|
* Resolve XXXXM3 comments in caret crateNick Mathewson2020-10-181-5/+28
|
* Mark must-resolve XXXX issues with "XXXXM3".Nick Mathewson2020-10-1819-56/+52
| | | | | | | | | | "M3" is for "milestone 3" -- my target to fix the technical debt that I think will be bad if we ship even a pre-alpha with it. These aren't necessarily _all_ must-resolve, but they're all must-look-at. Closes #15
* More notes in README.md: assumed proposals, stability (non)guaranteeNick Mathewson2020-10-181-0/+8
|
* Update microdesc parsing: ed25519 keys are no longer optional.Nick Mathewson2020-10-181-10/+8
|
* Clarify TODOs in tor-protoverNick Mathewson2020-10-181-3/+4
|
* tor-linkspec: remove a completed TODONick Mathewson2020-10-181-2/+0
|
* Remove a comment about a spec clarificationNick Mathewson2020-10-181-2/+0
| | | | This was fixed as torspec#30
* Resolve XXXX items in tor-cert crate.Nick Mathewson2020-10-182-2/+3
|
* Clarify kludgey magic in our to_der() function.Nick Mathewson2020-10-182-2/+7
|
* List supported/unsupported subprotocols in the READMENick Mathewson2020-10-181-1/+58
|
* Cleanup from prop315 implementation.Nick Mathewson2020-10-163-16/+11
| | | | | | | | Most of the fixes here are just removing comments that said "this isn't technically required but I'm going to pretend it is". I also made the "protocols" field in microdescs out of its Option<>, since we're now requiring that.
* Implement proposal 315: make various directory fields requiredNick Mathewson2020-10-162-18/+8
|
* Update TODONick Mathewson2020-10-151-2/+2
|
* tor-proto: Add a ClientCircChanMsg type.Nick Mathewson2020-10-155-22/+43
| | | | | | This wraps exactly the ChanMsg values that are valid on open client circuits, so that we can be sure that only those cells are sent to a ClientCirc's reactor.
* tor-proto: Add a "CreateResponse" type.Nick Mathewson2020-10-155-15/+64
| | | | | | CreateResponse includes exactly those cells that are a correct response to a CREATE2/CREATE_FAST, so we can be sure that only those cells are actually passed to a PendingClientCirc.
* Run "cargo upgrade".Nick Mathewson2020-10-1510-16/+16
|
* Mark item done in todoNick Mathewson2020-10-151-2/+2
|
* Use Ed25519Identity in microdescriptors.Nick Mathewson2020-10-155-19/+41
|
* Add an (unchecked) Ed25519Identity typeNick Mathewson2020-10-153-6/+91
| | | | | This type differs from ed25519::PublicKey in that it is _not_ checked or expanded.
* llcrypto: Move ed25519 module into its own file.Nick Mathewson2020-10-153-77/+76
|
* Fix a couple of clippy warningsNick Mathewson2020-10-152-2/+2
|
* Turn the channel's ref to its circmap into a Weak referenceNick Mathewson2020-10-151-6/+11
| | | | | This way, when the channel reactor is dropped, the circuit map can get dropped too, which will cause reading circuits to notice.
* Mark channels as unusable if reactor gets an error.Nick Mathewson2020-10-153-1/+31
| | | | | Similarly as with circuits, we want this code to set a "closed" flag so that attempts to write on the channel will fail.
* Use weak references from circuit reactor to circimpl.Nick Mathewson2020-10-142-15/+30
| | | | This prevents the reactor from keeping the circuit alive forever.
* Use a weak reference from channel reactor to channel.Nick Mathewson2020-10-141-5/+7
|
* Send DESTROY cells when a circuit is dropped.Nick Mathewson2020-10-143-27/+161
| | | | | | | | | This reuses a lot of mechanism from the circuit code that sends END cells when streams are dropped. There is a problem here: Circuits and channels won't actually get dropped, because we should be using a weak reference from the reactor.
* TODO: Add and link tickets for Milestone 3 itemsNick Mathewson2020-10-131-16/+25
|
* Revise TODO and README; declare "milestone 2" done.Nick Mathewson2020-10-132-24/+24
| | | | | | Part of this "declaring milestone 2 done" business is a matter of putting additional tests and documentation into milestone 3 where they logically belong.
* Revise DropMark defense to use a better type and match Tor's behavior.Nick Mathewson2020-10-136-14/+99
|
* Document all private members in tor-protoNick Mathewson2020-10-1315-10/+133
|
* Make sure that protocol errors terminate the circuit responsible.Nick Mathewson2020-10-133-23/+59
|
* Improve handling of circuit closure or failure on reactor shutdown.Nick Mathewson2020-10-133-6/+37
| | | | | | | | | | We already handled the case okay when we were reading on streams, since the reactor's going away would drop the sender side of their mpsc channels. But if the reactor went away, nothing would tell _writing_ streams that they needed to close. Now we handle that case, as well as anybody who is waiting on a meta-cell to get back to them.
* Another tweak to handling closing streamsNick Mathewson2020-10-133-14/+40
| | | | | | When a stream is closed and we haven't adjusted its state in the stream map yet, remember how many cells we've dropped so we can decrement them from the window later on.
* Try giving distinct handling to streams where END has been sentNick Mathewson2020-10-126-54/+118
| | | | | | This is the first step along the line to handling Tor issue tor#27557. We want to remember streams that we've ended and treat them as distinct from streams that have never existed
* Tweak terminate hand handle_close() functions.Nick Mathewson2020-10-112-13/+20
| | | | | These need to become functions about terminating and noticing a termination request.
* Rename StreamMap::Closing to EndReceivedNick Mathewson2020-10-111-4/+4
| | | | This is in preparation for adding a different EndSent stream state.
* Test the pick_weighted function in tor-netdirNick Mathewson2020-10-101-0/+128
|
* Document remaining private members of tor-netdoc.Nick Mathewson2020-10-106-9/+259
|
* Document most private items in tor-netdoc.Nick Mathewson2020-10-0911-9/+115
|
* Document all the private items in tor-cellNick Mathewson2020-10-096-7/+97
| | | | | Also, change the type of the authentication challenge to be an array; it isn't in fact variable-length.
* Remove a couple of allow(unused) notationsNick Mathewson2020-10-092-2/+0
|
* mark off a TODO item.Nick Mathewson2020-10-091-1/+1
|
* Fix a pair of bugs in SENDME handling.Nick Mathewson2020-10-091-13/+10
| | | | | | | | | The problem is that we would count begin and end cells towards towards window totals when we are only supposed to count DATA cells, *and* that we would we send our sendmes one cell too early (or maybe late?). Closes #1.
* Move counts_towards_windows() code into circuit moduleNick Mathewson2020-10-096-19/+19
|
* client-main: Add an option to run a test more than onceNick Mathewson2020-10-092-6/+12
|
* add point estimates to TODONick Mathewson2020-10-091-37/+45
|
* check off the deadlock in the todo.Nick Mathewson2020-10-091-1/+1
|
* Split information about circuit hops into inbound and outbound.Nick Mathewson2020-10-092-61/+172
| | | | | | | | | | | | | | | | | | Previously the circuit object owned not only the outbound crypto, but also the inbound crypto and the stream maps. That's not so great, since the reactor needs to use the inbound crypto and the stream maps all the time, whereas the circuit doesn't need them much (or at all). Moving these objects to the reactor-owned structure should let us fix the deadlock case in stream sendme handling, since the circuit reactor no longer needs to lock the circuit in order to do crypto and demultiplexing. It should also speed up the code a bit, since it doesn't need to grab the circuit lock nearly so often as before. This change forced me to add a couple of new reactor CtrlMsg values, since the circuit can no longer add streams and layers directly. I think it will still be a performance win, though.
* Split client relay crypto into separate directionsNick Mathewson2020-10-093-77/+179
| | | | | I think we should have the reactor task own the reverse crypto and the circuit own the forward crypto.