summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | isolation: Refactor to introduce a bespoke enumIan Jackson2022-01-201-4/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No functional change. This will grow a new variant shortly.
* | | | | Merge branch 'docs-build' into 'main'Nick Mathewson2022-01-201-0/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | CONTRIBUTING: Document how to build the docs See merge request tpo/core/arti!255
| * | | | | CONTRIBUTING: Document how to build the docsIan Jackson2022-01-201-0/+2
|/ / / / / | | | | | | | | | | | | | | | Eventually we may need a separate HACKING.md
* | | | | Merge branch 'pathconfig_fixing' into 'main'Nick Mathewson2022-01-202-3/+34
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Refactor, fix, test PathConfig type See merge request tpo/core/arti!254
| * | | | | Test for PathConfig::at_least_as_permissive_as().Nick Mathewson2022-01-201-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is totally not just an exercise to get combined test coverage for tor-circmgr over 90% because I needed something to do that wouldn't distract anybody else. :)
| * | | | | Rename PathConfig::more_permissive_than()Nick Mathewson2022-01-202-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since it implements a "<=" type relationship, it should be called "at_least_as_permissive_as()." Since it's a crate-private function, the long name isn't too bad.
| * | | | | Remove "self" arg from PathConfig::builder()Nick Mathewson2022-01-201-1/+1
|/ / / / / | | | | | | | | | | | | | | | This was added by mistake.
* | | | | Merge branch 'stuff-prefs' into 'main'Nick Mathewson2022-01-202-21/+62
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide TorClient::set_default_prefs and clone_with_prefs Closes #290 See merge request tpo/core/arti!250
| * | | | | connection preferences: Make `set_default_prefs` private for nowIan Jackson2022-01-201-1/+4
| | | | | |
| * | | | | connection preferences: Make `clone_with_prefs` must_useIan Jackson2022-01-201-0/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/250#note_2771239
| * | | | connection preferences: Provide `clone_with_prefs` methodIan Jackson2022-01-191-0/+10
| | | | |
| * | | | connection preferences: Provide `set_connect_prefs` methodIan Jackson2022-01-191-6/+22
| | | | |
| * | | | connection preferences: Take ConnectPrefs by referenceIan Jackson2022-01-192-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | This may save quite a bit of copying. The callees don't need to copy the whole struct; they copy the bits they need.
| * | | | connection preferences: Rename variable and docs to not say "flags"Ian Jackson2022-01-191-12/+12
| | | | | | | | | | | | | | | | | | | | These aren't flags. Eg, there's an isolation token in there.
| * | | | isolation: Document orthogonality of isolated_client and isolation_groupIan Jackson2022-01-191-0/+11
| | | | |
* | | | | Merge branch 'coverage_toolchain' into 'main'eta2022-01-201-6/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | with_coverage: Allow toolchain selection. See merge request tpo/core/arti!253
| * | | | | with_coverage: Allow toolchain selection.Nick Mathewson2022-01-201-6/+7
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's some kind of bug in nightly that (for me) keeps grcov from generating correct results. Instead, it misses some crates entirely. No trouble, though: I can just use an older nightly until they get this issue fixed! This patch makes using a different version of nightly possible with a new RUST_COVERAGE_TOOLCHAIN environment variable.
* | | | | Merge branch 'msrv' into 'main'eta2022-01-201-5/+10
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | Adopt an initial MSRV policy. Closes #283 See merge request tpo/core/arti!247
| * | | | Adopt an initial MSRV policy.Nick Mathewson2022-01-191-5/+10
| | |/ / | |/| | | | | | | | | | Closes #283.
* | | | clippy: Rename a `decode_chanmsg` from `handle_`Ian Jackson2022-01-192-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025 It doens't really handle it.
* | | | handshake: Use read_exact, not read and checking lenIan Jackson2022-01-191-3/+7
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | read_exact has a loop in it, which we need. This means we end up separating the two sites that generate the "not a relay" error, so we need to fish out the error construction. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771023
* | | clippy: Rename a `from_foo` method that doesn't do conversionIan Jackson2022-01-193-5/+7
| | |
* | | Fix two bugs related to incomplete read/writeIan Jackson2022-01-191-3/+3
| | | | | | | | | | | | Discovered by clippy
* | | clippy: Suppress a warningIan Jackson2022-01-191-0/+3
|/ /
* | Merge branch 'bootstrap_reporting'Nick Mathewson2022-01-1912-54/+1218
|\ \
| * | bootstrap reporting: Documentation fixups from review.Nick Mathewson2022-01-192-2/+14
| | |
| * | Integrate status information at arti-clientNick Mathewson2022-01-182-40/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit combines status update information from tor-dirmgr and tor-chanmgr in the arti-client crate, so that the user can get to it; it represents a high-level view of the client's ability to reach the network and route traffic. I have omitted the tor-circmgr support for now; it's mostly not needed. At present it's not so useful, since there's no way for a client to get a TorClient that _isn't_ completely bootstrapped, and therefore there's no way to actually watch these events until they're no longer interesting. That should change with arti#293. This is part of #96.
| * | tor-chanmgr: Add bootstrap/status reporting.Nick Mathewson2022-01-185-5/+526
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The information is pretty basic here: we use "have we been able to connect/TLS-handshake/Tor-handshake" as a proxy for "are we on the internet? Are we on a reasonably unfiltered part of the internet?" Eventually we'll want to make the information gathered and exported more detailed: I've noted a few places in the code. For now, however, this is about as good as C Tor does today, and it should be a good starting point. This uses a slightly different design from tor-dirmgr. Instead of exporting an entire state structure via `postage::watch`, it exports only the parts of that structure which the user is supposed to read. I think that's more reasonable in this case because most of the possible internal transitions in the tor-chanmgr state don't cause a change in the exposed status.
| * | tor-dirmgr: Create a bootstrap-status exporting mechanism.Nick Mathewson2022-01-186-9/+598
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The interface is similar to the one exposed by `arti-client`: it internally uses postage::watch to give a series of events showing when a bootstrap status is changing. Thanks to the existing state/driver separation in the DirMgr design we don't need much new logic: each download state needs to expose (internally) how far along it is in its download, which the bootstrap code passes to the DirMgr if it has changed. I believe that in the long run, we'll probably want to expose more (or different) information here, and we'll want to process it differently. With that in mind, I've made the API for `DirBootstrapStatus` deliberately narrow, so that we can change its of its internal later on without breaking code that depends on it. (The information exposed by this commit is not yet summarized in `arti-client`.) Part of #96.
* | | Merge branch 'eta/292-2' into 'main'eta2022-01-191-20/+95
|\ \ \ | | | | | | | | | | | | | | | | arti-bench: add concurrency, write benchmark results out to JSON See merge request tpo/core/arti!243
| * | | arti-bench: add concurrency, write benchmark results out to JSONeta2022-01-181-20/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now conduct benchmark tests with multiple concurrent streams (by default; this is configurable by passing `-p` to `arti-bench`). Currently, these results just get "flattened" for the purposes of statistical analysis (as in, results_raw contains the results of each connection's timing summary, across all benchmark runs). This might be something we wish to change in future. The stats summary now also records "best" and "worst" values for each metric, to give a rough idea of the range of values encountered. Additionally, we now support writing the benchmark results out to a JSON file. A future commit may integrate this with CI, so that we have benchmark results for every commit as a build artefact. (some documentation was also fixed) part of arti#292
* | | | maint/changed_crates.sh: Add a missing space.Nick Mathewson2022-01-191-1/+1
| | | | | | | | | | | | | | | | found by shellcheck.
* | | | Merge branch 'coverage_script'Nick Mathewson2022-01-191-2/+99
|\ \ \ \
| * | | | coverage.sh: Treat no-tests-selected as an error.Nick Mathewson2022-01-191-3/+2
| | | | |
| * | | | Rewrite coverage.sh to use with_coverage.Nick Mathewson2022-01-131-2/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `coverage.sh` is now a more elaborate script to before, thanks to moving from tarpaulin to grcov via `with_coverage.sh`. This commit also adds support for the minimalistic chutney+curl-based integration test from our gitlab-ci.yml file. See the message from "coverage.sh -h" for information about running these tests. Closes #248.
* | | | | Merge branch 'correct-cache' into 'main'eta2022-01-191-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Put our cache files in the right place. Closes #297 See merge request tpo/core/arti!244
| * | | | | Put our cache files in the right place.Nick Mathewson2022-01-181-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | This resolves a copy-and-paste error where we were putting everything in our state directory. Closes #297.
* | | | | Add a needs-more-testers note to Android and iOS guides.Nick Mathewson2022-01-182-0/+8
| | | | |
* | | | | Merge branch 'ios-doc' into 'main'Nick Mathewson2022-01-182-6/+165
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | add iOS documentation Closes #132 See merge request tpo/core/arti!242
| * | | | add iOS documentationTrinity Pointard2022-01-172-6/+165
|/ / / /
* | | | Merge branch 'eta/292-1' into 'main'eta2022-01-143-30/+180
|\ \ \ \ | |/ / / |/| | | | | | | | | | | arti-bench: add support for multiple samples & averaging See merge request tpo/core/arti!240
| * | | arti-bench: add support for multiple samples & averagingeta2022-01-143-30/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We now do multiple samples (configurable; default 3) per type of `arti-bench` benchmark run, and take a mean and median average of all data collected, in order to hopefully be a bit more resilient to random outliers / variation. This uses some `futures::stream::Stream` hacks, which might result in more connections being made than required (and might impact the TTFB metrics somewhat, at least for downloading). Results now get collected into a `BenchmarkResults` struct per type of benchmark, which will be in turn placed into a `BenchmarkSummary` in a later commit; this will also add the ability to serialize the latter struct out to disk, for future reference. part of arti#292
* | | | Merge branch 'bootstrap_reporting_api' into 'main'Nick Mathewson2022-01-135-1/+224
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Implement the basics of a bootstrap-status API. See merge request tpo/core/arti!237
| * | | Implement the basics of a bootstrap-status API.Nick Mathewson2022-01-135-1/+224
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The purpose of a this API is to tell the user how far along Arti is in getting bootstrapped, and if it's stuck, what it's stuck on. This API doesn't yet expose any useful information: by the time it's observable to a client, it's always "100% bootstrapped." But I'm putting it in a MR now so that we can review the basic idea, and to avoid conflicts with later work on tickets like #293 and #278. This is part of #96.
* | | | Merge branch 'refactor/arti-bench' into 'main'eta2022-01-131-117/+159
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | refactor `arti-bench` See merge request tpo/core/arti!208
| * | | | refactor `arti-bench`daniel.eades2022-01-131-117/+159
|/ / / /
* | | | Merge branch 'channel-arc-rework-5' into 'main'eta2022-01-136-96/+119
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | chanmgr: get rid of Arc around Channel See merge request tpo/core/arti!236
| * | | | chanmgr: get rid of Arc around ChannelIan Jackson2022-01-136-96/+119
| |/ / /
* | | | Merge branch 'sendme_versions' into 'main'eta2022-01-132-31/+80
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | Fix a bug in requiring sendme authentication, and document some future work Closes #53 and #294 See merge request tpo/core/arti!238
| * | | Describe when we will need SendmeAcceptMinVersionNick Mathewson2022-01-121-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | (spoiler: not until we have a relay implementation) Closes #53.