| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | | |
Closes #226.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Put most non-universally-needed functionality behind features
Closes #125
See merge request tpo/core/arti!129
|
| | | | |
| | | |
| | | |
| | | | |
Part of #125
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
(We keep routerdescs in the schema, since we don't want _that_ to
fragment.)
Part of #125.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clients never need these.
Part of #125.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Nothing in arti currently uses this document type. Eventually it
will be useful for relays and for bridge clients.
I've left the "SHA1 digest of a router descriptor" type available
unconditinoally, however, since it does get used in a few places.
Part of #125.
|
| | | | |
| | | |
| | | |
| | | | |
(Found while looking for unused features for #125)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't currently need a couple of the key manipulation features
that we have, since we aren't yet doing relays or onion service
clients.
Part of #125
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Use tor_rtcompat::test_with_all_runtimes!() in place of #[tokio::test]
Closes #222
See merge request tpo/core/arti!130
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Closes #222.
|
| |/ / / /
| | | |
| | | |
| | | | |
Thanks to eta's refactoring, these tests no longer need to be async.
|
| | |/ /
|/| |
| | |
| | |
| | |
| | | |
This is a security fix for a panic.
Closes #236
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
The clippy code for warning about these on nightly CI can't tell the
difference between cfg(test) and no cfg(test).
|
| | | |
| | |
| | |
| | | |
The `circid` field in `ClientCirc` is now testing-only.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This field isn't used in modern Tor, and has never been used in
Arti. If tor!489 is merged, then it will no longer contain a useful
value in future consensuses. We shouldn't store it, or else
somebody else will get the smart idea of using it for something.
This commit breaks API compatibility for tor-netdoc with the
`build_docs` feature enabled. I haven't entered that into the
semver_status.md file, since we already have a pending tor-netdoc
API breaker in !129.
|
| |\ \
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| | |
testing was done on a different target than building, so everything was
compiled twice (actually, it's the same target, but rust doesn't realize
that)
makes build+test about 20% faster
|
| | | |
|
| |\ \
| |/
|/|
| |
| | |
Completely overhaul the tor-proto circuit reactor
See merge request tpo/core/arti!126
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, the reactor would use an `UnboundedSender` to send things to
the `RawCellStream`, in order that the reactor wouldn't block if you
failed to read from the latter. This is bad, though, since it means
people can just run us out of memory by sending lots of things.
To fix this, we make the new `StreamReader` type (which does the reading
parts from `RawCellStream`) keep track of the stream's receive window
and issue SENDMEs once *it* has consumed enough data to require it, thus
meaning that we shouldn't get sent enough data to fill the channel
between reactor and `StreamReader` (and, if we do, that's someone trying
to flood us, and we abort the circuit).
As hinted to above, the `RawCellStream` was removed and its reading
functionalities replaced by `StreamReader`; its writing functionalities
are handled by `StreamTarget` anyway, so we just give out one of those
for the write end. This now means we don't need any mutexes!
note: this commit introduces a known issue, arti#230
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather like e8e9699c3c239d6c30f9ad414f15d3bad6ec03fd ("Get rid of
tor-proto's ChannelImpl, and use the reactor more instead"), this
admittedly rather large commit refactors the way circuits in `tor-proto`
work, centralising all of the logic in one large nonblocking reactor
which other things send messages into and out of, instead of having a
bunch of `-Impl` types that are protected by mutexes.
Congestion control becomes a lot simpler with this refactor, since the
reactor can manage both stream- and circuit-level congestion control
unilaterally without having to share this information with consumers,
meaning we can get rid of some locks.
The way streams work also changes, in order to facilitate better
handling of backpressure / fairness between streams: each stream now has
a set of channels to send and receive messages over, instead of sending
relay cells directly onto the channel (now, the reactor pulls messages
off each stream in each map, and tries to avoid doing so if it won't be
able to forward them yet).
Additionally, a lot of "close this circuit / stream" messages aren't
required any more, since that state is simply indicated by one end of a
channel going away. This should make cleanup a lot less brittle.
Getting all of this to work involved writing a fair deal of intricate
nonblocking code in Reactor::run_once that tries very hard to be mindful
of making backpressure work correctly (and congestion control); the old
code could get away with having tasks .await on things, but the new
reactor can't really do this (as it'd lock the reactor up), so has to do
everything in a nonblocking manner.
|
| |\
| |
| |
| |
| | |
Fix typos
See merge request tpo/core/arti!127
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
| |
It requires tracing-subscriber 0.2, which is a lower version than we
want, and which causes trouble with our minimal-versions CI test.
There is a pending issue to fix this; we can reinstate tracing-test
once it is merged: https://github.com/dbrgn/tracing-test/pull/11
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
It seems like a good time to do this, before we add a zillion other
arguments to begin_stream.
|
| |
|
|
|
|
|
| |
* Make it crate-visible only.
* Make it idempotent
* Have it be an internal error if it's called at the wrong time.
* Simplify the return logic.
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Previously we didn't check for the space.
Closes #225.
|
| | | |
|
| |/ |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| | |
It formats them in a nice little json object, which it writes to
stdout.
Part of arti#172
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Format checks seem to be the fastest operation, and tests are the
slowest. Reordering Git hook tasks from swiftest to slowest should
provide quicker automated feedback when committing and/or pushing.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
> Check the Read Me file for Cargo Husky crate for details
>
> https://github.com/rhysd/cargo-husky#readme
These changes allow for local `git commit` and `git push` related hooks to more
closely match remote CI/CD operations. Most notably the `cargo clippy...` lint
command from ".gitlab-ci.yml" file now may guard against committing/pushing
code that would otherwise cause CI/CD pipeline failures.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Tune the 'profile.release' options for a smaller compile size.
See merge request tpo/core/arti!124
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
By enabling link-time optimization, setting 'opt-level=s', and
setting compilation-units=1, we can get a much smaller download
size, which is one of our objectives.
Making these changes reduces the binary size for me (on x86_64) by about
42%. If you also run "strip --strip-debug" on the resulting binary,
the resulting size is 55% smaller than the original binary size.
These effects persist if you compress the binary. Supposing that we
use xz compression, these options make save 32% of compressed binary
size. If we also "strip --strip-debug" before compressing, the compressed
binary saves 43% from the original binary size.
With all of these options applied, on x86_64 linux with xz
compression, we're at a nice 1.5 MiB download. If we statically link
to openssl and sqlite, we're still only at a 2.8 MiB download.
There is a build time cost to these changes: for me, it comes to
a 10%-25% build time increase.
This is part of arti#172.
|
| | | | |
|
| |/ / |
|
| | |
| |
| |
| |
| | |
These test our download schedules, resetting to the original state,
and storing downloaded objects.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
In rust-nightly CI, forbid debugging prints.
Closes #218
See merge request tpo/core/arti!123
|