| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| |
| | |
ci-check-msrv: Add check for MSRV
See merge request tpo/core/arti!3405
|
| | |
| |
| |
| | |
Checks if each crate has rust-version property in Cargo.toml.
|
| | | |
|
| | |
| |
| |
| |
| | |
This downgrades the container image for the 'cargo-miri' job, and
updates some adjacent comments.
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
| |
This also updates some needs statements that existed to order jobs that
did not actually have a dependency on each other.
The idea here is to run everything with as much parallelism as possible,
and if that parallelism causes problems, we should ideally solve it by
adding more runner capacity, or taking a closer look at what the actual
problem is.
|
| |
|
|
|
| |
I am interested in enabling opentelemetry in chutney tests to enable
easier debugging of failures that pop up in CI.
|
| |\
| |
| |
| |
| | |
Bump MSRV from 1.85.1 to 1.86
See merge request tpo/core/arti!3382
|
| | | |
|
| |/
|
|
| |
Fixes: #2219
|
| |
|
|
|
|
|
| |
3 seems like a good number to start with, we can tune it later if
needed.
Fixes: #2207
|
| |
|
|
|
| |
Hopefully these are now sufficiently small to fit into the default 1h
timeout.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This job is still expensive and a bottleneck. "cargo test" is the
slowest part, and experimentally doesn't seem to generate artifacts used
in the other steps nor reuse artifacts genrated in other steps.
Splitting it out to its own job exposes more parallelism.
"cargo test" is also more prone to flakiness than the other commands,
which just build code without running it. Isolating the flakiness is
helpful when we need to retry. (Though of course ultimately we want to
eliminate such flakinesss)
|
| | |
|
| |
|
|
|
|
|
| |
There's probably not much benefit to building these on rust-latest in
addition to rust-recent; incompatibilities with rust-latest should be
found in rust-latest-dev-test. Let's save the template complexity
and CI cost.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
rust-recent (and rust-latest, for runs on the main branch) is one of our
longer jobs, particularly in the 'build' CI stage, making it a
bottleneck for starting the 'test' stage.
The job does quite a bit of work, some of it with very little overlap
due to use of different cargo build profiles.
This commit splits the job roughly by build-profile, so that the work
done with each build profile can proceed in parallel.
|
| |
|
|
|
| |
This is mostly for consistency with the following "cargo build"
invocation to build arti, but is unlikely to make any real difference.
|
| |
|
|
|
|
|
|
|
|
|
| |
Right now building arti-bench take a fair while in the rust-recent and
rust-latest jobs.
Using the quicktest profile instead of release makes any actual
benchmark results less meaningful, but as far as I can tell this build
artifact is mostly just to test that it works at all rather than to
collect meaningful performance data. e.g. we're currently not
controlling at all for runner capacity or load.
|
| |
|
|
|
|
|
|
| |
This is to mitigate https://gitlab.torproject.org/tpo/tpa/team/-/issues/42317
I added the 2h timeout (overriding the default 1h) for all jobs that
were cited as examples on that issue, and a couple others that looked
likely to be time-consuming.
|
| | |
|
| |
|
|
|
| |
* This reverts commit 8da606966e5213cada270fb64f896f69bab041dd.
* This reverts commit a3ac2080956b9295000bd7011c34111a6d5ce5a7.
|
| |
|
|
| |
See https://gitlab.torproject.org/tpo/tpa/team/-/issues/42283
|
| |\
| |
| |
| |
| | |
ci: Move "check" jobs into "build" stage.
See merge request tpo/core/arti!3318
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This moves everything that was in the "check" stage into the "build"
stage, so that beginning to build the artifacts isn't blocked by running
the checks. This should result in CI taking less time overall.
There is some concern that making CI more efficient by increasing
parallelism could increase load on runners and cause more problems than
it solves, so that's something we should look out for in evaluating this
change.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
ci: Move maint-check-changelog into maint-checks.
See merge request tpo/core/arti!3316
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I hope that this will reduce the load on our CI and speed up these
checks. This should also cause this check to run earlier in the process,
which is nice for finding issues earlier.
It's unclear to me if there was a specific reason this was a separate
job. As far as I can tell from the commit message and discussion in
!2126, there does not seem to be a specific reason.
|
| | |
| |
| |
| |
| |
| |
| | |
We are currently having some issues with these jobs on the OSUOSL runners,
using TPA runners should allow us to debug this more effectively.
See: tpo/tpa/team#42283
|
| |/
|
|
|
|
|
| |
We are currently having some issues with this job on the OSUOSL runners,
using TPA runners should allow us to debug this more effectively.
See: https://gitlab.torproject.org/tpo/tpa/team/-/issues/42283
|
| |
|
|
|
|
|
|
| |
Now that rust nightly has merged doc_auto_cfg into doc_cfg,
and completed https://github.com/rust-lang/rust/pull/138907,
it is no longer necessary.
Closes #1514.
|
| | |
|
| |
|
|
|
| |
No functional differences as far as I can tell, but keeps with gitlab's
recommendations for consistency and to avoid potential footguns.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This is mostly to allow putting the pip3 dependencies each on their own
line without escaping newlines, but also more idiomatic in general.
|
| |
|
|
|
| |
I think now that the linter versions are pinned (!2683), we don't want
to allow these to fail anymore.
|
| |
|
|
| |
Closes #2107
|
| |
|
|
|
|
|
| |
This is taking up a lot of space in our CI longs, and hasn't
actually helped us out in the past.
Possible solution for #2155
|
| |
|
|
|
|
|
| |
There are significant changes in the output from cargo-sort 2.0.2,
so let's pause at 2.0.1 until we decide on our next step.
Temporary solution for #2156.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mitigates #2154
The determinism inside CI is of limited usefulness since a CI seed
generally won't perfectly replicate the behavior when debugging locally.
Arguably it's a feature that when there's some flakiness it does
replicate inside of CI, but it leads to some confusion about blame (e.g.
as in #2154 where an unrelated MR probably perturbed the PRNG to trigger
some pre-existing flakiness), and means that we can't just rerun the job
if we get really unlucky. i.e. even if we set a lower success threshold,
a sufficiently unlucky MR can still fail and keep failing as long as it
runs with the same seed.
|
| |\
| |
| |
| |
| | |
maint: Add a check for case-insensitive files
See merge request tpo/core/arti!3207
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Filenames within the tree that exists in multiple versions only
differing by their case cause problems on case-insensitive filesystems.
This commit introduces a simple check that lists all files indexes by
git and searches for duplicate lines while ignoring case during
comparison.
See !3166, #2144
|
| |\ \
| | |
| | |
| | |
| | | |
Use quicktest build for integration testing
See merge request tpo/core/arti!3157
|
| | | |
| | |
| | |
| | | |
build arti
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Increase artifact expiration times to 1 day minimum
Closes #2064
See merge request tpo/core/arti!3098
|
| | | | |
|