diff options
Diffstat (limited to 'crates')
47 files changed, 204 insertions, 6 deletions
diff --git a/crates/arti-bench/src/main.rs b/crates/arti-bench/src/main.rs index bbffa9996..09d09d54f 100644 --- a/crates/arti-bench/src/main.rs +++ b/crates/arti-bench/src/main.rs @@ -4,6 +4,8 @@ //! a `chutney` network of Tor nodes, benchmarking the upload and download bandwidth while doing so. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -34,6 +36,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> // This file uses `unwrap()` a fair deal, but this is fine in test/bench code // because it's OK if tests and benchmarks simply crash if things go wrong. diff --git a/crates/arti-client/examples/advanced_isolation.rs b/crates/arti-client/examples/advanced_isolation.rs index a386a38c8..adc6708d1 100644 --- a/crates/arti-client/examples/advanced_isolation.rs +++ b/crates/arti-client/examples/advanced_isolation.rs @@ -1,3 +1,12 @@ +// @@ begin test lint list maintained by maint/add_warning @@ +#![allow(clippy::bool_assert_comparison)] +#![allow(clippy::clone_on_copy)] +#![allow(clippy::dbg_macro)] +#![allow(clippy::print_stderr)] +#![allow(clippy::print_stdout)] +#![allow(clippy::unwrap_used)] +//! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + // This example showcase how to use the trait IsolationHelper to build complexe isolation rules. // For most usages, using a combination of TorClient::isolated_client and IsolationToken should // be enough. diff --git a/crates/arti-client/examples/hook-tcp.rs b/crates/arti-client/examples/hook-tcp.rs index d37f18a13..c3420c7e9 100644 --- a/crates/arti-client/examples/hook-tcp.rs +++ b/crates/arti-client/examples/hook-tcp.rs @@ -1,3 +1,12 @@ +// @@ begin test lint list maintained by maint/add_warning @@ +#![allow(clippy::bool_assert_comparison)] +#![allow(clippy::clone_on_copy)] +#![allow(clippy::dbg_macro)] +#![allow(clippy::print_stderr)] +#![allow(clippy::print_stdout)] +#![allow(clippy::unwrap_used)] +//! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + //! This example showcases using a custom [`TcpProvider`] to do custom actions before Arti initiates //! TCP connections, and after the connections are closed. //! diff --git a/crates/arti-client/examples/lazy-init.rs b/crates/arti-client/examples/lazy-init.rs index 050fa2b4c..337e41b5e 100644 --- a/crates/arti-client/examples/lazy-init.rs +++ b/crates/arti-client/examples/lazy-init.rs @@ -1,3 +1,12 @@ +// @@ begin test lint list maintained by maint/add_warning @@ +#![allow(clippy::bool_assert_comparison)] +#![allow(clippy::clone_on_copy)] +#![allow(clippy::dbg_macro)] +#![allow(clippy::print_stderr)] +#![allow(clippy::print_stdout)] +#![allow(clippy::unwrap_used)] +//! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use anyhow::Result; use arti_client::{TorClient, TorClientConfig}; use tokio_crate as tokio; diff --git a/crates/arti-client/examples/readme.rs b/crates/arti-client/examples/readme.rs index 5f67fd6a3..8e48088ab 100644 --- a/crates/arti-client/examples/readme.rs +++ b/crates/arti-client/examples/readme.rs @@ -1,3 +1,12 @@ +// @@ begin test lint list maintained by maint/add_warning @@ +#![allow(clippy::bool_assert_comparison)] +#![allow(clippy::clone_on_copy)] +#![allow(clippy::dbg_macro)] +#![allow(clippy::print_stderr)] +#![allow(clippy::print_stdout)] +#![allow(clippy::unwrap_used)] +//! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use anyhow::Result; use arti_client::{TorClient, TorClientConfig}; use tokio_crate as tokio; diff --git a/crates/arti-client/src/lib.rs b/crates/arti-client/src/lib.rs index 4b7216a4d..1639acda8 100644 --- a/crates/arti-client/src/lib.rs +++ b/crates/arti-client/src/lib.rs @@ -222,6 +222,8 @@ //! all experimental features from other arti crates. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -252,6 +254,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod address; diff --git a/crates/arti-config/src/lib.rs b/crates/arti-config/src/lib.rs index 9ff4d74ba..9953f4d89 100644 --- a/crates/arti-config/src/lib.rs +++ b/crates/arti-config/src/lib.rs @@ -8,6 +8,8 @@ //! This empty crate is published as a tombstone. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -38,6 +40,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> // EOF diff --git a/crates/arti-hyper/examples/hyper.rs b/crates/arti-hyper/examples/hyper.rs index 25bac0b73..c8c27eb47 100644 --- a/crates/arti-hyper/examples/hyper.rs +++ b/crates/arti-hyper/examples/hyper.rs @@ -1,3 +1,12 @@ +// @@ begin test lint list maintained by maint/add_warning @@ +#![allow(clippy::bool_assert_comparison)] +#![allow(clippy::clone_on_copy)] +#![allow(clippy::dbg_macro)] +#![allow(clippy::print_stderr)] +#![allow(clippy::print_stdout)] +#![allow(clippy::unwrap_used)] +//! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use arti_hyper::*; use anyhow::Result; diff --git a/crates/arti-hyper/src/lib.rs b/crates/arti-hyper/src/lib.rs index 9ad81e7d5..14d582ab5 100644 --- a/crates/arti-hyper/src/lib.rs +++ b/crates/arti-hyper/src/lib.rs @@ -9,6 +9,8 @@ //! [`hyper.rs`]: <https://gitlab.torproject.org/tpo/core/arti/-/blob/main/crates/arti-hyper/examples/hyper.rs> // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -39,6 +41,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use std::future::Future; diff --git a/crates/arti-testing/src/main.rs b/crates/arti-testing/src/main.rs index 10919523a..efbaff425 100644 --- a/crates/arti-testing/src/main.rs +++ b/crates/arti-testing/src/main.rs @@ -49,6 +49,8 @@ //! - Actually implement those tests. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -79,6 +81,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> #![allow(clippy::print_stderr)] // Allowed in this crate only. diff --git a/crates/arti/src/lib.rs b/crates/arti/src/lib.rs index e1a9d5f82..bad092eb6 100644 --- a/crates/arti/src/lib.rs +++ b/crates/arti/src/lib.rs @@ -110,6 +110,8 @@ //! similar to `arti`. The API should not be considered stable. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -140,6 +142,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> // Overrides specific to this crate: diff --git a/crates/arti/src/main.rs b/crates/arti/src/main.rs index 5b35c6f1a..cc4f99d68 100644 --- a/crates/arti/src/main.rs +++ b/crates/arti/src/main.rs @@ -3,6 +3,8 @@ //! See the [crate-level documentation](::arti). // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -33,6 +35,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> fn main() { diff --git a/crates/caret/src/lib.rs b/crates/caret/src/lib.rs index 759d7ecd7..845d22298 100644 --- a/crates/caret/src/lib.rs +++ b/crates/caret/src/lib.rs @@ -38,6 +38,8 @@ //! use. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -68,6 +70,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> /// Declare an integer type with some named elements. diff --git a/crates/fs-mistrust/src/lib.rs b/crates/fs-mistrust/src/lib.rs index ad49a7e31..b6b4cbcae 100644 --- a/crates/fs-mistrust/src/lib.rs +++ b/crates/fs-mistrust/src/lib.rs @@ -244,6 +244,8 @@ // - Cache information across runs. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -274,6 +276,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod dir; diff --git a/crates/retry-error/src/lib.rs b/crates/retry-error/src/lib.rs index 8786b7bdf..de63edf6b 100644 --- a/crates/retry-error/src/lib.rs +++ b/crates/retry-error/src/lib.rs @@ -35,6 +35,8 @@ //! ``` // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -65,6 +67,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use std::error::Error; diff --git a/crates/safelog/src/lib.rs b/crates/safelog/src/lib.rs index 666f83d2c..27e67c22c 100644 --- a/crates/safelog/src/lib.rs +++ b/crates/safelog/src/lib.rs @@ -69,6 +69,8 @@ //! information isn't _ever_ suitable for logging, we omit it entirely. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -99,6 +101,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> // TODO: Try making it not Deref and having expose+expose_mut instead; how bad is it? diff --git a/crates/tor-basic-utils/src/futures.rs b/crates/tor-basic-utils/src/futures.rs index 5cce62724..ce7682dc9 100644 --- a/crates/tor-basic-utils/src/futures.rs +++ b/crates/tor-basic-utils/src/futures.rs @@ -413,9 +413,16 @@ where } #[cfg(test)] -#[allow(clippy::unwrap_used)] // why is this not the default in tests -#[allow(clippy::print_stderr)] mod test { + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] + #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] + #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use futures::channel::mpsc; use futures::future::poll_fn; diff --git a/crates/tor-basic-utils/src/lib.rs b/crates/tor-basic-utils/src/lib.rs index 03aacf7c3..43435e79f 100644 --- a/crates/tor-basic-utils/src/lib.rs +++ b/crates/tor-basic-utils/src/lib.rs @@ -10,6 +10,8 @@ //! are to be found in other `tor-*` crates. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -40,6 +42,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use std::fmt; diff --git a/crates/tor-bytes/src/lib.rs b/crates/tor-bytes/src/lib.rs index 450e613dd..f1ef24d8a 100644 --- a/crates/tor-bytes/src/lib.rs +++ b/crates/tor-bytes/src/lib.rs @@ -48,6 +48,8 @@ //! handle your type, and other types that are built around it. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -78,6 +80,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod err; diff --git a/crates/tor-cell/src/lib.rs b/crates/tor-cell/src/lib.rs index cbec7b71c..225a86ec1 100644 --- a/crates/tor-cell/src/lib.rs +++ b/crates/tor-cell/src/lib.rs @@ -58,6 +58,8 @@ //! to future-proof arti against these proposals if they are adopted. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -88,6 +90,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod chancell; diff --git a/crates/tor-cert/src/lib.rs b/crates/tor-cert/src/lib.rs index afe45211b..397c0be25 100644 --- a/crates/tor-cert/src/lib.rs +++ b/crates/tor-cert/src/lib.rs @@ -51,6 +51,8 @@ //! ``` // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -81,6 +83,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod err; diff --git a/crates/tor-chanmgr/src/lib.rs b/crates/tor-chanmgr/src/lib.rs index 5a95816d0..7e4c72618 100644 --- a/crates/tor-chanmgr/src/lib.rs +++ b/crates/tor-chanmgr/src/lib.rs @@ -16,6 +16,8 @@ //! and return existing channels when they already exist. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -46,6 +48,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod builder; diff --git a/crates/tor-chanmgr/src/mgr/map.rs b/crates/tor-chanmgr/src/mgr/map.rs index 22bdd4c25..c16739be8 100644 --- a/crates/tor-chanmgr/src/mgr/map.rs +++ b/crates/tor-chanmgr/src/mgr/map.rs @@ -365,7 +365,15 @@ fn update_padding_parameters_from_netdir( #[cfg(test)] mod test { + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] + #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use std::result::Result as StdResult; use std::sync::Arc; diff --git a/crates/tor-checkable/src/lib.rs b/crates/tor-checkable/src/lib.rs index 707b3d6fa..b9d5fa2aa 100644 --- a/crates/tor-checkable/src/lib.rs +++ b/crates/tor-checkable/src/lib.rs @@ -43,6 +43,8 @@ //! sets the flag wrong, they will skip doing the checks. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -73,6 +75,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use std::time; diff --git a/crates/tor-circmgr/src/lib.rs b/crates/tor-circmgr/src/lib.rs index 6abe56ac1..7489dd3a2 100644 --- a/crates/tor-circmgr/src/lib.rs +++ b/crates/tor-circmgr/src/lib.rs @@ -21,6 +21,8 @@ //! is wrong too. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -51,6 +53,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use tor_basic_utils::retry::RetryDelay; diff --git a/crates/tor-circmgr/src/path/dirpath.rs b/crates/tor-circmgr/src/path/dirpath.rs index 4bd9d0219..01e1caef8 100644 --- a/crates/tor-circmgr/src/path/dirpath.rs +++ b/crates/tor-circmgr/src/path/dirpath.rs @@ -80,8 +80,15 @@ impl DirPathBuilder { #[cfg(test)] mod test { - #![allow(clippy::unwrap_used)] + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] + #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use crate::path::assert_same_path_when_owned; use crate::test::OptDummyGuardMgr; diff --git a/crates/tor-config/src/lib.rs b/crates/tor-config/src/lib.rs index e9cc191cd..12111e8c8 100644 --- a/crates/tor-config/src/lib.rs +++ b/crates/tor-config/src/lib.rs @@ -57,6 +57,8 @@ //! [#285]: https://gitlab.torproject.org/tpo/core/arti/-/issues/285 // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -87,6 +89,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod cmdline; diff --git a/crates/tor-config/src/path.rs b/crates/tor-config/src/path.rs index 85be232d9..b1f151d5b 100644 --- a/crates/tor-config/src/path.rs +++ b/crates/tor-config/src/path.rs @@ -308,6 +308,15 @@ mod test { #[cfg(test)] mod test_serde { + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] + #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] + #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use std::ffi::OsString; use std::fmt::Debug; diff --git a/crates/tor-consdiff/src/lib.rs b/crates/tor-consdiff/src/lib.rs index 33f20c6d7..1d4f7b47c 100644 --- a/crates/tor-consdiff/src/lib.rs +++ b/crates/tor-consdiff/src/lib.rs @@ -17,6 +17,8 @@ //! these diffs as well as consume them. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -47,6 +49,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use std::fmt::{Display, Formatter}; diff --git a/crates/tor-dirclient/src/lib.rs b/crates/tor-dirclient/src/lib.rs index caf680969..868891b7b 100644 --- a/crates/tor-dirclient/src/lib.rs +++ b/crates/tor-dirclient/src/lib.rs @@ -25,6 +25,8 @@ //! `routerdesc` -- Add support for downloading router descriptors. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -55,6 +57,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod err; diff --git a/crates/tor-dirmgr/src/lib.rs b/crates/tor-dirmgr/src/lib.rs index f2150348b..a44ced0f7 100644 --- a/crates/tor-dirmgr/src/lib.rs +++ b/crates/tor-dirmgr/src/lib.rs @@ -25,6 +25,8 @@ //! router descriptors. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -55,6 +57,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod authority; diff --git a/crates/tor-error/src/lib.rs b/crates/tor-error/src/lib.rs index 597a7733a..4bffd0edd 100644 --- a/crates/tor-error/src/lib.rs +++ b/crates/tor-error/src/lib.rs @@ -7,6 +7,8 @@ //! crates higher up the dependency stack. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -37,6 +39,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use derive_more::Display; diff --git a/crates/tor-events/src/lib.rs b/crates/tor-events/src/lib.rs index 402090738..c4c43702a 100644 --- a/crates/tor-events/src/lib.rs +++ b/crates/tor-events/src/lib.rs @@ -1,6 +1,8 @@ //! Tools for generating a stream of structured events, similar to C tor's `ControlPort`. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -31,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod events; diff --git a/crates/tor-guardmgr/src/fallback/set.rs b/crates/tor-guardmgr/src/fallback/set.rs index f991f2112..ffdce1574 100644 --- a/crates/tor-guardmgr/src/fallback/set.rs +++ b/crates/tor-guardmgr/src/fallback/set.rs @@ -229,7 +229,15 @@ impl FallbackState { #[cfg(test)] mod test { + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] + #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use crate::FirstHopId; use rand::Rng; diff --git a/crates/tor-guardmgr/src/lib.rs b/crates/tor-guardmgr/src/lib.rs index edbe5a66e..2bc3d3229 100644 --- a/crates/tor-guardmgr/src/lib.rs +++ b/crates/tor-guardmgr/src/lib.rs @@ -92,6 +92,8 @@ //! document. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -122,6 +124,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> // Glossary: diff --git a/crates/tor-linkspec/src/lib.rs b/crates/tor-linkspec/src/lib.rs index 0eb15fa75..249f5468d 100644 --- a/crates/tor-linkspec/src/lib.rs +++ b/crates/tor-linkspec/src/lib.rs @@ -37,6 +37,8 @@ //! TODO: Possibly the link specifiers and the `*Target` traits belong in different crates. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -67,6 +69,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod ls; diff --git a/crates/tor-llcrypto/src/lib.rs b/crates/tor-llcrypto/src/lib.rs index 48f976ab5..b31b1c67e 100644 --- a/crates/tor-llcrypto/src/lib.rs +++ b/crates/tor-llcrypto/src/lib.rs @@ -74,6 +74,8 @@ //! one is enabled. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -104,6 +106,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod cipher; diff --git a/crates/tor-netdir/src/lib.rs b/crates/tor-netdir/src/lib.rs index 1cc0be938..0e9acc72f 100644 --- a/crates/tor-netdir/src/lib.rs +++ b/crates/tor-netdir/src/lib.rs @@ -26,6 +26,8 @@ //! supported. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -56,6 +58,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod err; diff --git a/crates/tor-netdoc/src/lib.rs b/crates/tor-netdoc/src/lib.rs index 9592c66ff..933d496b2 100644 --- a/crates/tor-netdoc/src/lib.rs +++ b/crates/tor-netdoc/src/lib.rs @@ -51,6 +51,8 @@ //! TODO: this crate needs far more tests! // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -81,6 +83,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> #[macro_use] diff --git a/crates/tor-persist/src/lib.rs b/crates/tor-persist/src/lib.rs index d99a1b00b..7c84f63a3 100644 --- a/crates/tor-persist/src/lib.rs +++ b/crates/tor-persist/src/lib.rs @@ -9,6 +9,8 @@ //! interfaces of the [`StateMgr`] trait. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -39,6 +41,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> #[cfg(not(target_arch = "wasm32"))] diff --git a/crates/tor-proto/src/channel/padding.rs b/crates/tor-proto/src/channel/padding.rs index 8b1ec51e6..776b274bd 100644 --- a/crates/tor-proto/src/channel/padding.rs +++ b/crates/tor-proto/src/channel/padding.rs @@ -351,10 +351,16 @@ impl PreparedParameters { } #[cfg(test)] -#[allow(clippy::unwrap_used)] -#[allow(clippy::bool_assert_comparison)] -#[allow(clippy::print_stderr)] mod test { + // @@ begin test lint list maintained by maint/add_warning @@ + #![allow(clippy::bool_assert_comparison)] + #![allow(clippy::clone_on_copy)] + #![allow(clippy::dbg_macro)] + #![allow(clippy::print_stderr)] + #![allow(clippy::print_stdout)] + #![allow(clippy::unwrap_used)] + //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> + use super::*; use futures::future::ready; use futures::select_biased; diff --git a/crates/tor-proto/src/lib.rs b/crates/tor-proto/src/lib.rs index 5573e3adb..144759646 100644 --- a/crates/tor-proto/src/lib.rs +++ b/crates/tor-proto/src/lib.rs @@ -83,6 +83,8 @@ //! find a good way to eliminate every lock that we have. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -113,6 +115,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> pub mod channel; diff --git a/crates/tor-protover/src/lib.rs b/crates/tor-protover/src/lib.rs index 74da5767c..8ade39947 100644 --- a/crates/tor-protover/src/lib.rs +++ b/crates/tor-protover/src/lib.rs @@ -34,6 +34,8 @@ //! protocols against the required list in the consensus.) // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -64,6 +66,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> #![allow(non_upper_case_globals)] diff --git a/crates/tor-rtcompat/src/lib.rs b/crates/tor-rtcompat/src/lib.rs index 2fb3cc4fb..38ca31f47 100644 --- a/crates/tor-rtcompat/src/lib.rs +++ b/crates/tor-rtcompat/src/lib.rs @@ -139,6 +139,8 @@ //! (See the [`tor-rtmock`] crate for examples.) // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -169,6 +171,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> #[cfg(all( diff --git a/crates/tor-rtmock/src/lib.rs b/crates/tor-rtmock/src/lib.rs index cbaddfe48..eacf81cbe 100644 --- a/crates/tor-rtmock/src/lib.rs +++ b/crates/tor-rtmock/src/lib.rs @@ -108,6 +108,8 @@ //! (TODO: Add an example for the timeout case.) // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -138,6 +140,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> extern crate core; diff --git a/crates/tor-socksproto/src/lib.rs b/crates/tor-socksproto/src/lib.rs index 6ed6a2e49..89ec8a977 100644 --- a/crates/tor-socksproto/src/lib.rs +++ b/crates/tor-socksproto/src/lib.rs @@ -57,6 +57,8 @@ //! feature, so that others can use this crate more safely. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -87,6 +89,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> mod err; diff --git a/crates/tor-units/src/lib.rs b/crates/tor-units/src/lib.rs index f83142439..de6174c62 100644 --- a/crates/tor-units/src/lib.rs +++ b/crates/tor-units/src/lib.rs @@ -16,6 +16,8 @@ //! * a SendMeVersion which can be compared only. // @@ begin lint list maintained by maint/add_warning @@ +#![cfg_attr(not(ci_arti_stable), allow(renamed_and_removed_lints))] +#![cfg_attr(not(ci_arti_nightly), allow(unknown_lints))] #![deny(missing_docs)] #![warn(noop_method_call)] #![deny(unreachable_pub)] @@ -46,6 +48,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> use derive_more::{Add, Display, Div, From, FromStr, Mul}; |