diff options
195 files changed, 240 insertions, 22 deletions
diff --git a/crates/arti-bench/src/main.rs b/crates/arti-bench/src/main.rs index 14de197d5..5def76a74 100644 --- a/crates/arti-bench/src/main.rs +++ b/crates/arti-bench/src/main.rs @@ -36,6 +36,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -760,6 +761,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::StreamIsolationTracker; diff --git a/crates/arti-client/examples/advanced_isolation.rs b/crates/arti-client/examples/advanced_isolation.rs index a5e9092c9..871ebdbec 100644 --- a/crates/arti-client/examples/advanced_isolation.rs +++ b/crates/arti-client/examples/advanced_isolation.rs @@ -6,6 +6,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> // This example showcase how to use the trait IsolationHelper to build complex isolation rules. @@ -192,11 +193,7 @@ async fn main() -> Result<()> { async fn send_request(stream: &mut arti_client::DataStream, host: &str) -> Result<()> { stream .write_all( - format!( - "GET / HTTP/1.1\r\nHost: {}\r\nConnection: close\r\n\r\n", - host - ) - .as_bytes(), + format!("GET / HTTP/1.1\r\nHost: {host}\r\nConnection: close\r\n\r\n").as_bytes(), ) .await?; stream.flush().await?; diff --git a/crates/arti-client/examples/hook-tcp.rs b/crates/arti-client/examples/hook-tcp.rs index 3ace25aa4..ee4d66c19 100644 --- a/crates/arti-client/examples/hook-tcp.rs +++ b/crates/arti-client/examples/hook-tcp.rs @@ -6,6 +6,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> //! This example showcases using a custom [`TcpProvider`] to do custom actions before Arti initiates @@ -132,7 +133,7 @@ where { // Use the underlying TCP provider implementation to do the connection, and // return our wrapper around it once done. - println!("tcp connect to {}", addr); + println!("tcp connect to {addr}"); self.inner .connect(addr) .map(move |r| { @@ -157,7 +158,7 @@ where { // Use the underlying TCP provider implementation to make the listener, and // return our wrapper around it once done. - println!("tcp listen on {}", addr); + println!("tcp listen on {addr}"); self.inner .listen(addr) .map(|l| l.map(|listener| CustomTcpListener { inner: listener })) @@ -300,7 +301,7 @@ where .accept() .inspect(|r| { if let Ok((_, addr)) = r { - println!("accepted connection from {}", addr) + println!("accepted connection from {addr}"); } }) .map(|r| { diff --git a/crates/arti-client/examples/lazy-init.rs b/crates/arti-client/examples/lazy-init.rs index 0646d81c1..7292797b3 100644 --- a/crates/arti-client/examples/lazy-init.rs +++ b/crates/arti-client/examples/lazy-init.rs @@ -6,6 +6,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use anyhow::Result; diff --git a/crates/arti-client/examples/readme.rs b/crates/arti-client/examples/readme.rs index 5c1bbb21d..d85c847bc 100644 --- a/crates/arti-client/examples/readme.rs +++ b/crates/arti-client/examples/readme.rs @@ -6,6 +6,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use anyhow::Result; diff --git a/crates/arti-client/src/address.rs b/crates/arti-client/src/address.rs index 3d95c9a45..095a54250 100644 --- a/crates/arti-client/src/address.rs +++ b/crates/arti-client/src/address.rs @@ -387,6 +387,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/arti-client/src/client.rs b/crates/arti-client/src/client.rs index 265d810da..f685edcb5 100644 --- a/crates/arti-client/src/client.rs +++ b/crates/arti-client/src/client.rs @@ -1142,6 +1142,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/arti-client/src/config.rs b/crates/arti-client/src/config.rs index d0a2bbe59..fd5b0b69b 100644 --- a/crates/arti-client/src/config.rs +++ b/crates/arti-client/src/config.rs @@ -557,6 +557,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/arti-client/src/err.rs b/crates/arti-client/src/err.rs index 6aecd91c7..d3541a7ef 100644 --- a/crates/arti-client/src/err.rs +++ b/crates/arti-client/src/err.rs @@ -343,6 +343,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/arti-client/src/lib.rs b/crates/arti-client/src/lib.rs index 2abe447ce..6b9359e03 100644 --- a/crates/arti-client/src/lib.rs +++ b/crates/arti-client/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/arti-config/src/lib.rs b/crates/arti-config/src/lib.rs index 7d25ac972..8ec4b871b 100644 --- a/crates/arti-config/src/lib.rs +++ b/crates/arti-config/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/arti-hyper/examples/hyper.rs b/crates/arti-hyper/examples/hyper.rs index ad9939ad8..94bf12e75 100644 --- a/crates/arti-hyper/examples/hyper.rs +++ b/crates/arti-hyper/examples/hyper.rs @@ -6,8 +6,11 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> +#![allow(clippy::uninlined_format_args)] + use arti_hyper::*; use anyhow::Result; diff --git a/crates/arti-hyper/src/lib.rs b/crates/arti-hyper/src/lib.rs index 53d9f467c..a01cb0107 100644 --- a/crates/arti-hyper/src/lib.rs +++ b/crates/arti-hyper/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -292,6 +293,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/arti-testing/src/main.rs b/crates/arti-testing/src/main.rs index 89d58d77b..0ebac1d46 100644 --- a/crates/arti-testing/src/main.rs +++ b/crates/arti-testing/src/main.rs @@ -81,6 +81,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/arti/src/cfg.rs b/crates/arti/src/cfg.rs index 15a7c7fe5..6f8afcd5e 100644 --- a/crates/arti/src/cfg.rs +++ b/crates/arti/src/cfg.rs @@ -236,6 +236,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> // Saves adding many individual #[cfg], or a sub-module diff --git a/crates/arti/src/lib.rs b/crates/arti/src/lib.rs index 8ee6e3256..45e20d999 100644 --- a/crates/arti/src/lib.rs +++ b/crates/arti/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/arti/src/main.rs b/crates/arti/src/main.rs index 91e5d12e9..acf68e521 100644 --- a/crates/arti/src/main.rs +++ b/crates/arti/src/main.rs @@ -35,6 +35,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/caret/src/lib.rs b/crates/caret/src/lib.rs index be9dc1c8d..46a637bb2 100644 --- a/crates/caret/src/lib.rs +++ b/crates/caret/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/caret/tests/example_int.rs b/crates/caret/tests/example_int.rs index 51f052b60..fc93673b8 100644 --- a/crates/caret/tests/example_int.rs +++ b/crates/caret/tests/example_int.rs @@ -43,8 +43,8 @@ fn test_str_ops() { let other: Demo = 33.into(); assert_eq!(other.to_str(), None); - assert_eq!(format!("Hello {}", other), "Hello 33"); - assert_eq!(format!("Hello {:?}", other), "Hello Demo(33)"); + assert_eq!(format!("Hello {other}"), "Hello 33"); + assert_eq!(format!("Hello {other:?}"), "Hello Demo(33)"); assert_eq!(Demo::from_name("A"), Some(Demo::A)); assert_eq!(Demo::from_name("Apricot"), None); diff --git a/crates/fs-mistrust/src/anon_home.rs b/crates/fs-mistrust/src/anon_home.rs index 80dda83d1..6163946d2 100644 --- a/crates/fs-mistrust/src/anon_home.rs +++ b/crates/fs-mistrust/src/anon_home.rs @@ -116,6 +116,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/fs-mistrust/src/dir.rs b/crates/fs-mistrust/src/dir.rs index cc6b5046a..8fa2452b9 100644 --- a/crates/fs-mistrust/src/dir.rs +++ b/crates/fs-mistrust/src/dir.rs @@ -256,6 +256,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::testing::Dir; diff --git a/crates/fs-mistrust/src/disable.rs b/crates/fs-mistrust/src/disable.rs index a963914a6..7c8ecc56a 100644 --- a/crates/fs-mistrust/src/disable.rs +++ b/crates/fs-mistrust/src/disable.rs @@ -102,6 +102,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/fs-mistrust/src/err.rs b/crates/fs-mistrust/src/err.rs index 0f0af6012..1667e004f 100644 --- a/crates/fs-mistrust/src/err.rs +++ b/crates/fs-mistrust/src/err.rs @@ -280,6 +280,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/fs-mistrust/src/lib.rs b/crates/fs-mistrust/src/lib.rs index e83226234..e9b5f9642 100644 --- a/crates/fs-mistrust/src/lib.rs +++ b/crates/fs-mistrust/src/lib.rs @@ -39,6 +39,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -586,6 +587,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use testing::{mistrust_build, Dir, MistrustOp}; diff --git a/crates/fs-mistrust/src/user.rs b/crates/fs-mistrust/src/user.rs index e318e9e04..ec00ca660 100644 --- a/crates/fs-mistrust/src/user.rs +++ b/crates/fs-mistrust/src/user.rs @@ -267,6 +267,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use users::mock::{Group, MockUsers, User}; diff --git a/crates/fs-mistrust/src/user/serde_support.rs b/crates/fs-mistrust/src/user/serde_support.rs index f0e21db4a..6b5738bb0 100644 --- a/crates/fs-mistrust/src/user/serde_support.rs +++ b/crates/fs-mistrust/src/user/serde_support.rs @@ -152,6 +152,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/fs-mistrust/src/walk.rs b/crates/fs-mistrust/src/walk.rs index 4785378be..0a8197977 100644 --- a/crates/fs-mistrust/src/walk.rs +++ b/crates/fs-mistrust/src/walk.rs @@ -395,6 +395,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::testing; diff --git a/crates/retry-error/src/lib.rs b/crates/retry-error/src/lib.rs index 5ffb7099a..f22be36de 100644 --- a/crates/retry-error/src/lib.rs +++ b/crates/retry-error/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -234,6 +235,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/safelog/src/flags.rs b/crates/safelog/src/flags.rs index 608f3bfc1..ad7892168 100644 --- a/crates/safelog/src/flags.rs +++ b/crates/safelog/src/flags.rs @@ -188,6 +188,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; // We use "serial_test" to make sure that our tests here run one at a time, diff --git a/crates/safelog/src/impls.rs b/crates/safelog/src/impls.rs index b9905c2c4..9af1bd6a1 100644 --- a/crates/safelog/src/impls.rs +++ b/crates/safelog/src/impls.rs @@ -57,6 +57,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use std::{ diff --git a/crates/safelog/src/lib.rs b/crates/safelog/src/lib.rs index 1b8c8691b..db5e3eff4 100644 --- a/crates/safelog/src/lib.rs +++ b/crates/safelog/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -314,6 +315,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use serial_test::serial; diff --git a/crates/tor-basic-utils/src/futures.rs b/crates/tor-basic-utils/src/futures.rs index 242a995e1..ce1baaecd 100644 --- a/crates/tor-basic-utils/src/futures.rs +++ b/crates/tor-basic-utils/src/futures.rs @@ -539,6 +539,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-basic-utils/src/iter.rs b/crates/tor-basic-utils/src/iter.rs index 49ad1b41f..2d8872fce 100644 --- a/crates/tor-basic-utils/src/iter.rs +++ b/crates/tor-basic-utils/src/iter.rs @@ -163,6 +163,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-basic-utils/src/lib.rs b/crates/tor-basic-utils/src/lib.rs index 868683a8c..e735106b3 100644 --- a/crates/tor-basic-utils/src/lib.rs +++ b/crates/tor-basic-utils/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-basic-utils/src/n_key_set.rs b/crates/tor-basic-utils/src/n_key_set.rs index 815a8c925..eb3cb6676 100644 --- a/crates/tor-basic-utils/src/n_key_set.rs +++ b/crates/tor-basic-utils/src/n_key_set.rs @@ -593,6 +593,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> n_key_set! { diff --git a/crates/tor-basic-utils/src/retry.rs b/crates/tor-basic-utils/src/retry.rs index 3877038a2..659a0b3db 100644 --- a/crates/tor-basic-utils/src/retry.rs +++ b/crates/tor-basic-utils/src/retry.rs @@ -126,6 +126,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::test_rng::testing_rng; diff --git a/crates/tor-basic-utils/src/test_rng.rs b/crates/tor-basic-utils/src/test_rng.rs index 86873c894..5d9b3bfb6 100644 --- a/crates/tor-basic-utils/src/test_rng.rs +++ b/crates/tor-basic-utils/src/test_rng.rs @@ -238,6 +238,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use std::env::VarError; diff --git a/crates/tor-bytes/src/lib.rs b/crates/tor-bytes/src/lib.rs index 32ca8249d..51d116ec3 100644 --- a/crates/tor-bytes/src/lib.rs +++ b/crates/tor-bytes/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -175,6 +176,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-bytes/src/secretbuf.rs b/crates/tor-bytes/src/secretbuf.rs index 88dbc5065..da215a205 100644 --- a/crates/tor-bytes/src/secretbuf.rs +++ b/crates/tor-bytes/src/secretbuf.rs @@ -108,6 +108,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-cell/src/chancell/msg.rs b/crates/tor-cell/src/chancell/msg.rs index 158fc26ab..4bfcd3f2a 100644 --- a/crates/tor-cell/src/chancell/msg.rs +++ b/crates/tor-cell/src/chancell/msg.rs @@ -1280,6 +1280,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/tor-cell/src/lib.rs b/crates/tor-cell/src/lib.rs index 00f131ab4..00a0dea54 100644 --- a/crates/tor-cell/src/lib.rs +++ b/crates/tor-cell/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-cell/tests/test_chancell.rs b/crates/tor-cell/tests/test_chancell.rs index b1d034e8d..ab4763d4d 100644 --- a/crates/tor-cell/tests/test_chancell.rs +++ b/crates/tor-cell/tests/test_chancell.rs @@ -1,6 +1,7 @@ // Test for encoding/decoding channel cells. // // Reminder: you can think of a cell as an message plus a circuitid. +#![allow(clippy::uninlined_format_args)] use tor_cell::chancell::{codec, msg, ChanCell, ChanCmd, CircId}; use tor_cell::Error; diff --git a/crates/tor-cell/tests/test_relaycell.rs b/crates/tor-cell/tests/test_relaycell.rs index 15f13b7fb..52c4fa72a 100644 --- a/crates/tor-cell/tests/test_relaycell.rs +++ b/crates/tor-cell/tests/test_relaycell.rs @@ -1,4 +1,5 @@ // Tests for encoding/decoding relay messages into relay cell bodies. +#![allow(clippy::uninlined_format_args)] use tor_bytes::Error; use tor_cell::relaycell::{msg, msg::RelayMsg, RelayCell, RelayCmd, StreamId}; diff --git a/crates/tor-cell/tests/testvec_chanmsg.rs b/crates/tor-cell/tests/testvec_chanmsg.rs index d2794e704..cc25d634d 100644 --- a/crates/tor-cell/tests/testvec_chanmsg.rs +++ b/crates/tor-cell/tests/testvec_chanmsg.rs @@ -1,3 +1,5 @@ +#![allow(clippy::uninlined_format_args)] + use tor_bytes::Error as BytesError; /// Example channel messages to encode and decode. /// diff --git a/crates/tor-cell/tests/testvec_relaymsg.rs b/crates/tor-cell/tests/testvec_relaymsg.rs index c4695cea3..fdcf0b809 100644 --- a/crates/tor-cell/tests/testvec_relaymsg.rs +++ b/crates/tor-cell/tests/testvec_relaymsg.rs @@ -1,3 +1,5 @@ +#![allow(clippy::uninlined_format_args)] + use tor_basic_utils::test_rng::testing_rng; use tor_bytes::Error as BytesError; /// Example relay messages to encode and decode. diff --git a/crates/tor-cert/src/encode.rs b/crates/tor-cert/src/encode.rs index 54125ea96..8badab2e0 100644 --- a/crates/tor-cert/src/encode.rs +++ b/crates/tor-cert/src/encode.rs @@ -167,6 +167,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::CertifiedKey; diff --git a/crates/tor-cert/src/lib.rs b/crates/tor-cert/src/lib.rs index 6e553922b..97a52f71a 100644 --- a/crates/tor-cert/src/lib.rs +++ b/crates/tor-cert/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -534,6 +535,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-chanmgr/src/builder.rs b/crates/tor-chanmgr/src/builder.rs index a98debf3e..454dc43ef 100644 --- a/crates/tor-chanmgr/src/builder.rs +++ b/crates/tor-chanmgr/src/builder.rs @@ -232,6 +232,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::{ diff --git a/crates/tor-chanmgr/src/config.rs b/crates/tor-chanmgr/src/config.rs index 018f3df16..6e1c194b4 100644 --- a/crates/tor-chanmgr/src/config.rs +++ b/crates/tor-chanmgr/src/config.rs @@ -42,6 +42,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-chanmgr/src/event.rs b/crates/tor-chanmgr/src/event.rs index 90f1b7986..3daba3199 100644 --- a/crates/tor-chanmgr/src/event.rs +++ b/crates/tor-chanmgr/src/event.rs @@ -405,6 +405,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-chanmgr/src/lib.rs b/crates/tor-chanmgr/src/lib.rs index 8a639ce53..83fda4775 100644 --- a/crates/tor-chanmgr/src/lib.rs +++ b/crates/tor-chanmgr/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-chanmgr/src/mgr.rs b/crates/tor-chanmgr/src/mgr.rs index e0dd27b68..17c12188a 100644 --- a/crates/tor-chanmgr/src/mgr.rs +++ b/crates/tor-chanmgr/src/mgr.rs @@ -526,6 +526,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::Error; diff --git a/crates/tor-chanmgr/src/mgr/state.rs b/crates/tor-chanmgr/src/mgr/state.rs index 380fdc3c1..16791e698 100644 --- a/crates/tor-chanmgr/src/mgr/state.rs +++ b/crates/tor-chanmgr/src/mgr/state.rs @@ -534,6 +534,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-chanmgr/src/mgr/state/padding_test.rs b/crates/tor-chanmgr/src/mgr/state/padding_test.rs index 010d9023a..5052ff0df 100644 --- a/crates/tor-chanmgr/src/mgr/state/padding_test.rs +++ b/crates/tor-chanmgr/src/mgr/state/padding_test.rs @@ -8,6 +8,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-chanmgr/src/transport/default.rs b/crates/tor-chanmgr/src/transport/default.rs index 7d3e9c610..df7b3b9f2 100644 --- a/crates/tor-chanmgr/src/transport/default.rs +++ b/crates/tor-chanmgr/src/transport/default.rs @@ -139,6 +139,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use std::str::FromStr; diff --git a/crates/tor-chanmgr/src/transport/proxied.rs b/crates/tor-chanmgr/src/transport/proxied.rs index 2a28ddd0d..60dc286a8 100644 --- a/crates/tor-chanmgr/src/transport/proxied.rs +++ b/crates/tor-chanmgr/src/transport/proxied.rs @@ -432,6 +432,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #[allow(unused_imports)] use super::*; diff --git a/crates/tor-checkable/src/lib.rs b/crates/tor-checkable/src/lib.rs index f78a1f695..5e7960b93 100644 --- a/crates/tor-checkable/src/lib.rs +++ b/crates/tor-checkable/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-checkable/src/signed.rs b/crates/tor-checkable/src/signed.rs index e52626f51..f1e0b4cfe 100644 --- a/crates/tor-checkable/src/signed.rs +++ b/crates/tor-checkable/src/signed.rs @@ -45,6 +45,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::SelfSigned; diff --git a/crates/tor-checkable/src/timed.rs b/crates/tor-checkable/src/timed.rs index 2b12b0596..4e7543004 100644 --- a/crates/tor-checkable/src/timed.rs +++ b/crates/tor-checkable/src/timed.rs @@ -141,6 +141,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::{TimeValidityError, Timebound}; diff --git a/crates/tor-circmgr/src/build.rs b/crates/tor-circmgr/src/build.rs index 6397a9c43..ae51ef63b 100644 --- a/crates/tor-circmgr/src/build.rs +++ b/crates/tor-circmgr/src/build.rs @@ -510,6 +510,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::timeouts::TimeoutEstimator; diff --git a/crates/tor-circmgr/src/config.rs b/crates/tor-circmgr/src/config.rs index 8c7670694..654bdb79d 100644 --- a/crates/tor-circmgr/src/config.rs +++ b/crates/tor-circmgr/src/config.rs @@ -302,6 +302,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-circmgr/src/lib.rs b/crates/tor-circmgr/src/lib.rs index 8a9aa1f74..3ead1a86f 100644 --- a/crates/tor-circmgr/src/lib.rs +++ b/crates/tor-circmgr/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -620,7 +621,10 @@ impl<R: Runtime> CircMgr<R> { let dirinfo = netdir.into(); let mgr = Arc::clone(&self.mgr); debug!("Launching a circuit to test build times."); - let _ = mgr.launch_by_usage(&usage, dirinfo)?; + let receiver = mgr.launch_by_usage(&usage, dirinfo)?; + // We don't actually care when this circuit is done, + // so it's okay to drop the Receiver without awaiting it. + drop(receiver); } Ok(()) @@ -859,6 +863,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-circmgr/src/mgr.rs b/crates/tor-circmgr/src/mgr.rs index c5f22b890..465aed33c 100644 --- a/crates/tor-circmgr/src/mgr.rs +++ b/crates/tor-circmgr/src/mgr.rs @@ -1516,6 +1516,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::isolation::test::{assert_isoleq, IsolationTokenEq}; diff --git a/crates/tor-circmgr/src/mgr/streams.rs b/crates/tor-circmgr/src/mgr/streams.rs index 380bba86a..b3caff4e7 100644 --- a/crates/tor-circmgr/src/mgr/streams.rs +++ b/crates/tor-circmgr/src/mgr/streams.rs @@ -124,6 +124,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use futures_await_test::async_test; diff --git a/crates/tor-circmgr/src/path/dirpath.rs b/crates/tor-circmgr/src/path/dirpath.rs index 7611366d9..41bd716cd 100644 --- a/crates/tor-circmgr/src/path/dirpath.rs +++ b/crates/tor-circmgr/src/path/dirpath.rs @@ -86,6 +86,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-circmgr/src/path/exitpath.rs b/crates/tor-circmgr/src/path/exitpath.rs index 28b9e41e8..45ed67304 100644 --- a/crates/tor-circmgr/src/path/exitpath.rs +++ b/crates/tor-circmgr/src/path/exitpath.rs @@ -299,6 +299,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::path::{assert_same_path_when_owned, MaybeOwnedRelay, OwnedPath, TorPathInner}; diff --git a/crates/tor-circmgr/src/preemptive.rs b/crates/tor-circmgr/src/preemptive.rs index 26716a403..0a1d441d9 100644 --- a/crates/tor-circmgr/src/preemptive.rs +++ b/crates/tor-circmgr/src/preemptive.rs @@ -94,6 +94,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use crate::{PreemptiveCircuitConfig, PreemptiveCircuitPredictor, TargetCircUsage, TargetPort}; use std::time::{Duration, Instant}; diff --git a/crates/tor-circmgr/src/timeouts.rs b/crates/tor-circmgr/src/timeouts.rs index c7b6e7afa..9ec5a93f2 100644 --- a/crates/tor-circmgr/src/timeouts.rs +++ b/crates/tor-circmgr/src/timeouts.rs @@ -176,6 +176,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-circmgr/src/timeouts/estimator.rs b/crates/tor-circmgr/src/timeouts/estimator.rs index b96b6c433..92ff1f541 100644 --- a/crates/tor-circmgr/src/timeouts/estimator.rs +++ b/crates/tor-circmgr/src/timeouts/estimator.rs @@ -160,6 +160,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_persist::StateMgr; diff --git a/crates/tor-circmgr/src/timeouts/pareto.rs b/crates/tor-circmgr/src/timeouts/pareto.rs index 2f5492f93..64b9f04bf 100644 --- a/crates/tor-circmgr/src/timeouts/pareto.rs +++ b/crates/tor-circmgr/src/timeouts/pareto.rs @@ -653,6 +653,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::timeouts::TimeoutEstimator; diff --git a/crates/tor-config/src/cmdline.rs b/crates/tor-config/src/cmdline.rs index c28ac3fbb..46ceed52e 100644 --- a/crates/tor-config/src/cmdline.rs +++ b/crates/tor-config/src/cmdline.rs @@ -151,6 +151,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/tor-config/src/err.rs b/crates/tor-config/src/err.rs index e315c93d6..80d244cb1 100644 --- a/crates/tor-config/src/err.rs +++ b/crates/tor-config/src/err.rs @@ -174,6 +174,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-config/src/lib.rs b/crates/tor-config/src/lib.rs index 4d9d5cc65..708fdbffa 100644 --- a/crates/tor-config/src/lib.rs +++ b/crates/tor-config/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -429,6 +430,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate as tor_config; diff --git a/crates/tor-config/src/list_builder.rs b/crates/tor-config/src/list_builder.rs index 6c34f4d91..19a3c45b1 100644 --- a/crates/tor-config/src/list_builder.rs +++ b/crates/tor-config/src/list_builder.rs @@ -745,6 +745,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use derive_builder::Builder; diff --git a/crates/tor-config/src/load.rs b/crates/tor-config/src/load.rs index 6920dcc07..9228458c7 100644 --- a/crates/tor-config/src/load.rs +++ b/crates/tor-config/src/load.rs @@ -661,6 +661,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::*; diff --git a/crates/tor-config/src/misc.rs b/crates/tor-config/src/misc.rs index a60ed9941..2464e96de 100644 --- a/crates/tor-config/src/misc.rs +++ b/crates/tor-config/src/misc.rs @@ -393,6 +393,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-config/src/mut_cfg.rs b/crates/tor-config/src/mut_cfg.rs index 25e8a66d0..b21a809ac 100644 --- a/crates/tor-config/src/mut_cfg.rs +++ b/crates/tor-config/src/mut_cfg.rs @@ -71,6 +71,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-config/src/path.rs b/crates/tor-config/src/path.rs index 3bb8afa78..230ddcd8b 100644 --- a/crates/tor-config/src/path.rs +++ b/crates/tor-config/src/path.rs @@ -346,6 +346,7 @@ mod test_serde { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-config/src/sources.rs b/crates/tor-config/src/sources.rs index e867a0707..63e3db9cd 100644 --- a/crates/tor-config/src/sources.rs +++ b/crates/tor-config/src/sources.rs @@ -408,6 +408,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-congestion/src/lib.rs b/crates/tor-congestion/src/lib.rs index 20fbcd8af..78da1e6ae 100644 --- a/crates/tor-congestion/src/lib.rs +++ b/crates/tor-congestion/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-congestion/src/rtt.rs b/crates/tor-congestion/src/rtt.rs index 2a2344cff..6c10c0ab7 100644 --- a/crates/tor-congestion/src/rtt.rs +++ b/crates/tor-congestion/src/rtt.rs @@ -258,6 +258,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use crate::rtt::RoundtripTimeEstimator; use std::sync::atomic::{AtomicBool, Ordering}; diff --git a/crates/tor-consdiff/src/lib.rs b/crates/tor-consdiff/src/lib.rs index 61e6e74ed..c51b7c417 100644 --- a/crates/tor-consdiff/src/lib.rs +++ b/crates/tor-consdiff/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -563,6 +564,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-dirclient/src/lib.rs b/crates/tor-dirclient/src/lib.rs index b80c8b9dd..2f45c1bb7 100644 --- a/crates/tor-dirclient/src/lib.rs +++ b/crates/tor-dirclient/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -461,6 +462,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_rtmock::{io::stream_pair, time::MockSleepProvider}; diff --git a/crates/tor-dirclient/src/request.rs b/crates/tor-dirclient/src/request.rs index 17bdcfaaf..b735a6471 100644 --- a/crates/tor-dirclient/src/request.rs +++ b/crates/tor-dirclient/src/request.rs @@ -519,6 +519,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-dirclient/src/response.rs b/crates/tor-dirclient/src/response.rs index c26540fd0..60d20e99e 100644 --- a/crates/tor-dirclient/src/response.rs +++ b/crates/tor-dirclient/src/response.rs @@ -177,6 +177,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-dirclient/src/util.rs b/crates/tor-dirclient/src/util.rs index 8d5e0ff57..dfd37561f 100644 --- a/crates/tor-dirclient/src/util.rs +++ b/crates/tor-dirclient/src/util.rs @@ -30,6 +30,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-dirmgr/src/authority.rs b/crates/tor-dirmgr/src/authority.rs index ffbdaa3dd..a78596480 100644 --- a/crates/tor-dirmgr/src/authority.rs +++ b/crates/tor-dirmgr/src/authority.rs @@ -85,6 +85,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_netdoc::doc::authcert::AuthCertKeyIds; diff --git a/crates/tor-dirmgr/src/bootstrap.rs b/crates/tor-dirmgr/src/bootstrap.rs index aead5825c..eee5fb254 100644 --- a/crates/tor-dirmgr/src/bootstrap.rs +++ b/crates/tor-dirmgr/src/bootstrap.rs @@ -682,6 +682,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::storage::DynStore; diff --git a/crates/tor-dirmgr/src/bridgedesc.rs b/crates/tor-dirmgr/src/bridgedesc.rs index ff23c0098..109630c01 100644 --- a/crates/tor-dirmgr/src/bridgedesc.rs +++ b/crates/tor-dirmgr/src/bridgedesc.rs @@ -1530,7 +1530,9 @@ impl State { if let Ok(ahead) = wallclock.duration_since(now_wall) { now_mono + ahead } else if let Ok(behind) = now_wall.duration_since(wallclock) { - now_mono - behind + now_mono + .checked_sub(behind) + .expect("time subtraction underflow") } else { panic!("times should be totally ordered!") } diff --git a/crates/tor-dirmgr/src/bridgedesc/bdtest.rs b/crates/tor-dirmgr/src/bridgedesc/bdtest.rs index 218bd228a..798592c68 100644 --- a/crates/tor-dirmgr/src/bridgedesc/bdtest.rs +++ b/crates/tor-dirmgr/src/bridgedesc/bdtest.rs @@ -8,6 +8,7 @@ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(unused_variables)] // XXX diff --git a/crates/tor-dirmgr/src/config.rs b/crates/tor-dirmgr/src/config.rs index 46c9bc196..849d8912a 100644 --- a/crates/tor-dirmgr/src/config.rs +++ b/crates/tor-dirmgr/src/config.rs @@ -332,6 +332,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(clippy::unnecessary_wraps)] use super::*; diff --git a/crates/tor-dirmgr/src/docid.rs b/crates/tor-dirmgr/src/docid.rs index e8ebd2e76..196c81e4b 100644 --- a/crates/tor-dirmgr/src/docid.rs +++ b/crates/tor-dirmgr/src/docid.rs @@ -291,6 +291,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-dirmgr/src/docmeta.rs b/crates/tor-dirmgr/src/docmeta.rs index d2ca79f04..e24911988 100644 --- a/crates/tor-dirmgr/src/docmeta.rs +++ b/crates/tor-dirmgr/src/docmeta.rs @@ -140,6 +140,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-dirmgr/src/event.rs b/crates/tor-dirmgr/src/event.rs index 0c31b3dbb..e218d6cd8 100644 --- a/crates/tor-dirmgr/src/event.rs +++ b/crates/tor-dirmgr/src/event.rs @@ -824,6 +824,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use std::time::Duration; diff --git a/crates/tor-dirmgr/src/lib.rs b/crates/tor-dirmgr/src/lib.rs index 5e699edeb..093f8c9f2 100644 --- a/crates/tor-dirmgr/src/lib.rs +++ b/crates/tor-dirmgr/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -1122,6 +1123,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::docmeta::{AuthCertMeta, ConsensusMeta}; diff --git a/crates/tor-dirmgr/src/retry.rs b/crates/tor-dirmgr/src/retry.rs index d53f6b106..512120060 100644 --- a/crates/tor-dirmgr/src/retry.rs +++ b/crates/tor-dirmgr/src/retry.rs @@ -121,6 +121,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-dirmgr/src/shared_ref.rs b/crates/tor-dirmgr/src/shared_ref.rs index 4d62e8513..7b8c4514f 100644 --- a/crates/tor-dirmgr/src/shared_ref.rs +++ b/crates/tor-dirmgr/src/shared_ref.rs @@ -102,6 +102,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/tor-dirmgr/src/state.rs b/crates/tor-dirmgr/src/state.rs index a284de366..01eae3166 100644 --- a/crates/tor-dirmgr/src/state.rs +++ b/crates/tor-dirmgr/src/state.rs @@ -1243,6 +1243,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-dirmgr/src/storage.rs b/crates/tor-dirmgr/src/storage.rs index 3f064fe7f..712c20ace 100644 --- a/crates/tor-dirmgr/src/storage.rs +++ b/crates/tor-dirmgr/src/storage.rs @@ -352,6 +352,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tempfile::tempdir; diff --git a/crates/tor-error/src/internal.rs b/crates/tor-error/src/internal.rs index 5babd4071..0cdd790f0 100644 --- a/crates/tor-error/src/internal.rs +++ b/crates/tor-error/src/internal.rs @@ -255,6 +255,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-error/src/lib.rs b/crates/tor-error/src/lib.rs index bb2bcb4c9..9532a911f 100644 --- a/crates/tor-error/src/lib.rs +++ b/crates/tor-error/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-error/src/report.rs b/crates/tor-error/src/report.rs index 53abcd0ac..1fdb10fcb 100644 --- a/crates/tor-error/src/report.rs +++ b/crates/tor-error/src/report.rs @@ -101,6 +101,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use std::io; diff --git a/crates/tor-error/src/retriable.rs b/crates/tor-error/src/retriable.rs index b87ef3237..3f0f6efa8 100644 --- a/crates/tor-error/src/retriable.rs +++ b/crates/tor-error/src/retriable.rs @@ -251,6 +251,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-events/src/lib.rs b/crates/tor-events/src/lib.rs index 440b99f00..6e23dd109 100644 --- a/crates/tor-events/src/lib.rs +++ b/crates/tor-events/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -293,6 +294,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use crate::{ broadcast, event_has_subscribers, EventReactor, StreamExt, TorEvent, TorEventKind, diff --git a/crates/tor-guardmgr/src/bridge/config.rs b/crates/tor-guardmgr/src/bridge/config.rs index 6455cb771..7eb813f5e 100644 --- a/crates/tor-guardmgr/src/bridge/config.rs +++ b/crates/tor-guardmgr/src/bridge/config.rs @@ -611,6 +611,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-guardmgr/src/config.rs b/crates/tor-guardmgr/src/config.rs index 607df87f2..5f726084b 100644 --- a/crates/tor-guardmgr/src/config.rs +++ b/crates/tor-guardmgr/src/config.rs @@ -41,6 +41,7 @@ pub(crate) mod testing { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-guardmgr/src/dirstatus.rs b/crates/tor-guardmgr/src/dirstatus.rs index 40f3f4fd1..6add1a7ec 100644 --- a/crates/tor-guardmgr/src/dirstatus.rs +++ b/crates/tor-guardmgr/src/dirstatus.rs @@ -72,6 +72,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-guardmgr/src/fallback/set.rs b/crates/tor-guardmgr/src/fallback/set.rs index 2435ccf1d..59773f433 100644 --- a/crates/tor-guardmgr/src/fallback/set.rs +++ b/crates/tor-guardmgr/src/fallback/set.rs @@ -238,6 +238,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-guardmgr/src/filter.rs b/crates/tor-guardmgr/src/filter.rs index 8cbb152fd..44ee17f50 100644 --- a/crates/tor-guardmgr/src/filter.rs +++ b/crates/tor-guardmgr/src/filter.rs @@ -162,6 +162,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-guardmgr/src/guard.rs b/crates/tor-guardmgr/src/guard.rs index 3f62fecfc..6b7e83cc5 100644 --- a/crates/tor-guardmgr/src/guard.rs +++ b/crates/tor-guardmgr/src/guard.rs @@ -948,6 +948,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::ids::FirstHopId; diff --git a/crates/tor-guardmgr/src/lib.rs b/crates/tor-guardmgr/src/lib.rs index 23da6563e..1a241bfff 100644 --- a/crates/tor-guardmgr/src/lib.rs +++ b/crates/tor-guardmgr/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -1831,6 +1832,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_linkspec::{HasAddrs, HasRelayIds}; diff --git a/crates/tor-guardmgr/src/sample.rs b/crates/tor-guardmgr/src/sample.rs index 41668e874..fdf3c765d 100644 --- a/crates/tor-guardmgr/src/sample.rs +++ b/crates/tor-guardmgr/src/sample.rs @@ -814,7 +814,9 @@ impl GuardSet { // _rather_ use are either down, or have had their circuit // attempts pending for too long. - let cutoff = now - params.np_connect_timeout; + let cutoff = now + .checked_sub(params.np_connect_timeout) + .expect("Can't subtract connect timeout from now."); for (src, guard) in self.preference_order() { if guard.guard_id() == guard_id { @@ -1025,6 +1027,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use tor_linkspec::{HasRelayIds, RelayIdType}; use tor_netdir::{NetDir, Relay}; diff --git a/crates/tor-guardmgr/src/skew.rs b/crates/tor-guardmgr/src/skew.rs index 0f1db282b..188666a0a 100644 --- a/crates/tor-guardmgr/src/skew.rs +++ b/crates/tor-guardmgr/src/skew.rs @@ -238,6 +238,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use float_eq::assert_float_eq; diff --git a/crates/tor-guardmgr/src/util.rs b/crates/tor-guardmgr/src/util.rs index bb6780e6e..de1446c60 100644 --- a/crates/tor-guardmgr/src/util.rs +++ b/crates/tor-guardmgr/src/util.rs @@ -69,6 +69,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-hscrypto/src/lib.rs b/crates/tor-hscrypto/src/lib.rs index 72157c539..ba603f971 100644 --- a/crates/tor-hscrypto/src/lib.rs +++ b/crates/tor-hscrypto/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-hscrypto/src/ops.rs b/crates/tor-hscrypto/src/ops.rs index df4f5b876..2e8014b46 100644 --- a/crates/tor-hscrypto/src/ops.rs +++ b/crates/tor-hscrypto/src/ops.rs @@ -31,6 +31,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-hscrypto/src/pk.rs b/crates/tor-hscrypto/src/pk.rs index cddb1fb6b..161e07cdb 100644 --- a/crates/tor-hscrypto/src/pk.rs +++ b/crates/tor-hscrypto/src/pk.rs @@ -306,6 +306,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use hex_literal::hex; diff --git a/crates/tor-hscrypto/src/time.rs b/crates/tor-hscrypto/src/time.rs index 831de6263..5231bc98c 100644 --- a/crates/tor-hscrypto/src/time.rs +++ b/crates/tor-hscrypto/src/time.rs @@ -137,6 +137,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-linkspec/src/ids.rs b/crates/tor-linkspec/src/ids.rs index 57667693c..2ba748d65 100644 --- a/crates/tor-linkspec/src/ids.rs +++ b/crates/tor-linkspec/src/ids.rs @@ -360,6 +360,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use hex_literal::hex; use serde_test::{assert_tokens, Token}; diff --git a/crates/tor-linkspec/src/ids/by_id.rs b/crates/tor-linkspec/src/ids/by_id.rs index b37b7a87c..27974dabc 100644 --- a/crates/tor-linkspec/src/ids/by_id.rs +++ b/crates/tor-linkspec/src/ids/by_id.rs @@ -169,6 +169,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-linkspec/src/ids/set.rs b/crates/tor-linkspec/src/ids/set.rs index 2de5a477f..3cfc0ab6f 100644 --- a/crates/tor-linkspec/src/ids/set.rs +++ b/crates/tor-linkspec/src/ids/set.rs @@ -144,6 +144,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-linkspec/src/lib.rs b/crates/tor-linkspec/src/lib.rs index 9de492a63..4deb2acec 100644 --- a/crates/tor-linkspec/src/lib.rs +++ b/crates/tor-linkspec/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-linkspec/src/ls.rs b/crates/tor-linkspec/src/ls.rs index c5257db1a..2aea3ceac 100644 --- a/crates/tor-linkspec/src/ls.rs +++ b/crates/tor-linkspec/src/ls.rs @@ -173,6 +173,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-linkspec/src/owned.rs b/crates/tor-linkspec/src/owned.rs index aa6352006..a05d3a0e2 100644 --- a/crates/tor-linkspec/src/owned.rs +++ b/crates/tor-linkspec/src/owned.rs @@ -277,6 +277,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-linkspec/src/traits.rs b/crates/tor-linkspec/src/traits.rs index 6b81b82fd..7dbc32ead 100644 --- a/crates/tor-linkspec/src/traits.rs +++ b/crates/tor-linkspec/src/traits.rs @@ -305,6 +305,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-linkspec/src/transport.rs b/crates/tor-linkspec/src/transport.rs index 2d969a3f1..4b9642492 100644 --- a/crates/tor-linkspec/src/transport.rs +++ b/crates/tor-linkspec/src/transport.rs @@ -750,6 +750,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-llcrypto/src/lib.rs b/crates/tor-llcrypto/src/lib.rs index 076b8a034..4330bc7fd 100644 --- a/crates/tor-llcrypto/src/lib.rs +++ b/crates/tor-llcrypto/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-llcrypto/src/pk.rs b/crates/tor-llcrypto/src/pk.rs index 3e825f886..9d21a1312 100644 --- a/crates/tor-llcrypto/src/pk.rs +++ b/crates/tor-llcrypto/src/pk.rs @@ -75,6 +75,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #[test] fn validatable_ed_sig() { diff --git a/crates/tor-llcrypto/src/util/rand_compat.rs b/crates/tor-llcrypto/src/util/rand_compat.rs index 42ea81516..a2754abbe 100644 --- a/crates/tor-llcrypto/src/util/rand_compat.rs +++ b/crates/tor-llcrypto/src/util/rand_compat.rs @@ -133,6 +133,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_basic_utils::test_rng::testing_rng; diff --git a/crates/tor-llcrypto/tests/misc.rs b/crates/tor-llcrypto/tests/misc.rs index e1d86bb19..710b698fd 100644 --- a/crates/tor-llcrypto/tests/misc.rs +++ b/crates/tor-llcrypto/tests/misc.rs @@ -1,3 +1,5 @@ +#![allow(clippy::uninlined_format_args)] + use hex_literal::hex; use tor_llcrypto as ll; diff --git a/crates/tor-llcrypto/tests/testvec.rs b/crates/tor-llcrypto/tests/testvec.rs index 4fb1bc1d8..a8cff915c 100644 --- a/crates/tor-llcrypto/tests/testvec.rs +++ b/crates/tor-llcrypto/tests/testvec.rs @@ -1,3 +1,5 @@ +#![allow(clippy::uninlined_format_args)] + use base64ct::{Base64Unpadded, Encoding as _}; use cipher::{KeyIvInit, StreamCipher}; use digest::{self, Digest, ExtendableOutput}; diff --git a/crates/tor-netdir/src/lib.rs b/crates/tor-netdir/src/lib.rs index 6dfca9812..53f6b7277 100644 --- a/crates/tor-netdir/src/lib.rs +++ b/crates/tor-netdir/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -1206,7 +1207,7 @@ impl<'a> Relay<'a> { /// Return true if this relay and `other` seem to be the same relay. /// /// (Two relays are the same if they have the same identity.) - pub fn same_relay<'b>(&self, other: &Relay<'b>) -> bool { + pub fn same_relay(&self, other: &Relay<'_>) -> bool { self.id() == other.id() && self.rsa_id() == other.rsa_id() } /// Return true if this relay allows exiting to `port` on IPv4. @@ -1233,13 +1234,13 @@ impl<'a> Relay<'a> { /// have IPv4 addresses with the same `subnets_family_v4`-bit /// prefix, or if they have IPv6 addresses with the same /// `subnets_family_v6`-bit prefix. - pub fn in_same_subnet<'b>(&self, other: &Relay<'b>, subnet_config: &SubnetConfig) -> bool { + pub fn in_same_subnet(&self, other: &Relay<'_>, subnet_config: &SubnetConfig) -> bool { subnet_config.any_addrs_in_same_subnet(self, other) } /// Return true if both relays are in the same family. /// /// (Every relay is considered to be in the same family as itself.) - pub fn in_same_family<'b>(&self, other: &Relay<'b>) -> bool { + pub fn in_same_family(&self, other: &Relay<'_>) -> bool { if self.same_relay(other) { return true; } @@ -1370,6 +1371,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-netdir/src/params.rs b/crates/tor-netdir/src/params.rs index 0235f09a0..608f1e444 100644 --- a/crates/tor-netdir/src/params.rs +++ b/crates/tor-netdir/src/params.rs @@ -468,6 +468,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use std::string::String; diff --git a/crates/tor-netdir/src/testnet.rs b/crates/tor-netdir/src/testnet.rs index fdee7e71c..2377a35ff 100644 --- a/crates/tor-netdir/src/testnet.rs +++ b/crates/tor-netdir/src/testnet.rs @@ -240,6 +240,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/tor-netdir/src/weight.rs b/crates/tor-netdir/src/weight.rs index 252b4dcb7..be71dccdc 100644 --- a/crates/tor-netdir/src/weight.rs +++ b/crates/tor-netdir/src/weight.rs @@ -407,6 +407,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use netstatus::RelayWeight as RW; diff --git a/crates/tor-netdoc/src/build.rs b/crates/tor-netdoc/src/build.rs index 42b75712b..0d788e2f3 100644 --- a/crates/tor-netdoc/src/build.rs +++ b/crates/tor-netdoc/src/build.rs @@ -373,6 +373,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/doc/authcert.rs b/crates/tor-netdoc/src/doc/authcert.rs index 8a97772ec..bd4b3b0f2 100644 --- a/crates/tor-netdoc/src/doc/authcert.rs +++ b/crates/tor-netdoc/src/doc/authcert.rs @@ -422,6 +422,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::{Error, Pos}; diff --git a/crates/tor-netdoc/src/doc/authcert/build.rs b/crates/tor-netdoc/src/doc/authcert/build.rs index 4fcf2e07b..65c3017b6 100644 --- a/crates/tor-netdoc/src/doc/authcert/build.rs +++ b/crates/tor-netdoc/src/doc/authcert/build.rs @@ -138,6 +138,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/microdesc.rs b/crates/tor-netdoc/src/doc/microdesc.rs index 9a88ca532..b8e64dfea 100644 --- a/crates/tor-netdoc/src/doc/microdesc.rs +++ b/crates/tor-netdoc/src/doc/microdesc.rs @@ -462,6 +462,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/microdesc/build.rs b/crates/tor-netdoc/src/doc/microdesc/build.rs index fb7fc4251..6241bca34 100644 --- a/crates/tor-netdoc/src/doc/microdesc/build.rs +++ b/crates/tor-netdoc/src/doc/microdesc/build.rs @@ -155,6 +155,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/doc/netstatus.rs b/crates/tor-netdoc/src/doc/netstatus.rs index ec1adc510..f04f4a25b 100644 --- a/crates/tor-netdoc/src/doc/netstatus.rs +++ b/crates/tor-netdoc/src/doc/netstatus.rs @@ -1717,6 +1717,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-netdoc/src/doc/netstatus/build.rs b/crates/tor-netdoc/src/doc/netstatus/build.rs index bf588c007..54178e4cf 100644 --- a/crates/tor-netdoc/src/doc/netstatus/build.rs +++ b/crates/tor-netdoc/src/doc/netstatus/build.rs @@ -377,6 +377,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::doc::netstatus::RelayFlags; diff --git a/crates/tor-netdoc/src/doc/routerdesc.rs b/crates/tor-netdoc/src/doc/routerdesc.rs index 11c73569b..fe931eda4 100644 --- a/crates/tor-netdoc/src/doc/routerdesc.rs +++ b/crates/tor-netdoc/src/doc/routerdesc.rs @@ -885,6 +885,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; const TESTDATA: &str = include_str!("../../testdata/routerdesc1.txt"); diff --git a/crates/tor-netdoc/src/lib.rs b/crates/tor-netdoc/src/lib.rs index 6f8853807..6aeef8cd8 100644 --- a/crates/tor-netdoc/src/lib.rs +++ b/crates/tor-netdoc/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-netdoc/src/parse/parser.rs b/crates/tor-netdoc/src/parse/parser.rs index 0fc881326..d00ffa47d 100644 --- a/crates/tor-netdoc/src/parse/parser.rs +++ b/crates/tor-netdoc/src/parse/parser.rs @@ -212,7 +212,7 @@ impl<T: Keyword> SectionRules<T> { /// Check whether the tokens in a section we've parsed conform to /// these rules. - fn validate<'a>(&self, s: &Section<'a, T>) -> Result<()> { + fn validate(&self, s: &Section<'_, T>) -> Result<()> { // These vectors are both generated from T::n_vals(). assert_eq!(s.v.len(), self.rules.len()); @@ -246,7 +246,7 @@ impl<T: Keyword> SectionRules<T> { /// /// We use this to validate objects on unrecognized items, since /// otherwise nothing would check that they are well-formed. - fn validate_objects<'a>(&self, s: &Section<'a, T>, kwd: T) -> Result<()> { + fn validate_objects(&self, s: &Section<'_, T>, kwd: T) -> Result<()> { for item in s.slice(kwd).iter() { let _ = item.obj_raw()?; } @@ -277,6 +277,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::SectionRules; use crate::parse::keyword::Keyword; diff --git a/crates/tor-netdoc/src/parse/rules.rs b/crates/tor-netdoc/src/parse/rules.rs index 22bf9cc82..0ea5c4c77 100644 --- a/crates/tor-netdoc/src/parse/rules.rs +++ b/crates/tor-netdoc/src/parse/rules.rs @@ -41,7 +41,7 @@ impl<T: Keyword> TokenFmt<T> { } /// Check whether a single Item matches this TokenFmt rule, with respect /// to its number of arguments. - fn item_matches_args<'a>(&self, item: &Item<'a, T>) -> Result<()> { + fn item_matches_args(&self, item: &Item<'_, T>) -> Result<()> { let n_args = item.n_args(); if let Some(max) = self.max_args { if n_args > max { @@ -62,7 +62,7 @@ impl<T: Keyword> TokenFmt<T> { /// Check whether a single Item matches a TokenFmt rule, with respect /// to its object's presence and type. - fn item_matches_obj<'a>(&self, item: &Item<'a, T>) -> Result<()> { + fn item_matches_obj(&self, item: &Item<'_, T>) -> Result<()> { match (&self.obj, item.has_obj()) { (ObjKind::NoObj, true) => Err(EK::UnexpectedObject .with_msg(self.kwd.to_str()) @@ -76,13 +76,13 @@ impl<T: Keyword> TokenFmt<T> { /// Check whether a single item has the right number of arguments /// and object. - pub(crate) fn check_item<'a>(&self, item: &Item<'a, T>) -> Result<()> { + pub(crate) fn check_item(&self, item: &Item<'_, T>) -> Result<()> { self.item_matches_args(item)?; self.item_matches_obj(item) } /// Check whether this kind of item may appear this many times. - pub(crate) fn check_multiplicity<'a>(&self, items: &[Item<'a, T>]) -> Result<()> { + pub(crate) fn check_multiplicity(&self, items: &[Item<'_, T>]) -> Result<()> { match items.len() { 0 => { if self.required { diff --git a/crates/tor-netdoc/src/parse/tokenize.rs b/crates/tor-netdoc/src/parse/tokenize.rs index 1afc080a9..f421eaab9 100644 --- a/crates/tor-netdoc/src/parse/tokenize.rs +++ b/crates/tor-netdoc/src/parse/tokenize.rs @@ -695,6 +695,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(clippy::cognitive_complexity)] use super::*; diff --git a/crates/tor-netdoc/src/types/family.rs b/crates/tor-netdoc/src/types/family.rs index 87f0e0ee9..7571d6f9f 100644 --- a/crates/tor-netdoc/src/types/family.rs +++ b/crates/tor-netdoc/src/types/family.rs @@ -94,6 +94,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::Result; diff --git a/crates/tor-netdoc/src/types/misc.rs b/crates/tor-netdoc/src/types/misc.rs index aba7f1ba5..5f43a10de 100644 --- a/crates/tor-netdoc/src/types/misc.rs +++ b/crates/tor-netdoc/src/types/misc.rs @@ -476,6 +476,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use itertools::Itertools; use std::iter; diff --git a/crates/tor-netdoc/src/types/policy.rs b/crates/tor-netdoc/src/types/policy.rs index 4e12b0b82..ead3b226a 100644 --- a/crates/tor-netdoc/src/types/policy.rs +++ b/crates/tor-netdoc/src/types/policy.rs @@ -170,6 +170,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::Result; diff --git a/crates/tor-netdoc/src/types/policy/addrpolicy.rs b/crates/tor-netdoc/src/types/policy/addrpolicy.rs index dd9840e3b..3b1d7bcda 100644 --- a/crates/tor-netdoc/src/types/policy/addrpolicy.rs +++ b/crates/tor-netdoc/src/types/policy/addrpolicy.rs @@ -300,6 +300,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/types/policy/portpolicy.rs b/crates/tor-netdoc/src/types/policy/portpolicy.rs index ec76149ae..6396811f1 100644 --- a/crates/tor-netdoc/src/types/policy/portpolicy.rs +++ b/crates/tor-netdoc/src/types/policy/portpolicy.rs @@ -167,6 +167,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/types/version.rs b/crates/tor-netdoc/src/types/version.rs index 9373ce81b..ad6a5437a 100644 --- a/crates/tor-netdoc/src/types/version.rs +++ b/crates/tor-netdoc/src/types/version.rs @@ -187,6 +187,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/util/intern.rs b/crates/tor-netdoc/src/util/intern.rs index 7c07dbf42..0072f331f 100644 --- a/crates/tor-netdoc/src/util/intern.rs +++ b/crates/tor-netdoc/src/util/intern.rs @@ -87,6 +87,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-netdoc/src/util/str.rs b/crates/tor-netdoc/src/util/str.rs index 081e7fe61..98243101a 100644 --- a/crates/tor-netdoc/src/util/str.rs +++ b/crates/tor-netdoc/src/util/str.rs @@ -99,6 +99,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #[test] diff --git a/crates/tor-persist/src/fs.rs b/crates/tor-persist/src/fs.rs index 7417797d8..8b4f30eca 100644 --- a/crates/tor-persist/src/fs.rs +++ b/crates/tor-persist/src/fs.rs @@ -256,6 +256,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use std::{collections::HashMap, time::Duration}; diff --git a/crates/tor-persist/src/fs/clean.rs b/crates/tor-persist/src/fs/clean.rs index 04966babb..31d5030e1 100644 --- a/crates/tor-persist/src/fs/clean.rs +++ b/crates/tor-persist/src/fs/clean.rs @@ -106,6 +106,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-persist/src/lib.rs b/crates/tor-persist/src/lib.rs index 2d28984af..2dd7d2f6c 100644 --- a/crates/tor-persist/src/lib.rs +++ b/crates/tor-persist/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-persist/src/testing.rs b/crates/tor-persist/src/testing.rs index c3b232115..c06cb5ea9 100644 --- a/crates/tor-persist/src/testing.rs +++ b/crates/tor-persist/src/testing.rs @@ -182,6 +182,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use serde::{Deserialize, Serialize}; diff --git a/crates/tor-proto/src/channel/circmap.rs b/crates/tor-proto/src/channel/circmap.rs index a200eb5bf..ab1ad8fb9 100644 --- a/crates/tor-proto/src/channel/circmap.rs +++ b/crates/tor-proto/src/channel/circmap.rs @@ -247,6 +247,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use futures::channel::{mpsc, oneshot}; diff --git a/crates/tor-proto/src/channel/padding.rs b/crates/tor-proto/src/channel/padding.rs index 909f9bea5..d46d25263 100644 --- a/crates/tor-proto/src/channel/padding.rs +++ b/crates/tor-proto/src/channel/padding.rs @@ -411,6 +411,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-proto/src/channel/unique_id.rs b/crates/tor-proto/src/channel/unique_id.rs index 7679f03ea..85a4ec7eb 100644 --- a/crates/tor-proto/src/channel/unique_id.rs +++ b/crates/tor-proto/src/channel/unique_id.rs @@ -69,6 +69,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; #[test] diff --git a/crates/tor-proto/src/circuit.rs b/crates/tor-proto/src/circuit.rs index 33c868280..5264c6334 100644 --- a/crates/tor-proto/src/circuit.rs +++ b/crates/tor-proto/src/circuit.rs @@ -795,6 +795,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-proto/src/circuit/celltypes.rs b/crates/tor-proto/src/circuit/celltypes.rs index e58970a81..ca0dbd762 100644 --- a/crates/tor-proto/src/circuit/celltypes.rs +++ b/crates/tor-proto/src/circuit/celltypes.rs @@ -88,6 +88,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-proto/src/circuit/halfstream.rs b/crates/tor-proto/src/circuit/halfstream.rs index c3b95e5f2..eff43cf95 100644 --- a/crates/tor-proto/src/circuit/halfstream.rs +++ b/crates/tor-proto/src/circuit/halfstream.rs @@ -88,6 +88,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::circuit::sendme::{StreamRecvWindow, StreamSendWindow}; diff --git a/crates/tor-proto/src/circuit/sendme.rs b/crates/tor-proto/src/circuit/sendme.rs index b8a499f31..3c2508ebb 100644 --- a/crates/tor-proto/src/circuit/sendme.rs +++ b/crates/tor-proto/src/circuit/sendme.rs @@ -287,6 +287,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_cell::relaycell::{msg, RelayCell}; diff --git a/crates/tor-proto/src/circuit/streammap.rs b/crates/tor-proto/src/circuit/streammap.rs index 8387f6474..7b93fd57c 100644 --- a/crates/tor-proto/src/circuit/streammap.rs +++ b/crates/tor-proto/src/circuit/streammap.rs @@ -226,6 +226,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::circuit::sendme::StreamSendWindow; diff --git a/crates/tor-proto/src/crypto/cell.rs b/crates/tor-proto/src/crypto/cell.rs index 2111eab0d..acdc2c13b 100644 --- a/crates/tor-proto/src/crypto/cell.rs +++ b/crates/tor-proto/src/crypto/cell.rs @@ -399,6 +399,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use rand::RngCore; diff --git a/crates/tor-proto/src/crypto/handshake/fast.rs b/crates/tor-proto/src/crypto/handshake/fast.rs index fb222be67..ede99fa18 100644 --- a/crates/tor-proto/src/crypto/handshake/fast.rs +++ b/crates/tor-proto/src/crypto/handshake/fast.rs @@ -106,6 +106,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use crate::crypto::handshake::{ClientHandshake, KeyGenerator, ServerHandshake}; diff --git a/crates/tor-proto/src/crypto/handshake/hs_ntor.rs b/crates/tor-proto/src/crypto/handshake/hs_ntor.rs index 5ac241330..9dcdc6103 100644 --- a/crates/tor-proto/src/crypto/handshake/hs_ntor.rs +++ b/crates/tor-proto/src/crypto/handshake/hs_ntor.rs @@ -532,6 +532,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/crypto/handshake/ntor_v3.rs b/crates/tor-proto/src/crypto/handshake/ntor_v3.rs index 6232f462f..0cf13fcff 100644 --- a/crates/tor-proto/src/crypto/handshake/ntor_v3.rs +++ b/crates/tor-proto/src/crypto/handshake/ntor_v3.rs @@ -636,6 +636,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/crypto/ll/kdf.rs b/crates/tor-proto/src/crypto/ll/kdf.rs index b9a04b048..59a36516e 100644 --- a/crates/tor-proto/src/crypto/ll/kdf.rs +++ b/crates/tor-proto/src/crypto/ll/kdf.rs @@ -127,6 +127,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-proto/src/lib.rs b/crates/tor-proto/src/lib.rs index 20e07a2d0..0ed8b7b07 100644 --- a/crates/tor-proto/src/lib.rs +++ b/crates/tor-proto/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-proto/src/util/ct.rs b/crates/tor-proto/src/util/ct.rs index 98f983200..01de676f8 100644 --- a/crates/tor-proto/src/util/ct.rs +++ b/crates/tor-proto/src/util/ct.rs @@ -61,6 +61,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #[test] fn test_bytes_eq() { diff --git a/crates/tor-proto/src/util/skew.rs b/crates/tor-proto/src/util/skew.rs index d91893d5b..63f9ace46 100644 --- a/crates/tor-proto/src/util/skew.rs +++ b/crates/tor-proto/src/util/skew.rs @@ -153,6 +153,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-proto/src/util/ts.rs b/crates/tor-proto/src/util/ts.rs index afd6a1431..f5b8efe20 100644 --- a/crates/tor-proto/src/util/ts.rs +++ b/crates/tor-proto/src/util/ts.rs @@ -94,6 +94,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-protover/src/lib.rs b/crates/tor-protover/src/lib.rs index d3274abb1..e97366344 100644 --- a/crates/tor-protover/src/lib.rs +++ b/crates/tor-protover/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> @@ -471,6 +472,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-ptmgr/src/ipc.rs b/crates/tor-ptmgr/src/ipc.rs index c9322d388..401c4196b 100644 --- a/crates/tor-ptmgr/src/ipc.rs +++ b/crates/tor-ptmgr/src/ipc.rs @@ -809,6 +809,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use crate::ipc::{PtMessage, PtStatus}; diff --git a/crates/tor-ptmgr/src/lib.rs b/crates/tor-ptmgr/src/lib.rs index 27af2471d..e16a1252c 100644 --- a/crates/tor-ptmgr/src/lib.rs +++ b/crates/tor-ptmgr/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-rtcompat/src/async_std.rs b/crates/tor-rtcompat/src/async_std.rs index d23ba0609..01bdad1df 100644 --- a/crates/tor-rtcompat/src/async_std.rs +++ b/crates/tor-rtcompat/src/async_std.rs @@ -157,6 +157,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-rtcompat/src/impls/rustls.rs b/crates/tor-rtcompat/src/impls/rustls.rs index bd06dbf48..80bfbd5b4 100644 --- a/crates/tor-rtcompat/src/impls/rustls.rs +++ b/crates/tor-rtcompat/src/impls/rustls.rs @@ -245,6 +245,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-rtcompat/src/lib.rs b/crates/tor-rtcompat/src/lib.rs index 4ac879bac..445e89dd3 100644 --- a/crates/tor-rtcompat/src/lib.rs +++ b/crates/tor-rtcompat/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-rtcompat/src/timer.rs b/crates/tor-rtcompat/src/timer.rs index 44393876e..65e755022 100644 --- a/crates/tor-rtcompat/src/timer.rs +++ b/crates/tor-rtcompat/src/timer.rs @@ -201,6 +201,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> #![allow(clippy::erasing_op)] use super::*; diff --git a/crates/tor-rtcompat/src/tokio.rs b/crates/tor-rtcompat/src/tokio.rs index e1cdcc6a8..ee1bae330 100644 --- a/crates/tor-rtcompat/src/tokio.rs +++ b/crates/tor-rtcompat/src/tokio.rs @@ -227,6 +227,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-rtmock/src/io.rs b/crates/tor-rtmock/src/io.rs index 4e733c0a8..f6c113841 100644 --- a/crates/tor-rtmock/src/io.rs +++ b/crates/tor-rtmock/src/io.rs @@ -190,6 +190,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-rtmock/src/lib.rs b/crates/tor-rtmock/src/lib.rs index cee42e25d..6d40909cc 100644 --- a/crates/tor-rtmock/src/lib.rs +++ b/crates/tor-rtmock/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-rtmock/src/net.rs b/crates/tor-rtmock/src/net.rs index 41fdc67dc..19c95d49d 100644 --- a/crates/tor-rtmock/src/net.rs +++ b/crates/tor-rtmock/src/net.rs @@ -521,6 +521,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use futures::io::{AsyncReadExt, AsyncWriteExt}; diff --git a/crates/tor-rtmock/src/time.rs b/crates/tor-rtmock/src/time.rs index ff119d515..9e053cb2f 100644 --- a/crates/tor-rtmock/src/time.rs +++ b/crates/tor-rtmock/src/time.rs @@ -449,6 +449,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use tor_rtcompat::test_with_all_runtimes; diff --git a/crates/tor-socksproto/src/handshake.rs b/crates/tor-socksproto/src/handshake.rs index 8b93306e3..8224e6ac5 100644 --- a/crates/tor-socksproto/src/handshake.rs +++ b/crates/tor-socksproto/src/handshake.rs @@ -92,6 +92,7 @@ mod test_roundtrip { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list use crate::{ diff --git a/crates/tor-socksproto/src/handshake/client.rs b/crates/tor-socksproto/src/handshake/client.rs index 13b651593..0b9c2c832 100644 --- a/crates/tor-socksproto/src/handshake/client.rs +++ b/crates/tor-socksproto/src/handshake/client.rs @@ -312,6 +312,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-socksproto/src/handshake/proxy.rs b/crates/tor-socksproto/src/handshake/proxy.rs index 29fde2fcb..43ff952d1 100644 --- a/crates/tor-socksproto/src/handshake/proxy.rs +++ b/crates/tor-socksproto/src/handshake/proxy.rs @@ -307,6 +307,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; use hex_literal::hex; diff --git a/crates/tor-socksproto/src/lib.rs b/crates/tor-socksproto/src/lib.rs index 0342f17b2..e3fb87a97 100644 --- a/crates/tor-socksproto/src/lib.rs +++ b/crates/tor-socksproto/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/crates/tor-socksproto/src/msg.rs b/crates/tor-socksproto/src/msg.rs index 61ed9d8fa..0e87c27c5 100644 --- a/crates/tor-socksproto/src/msg.rs +++ b/crates/tor-socksproto/src/msg.rs @@ -413,6 +413,7 @@ mod test { #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] + #![allow(clippy::unchecked_duration_subtraction)] //! <!-- @@ end test lint list maintained by maint/add_warning @@ --> use super::*; diff --git a/crates/tor-units/src/lib.rs b/crates/tor-units/src/lib.rs index f6a59bccb..fbdbd8b25 100644 --- a/crates/tor-units/src/lib.rs +++ b/crates/tor-units/src/lib.rs @@ -33,6 +33,7 @@ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 //! <!-- @@ end lint list maintained by maint/add_warning @@ --> diff --git a/maint/add_warning b/maint/add_warning index a86caa357..3a3dcc4f9 100755 --- a/maint/add_warning +++ b/maint/add_warning @@ -43,6 +43,7 @@ WANT_LINTS = """ #![warn(clippy::unseparated_literal_suffix)] #![deny(clippy::unwrap_used)] #![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness +#![allow(clippy::uninlined_format_args)] #![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945 #![allow(clippy::result_large_err)] // temporary workaround for arti#587 """ @@ -57,6 +58,7 @@ TEST_LINTS = """ #![allow(clippy::print_stdout)] #![allow(clippy::single_char_pattern)] #![allow(clippy::unwrap_used)] +#![allow(clippy::unchecked_duration_subtraction)] """ # ---------- some notes about lints we might use - NOT USED by any code here ---------- |