mirrors/arti.git/tor-netdir/src, branch main mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2021-08-27T13:53:09Z Move all crates into a `crates` subdirectory. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing. Simplify NetParameters::default() 2021-08-27T13:17:49Z Nick Mathewson nickm@torproject.org 2021-08-27T13:17:49Z urn:sha1:bec5ed5b1c82c4b799d7341d0ed4de3f93fba9e7 Instead of loading it with expect() calls, make a new function that returns a Result, and call expect() only once. Tweaks on patch to add clippy::unwrap_used lint. 2021-08-27T13:05:25Z Nick Mathewson nickm@torproject.org 2021-08-27T13:05:25Z urn:sha1:2c0ec4e44242efbab692688491fbd2b7938983a2 The most frequent changes are: - Rewording messages about poisoned locks - Correcting some error types Change `unwrap` to `expect` with message 2021-08-25T21:12:53Z S0AndS0 strangerthanbland@gmail.com 2021-08-25T21:12:53Z urn:sha1:2333659aca441ac985a63f05f34c666680fd211f > Note, while `cargo fmt` doesn't complain I think this section could be > prettier. Also it may be a good idea to have tests double-check that future > changes don't cause a panic condition. Move "use_unwrap" lint from some to want list 2021-08-25T19:23:57Z S0AndS0 strangerthanbland@gmail.com 2021-08-25T19:23:57Z urn:sha1:b95513c5e69014061746d23a511b4a0744ee127e And convert some `add_or_port` calls to use `SocketAddr` instead of parse + unwrap on strings. > Note, this last change is only for IPv4 addresses, for now, and only > within tests. WIP: Add the "unwrap_used" lint. 2021-08-24T22:31:31Z S0AndS0 strangerthanbland@gmail.com 2021-08-24T22:31:31Z urn:sha1:432fd9443ec12a7fafb14b05b340a337f1c03f20 > Check `unwrap_used` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used This adds the following Clippy configuration to crates; #![deny(clippy::unwrap_used)] **Warning** while tests and compiler do not show any errors, the submitted changes are very much a Work In Progress and mistakes may have been made. Check https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67 Merge Request thread for more details. Switch all uses of the log crate to the tracing. 2021-08-20T18:10:50Z Jani Monoses jani.monoses@gmail.com 2021-08-20T16:27:11Z urn:sha1:44d1271c86211f36f6385ab7cbc9e29bfb714b1f Issue #74 Fix a few things that the "typos" tool didn't like. 2021-08-20T16:11:28Z Nick Mathewson nickm@torproject.org 2021-08-20T16:08:47Z urn:sha1:92501895fd3450bf76df327d707374bae3cbe56f Document panics in tor-netdir::testnet. 2021-08-18T14:11:50Z Nick Mathewson nickm@torproject.org 2021-08-18T14:11:50Z urn:sha1:cd202f48a752f4674613c784d90172bd55d2c61e Revisions based on new documented-panics lint. 2021-08-18T13:55:39Z Nick Mathewson nickm@torproject.org 2021-08-18T13:55:39Z urn:sha1:341e3937b49c04680e9689c8a065c2f0b03c6355 I've tried to remove some of possible panics, and improve the documentation for when the others might occur.