mirrors/arti.git/maint/rust-maint-common, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-08-07T15:28:36ZSwitch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
maint: Avoid x-prefix in comparisons.2025-07-17T17:07:39ZGabriela Moldovangabi@torproject.org2025-07-17T16:54:34Zurn:sha1:6004dd18e584bbbbcc58d0a3a2e9a20e12b879a5
This applies the fixes suggested by shellcheck (the x-prefixes were
causing the `shellcheck` job to fail; see [SC2268]).
[SC2268]: https://www.shellcheck.net/wiki/SC2268
forbid-hard-tabs: Improve doc comment2024-10-02T14:37:15ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T14:29:45Zurn:sha1:62302873e2c0fc640bb75abec73f0b6b4450145d
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2488#note_3087164
bash-utils.sh: reject_options: Don't crash due to -u if no arguments2024-10-02T14:37:15ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T09:20:32Zurn:sha1:d78d1092873b0f9b60bd6e72bd1a37b6bbd53149Provide new forbid-hard-tabs script2024-10-02T14:37:15ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T09:14:00Zurn:sha1:07c8b7fe13b2158cccb48798b395a5188fa3d61eFix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adExclude debian/* from the forbid-absolute-shebangs checks2024-08-27T09:40:55ZNoisyCoilnoisycoil@tutanota.com2024-08-16T17:20:37Zurn:sha1:7ed29c071d27eb8272e386706978778e7bb807bemaint/rust-maint-common/forbid-absolute-shebang: Fix error message2024-07-17T14:38:12ZIan Jacksoniwj@torproject.org2024-07-17T14:38:12Zurn:sha1:e23f2224e93e807335d5b2ff3fb3cd506a702a68maint/common/update-shell-includes: Tolerate includes with a `$`2024-07-16T11:46:39ZIan Jacksonijackson@chiark.greenend.org.uk2024-07-16T11:46:39Zurn:sha1:c59b4cfdfca6e7db2bef8dab3fd998c9d4f597b1
These are not hardcoded, whatever they are, so they're not the
principal thing we're trying to prevent. Previously, this would trip
on this in arti.git:maint/cargo-publish:
maint="$(dirname "$0")"
...
# shellcheck source=maint/crates-io-utils.sh
source "$maint/crates-io-utils.sh"
Ideally we'd teach this script to be able to check and maintain
includes for scripts that aren't in common/, but I think that's a task
for another day.
maint/common/forbid-absolute-shebansg: Fix error handling2024-07-16T11:40:51ZIan Jacksonijackson@chiark.greenend.org.uk2024-07-16T11:21:28Zurn:sha1:0450494da36e400a38a4e516d155a3121ca7e934
set -o pipefail is defused by the if. And we should properly check
the expected statuses from git.
If git isn't found, this script would otherwise spuriously think
everything is fine.