mirrors/arti.git/maint/fixup-features/src, branch arti-v2.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.4.02026-02-16T15:22:24ZAllow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Run script to add new warning2026-01-27T18:05:36ZGabriela Moldovangabi@torproject.org2026-01-27T18:05:36Zurn:sha1:a98faf72eb06b47700faeeac5a8a0dd0fc29b584
This adds the lint to all our crates.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Teach fixup-features to duplicate the modal indentation in an array2025-10-02T15:33:30ZNick Mathewsonnickm@torproject.org2025-10-02T15:17:35Zurn:sha1:969e091f16ff4d8cd15bf1ca0dce27b2d87e3afe
If we can't figure out the modal indentation, use " ".
Closes #1719.
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Update code for Edition 20242025-08-07T15:28:31ZNick Mathewsonnickm@torproject.org2025-08-07T12:44:47Zurn:sha1:0453fb4be8cf618b94230812957ce1db1afe74bd
1. Run cargo fix --edition
2. Selectively revert the "if let"->"match" changes.
These changes are meant to protect us from the lifetime changes
for "if let" bindings in Rust 2024.
But we're not actually relying on the old lifetime rules
anywhere, and the match syntax here is quite ugly.
3. Automatically revert `$pat:expr_2021` to `$pat:expr`.
(We don't actually want to restrict the expression syntax
that our macros accept).
Done with
`git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'`
4. Run cargo fmt.
Temporarily suppress mismatched_lifetime_syntaxes.2025-07-07T15:50:04ZGabriela Moldovangabi@torproject.org2025-07-07T15:50:04Zurn:sha1:a11b611466a5a73f5e06a0aabd17284a57d12fe3
See #2060.
examples, fixup-features: use inline vars in format string2025-05-29T14:21:17ZNick Mathewsonnickm@torproject.org2025-05-21T14:04:15Zurn:sha1:9c7fe185eac90b75ce3c0d4c58be53e7882e4025
Nightly clippy now suggests this.
clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
Merge branch 'dev/cve/fixup-features' into 'main'2024-12-03T22:05:31Zoparaopara@torproject.org2024-12-03T22:05:31Zurn:sha1:b0387d12f55d673051f38bc3b8076d3f7355a265
maint: Add exclusion feature to `fixup-features`
Closes #1766
See merge request tpo/core/arti!2652