mirrors/arti.git/maint/add_warning, branch arti-v2.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.2.02026-02-16T15:22:24ZAllow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Deny clippy::unused_async2026-01-27T18:04:48ZGabriela Moldovangabi@torproject.org2026-01-27T18:04:48Zurn:sha1:ee8e140df43c9dea92222352f49f25446a5ede19
Part of #2328
Bump black2026-01-21T17:38:52ZJim Newsomejnewsome@torproject.org2026-01-21T17:37:13Zurn:sha1:815fa2ae277acee29fa365bd6c94806757a42fb5Fix name of clippy lint to unchecked_time_subtraction (1)2025-11-06T11:28:05ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:01Zurn:sha1:7c9858af481e2f06598597ffa33a954792786c85
warning: lint `clippy::unchecked_duration_subtraction` has been renamed to `clippy::unchecked_time_subtraction`
--> crates/arti-client/examples/advanced_isolation.rs:11:10
|
11 | #![allow(clippy::unchecked_duration_subtraction)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::unchecked_time_subtraction`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
Add the change to maint/add_warning.
Temporarily suppress mismatched_lifetime_syntaxes.2025-07-07T15:50:04ZGabriela Moldovangabi@torproject.org2025-07-07T15:50:04Zurn:sha1:a11b611466a5a73f5e06a0aabd17284a57d12fe3
See #2060.
clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
add_warnings, *: Allow clippy::needless_lifetimes2024-12-03T14:27:26ZNick Mathewsonnickm@torproject.org2024-12-03T14:15:50Zurn:sha1:64cc3f2ed3eea0b7c5cc89ae07cbdadfdc1646fb
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
python: Use "a not in b" rather than "not a in b".2024-10-24T13:51:32ZNick Mathewsonnickm@torproject.org2024-10-24T13:26:15Zurn:sha1:dec09eb7d7e424b1e008d01977aa35ca7921b30a
Due to precedence, both work the same, but the former is preferred.
Run "black" to reformat all our python2024-10-24T12:30:47ZNick Mathewsonnickm@torproject.org2024-10-24T12:25:27Zurn:sha1:bf7e7056f97be0015aa3643ab9c7aa564f17bbe5
"Black" is an "opinionated" python formatter, whose opinionatedness
is somewhat in the spirit of rustfmt.
This MR runs black with default settings on all of our python code
in Arti. It was produced by the following commands
```
# Everything in python/
black python/
# Everything with a .py extension
fd '.py$' -X black
# Everything with a python shebang.
git grep -l '#! */usr/bin/env *python' | xargs black
```
Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57ad