mirrors/arti.git/maint/add_warning, branch arti-v1.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.02024-10-24T13:51:32Zpython: Use "a not in b" rather than "not a in b".2024-10-24T13:51:32ZNick Mathewsonnickm@torproject.org2024-10-24T13:26:15Zurn:sha1:dec09eb7d7e424b1e008d01977aa35ca7921b30a
Due to precedence, both work the same, but the former is preferred.
Run "black" to reformat all our python2024-10-24T12:30:47ZNick Mathewsonnickm@torproject.org2024-10-24T12:25:27Zurn:sha1:bf7e7056f97be0015aa3643ab9c7aa564f17bbe5
"Black" is an "opinionated" python formatter, whose opinionatedness
is somewhat in the spirit of rustfmt.
This MR runs black with default settings on all of our python code
in Arti. It was produced by the following commands
```
# Everything in python/
black python/
# Everything with a .py extension
fd '.py$' -X black
# Everything with a python shebang.
git grep -l '#! */usr/bin/env *python' | xargs black
```
Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adadd_warning: fix a python mistake.2024-05-07T16:43:23ZNick Mathewsonnickm@torproject.org2024-05-07T16:43:23Zurn:sha1:23ff845bbec0d2f7b616f0baea63e2b0be72c536add_warning: Add an "Example lints" list2024-05-07T15:15:26ZNick Mathewsonnickm@torproject.org2024-05-07T15:15:26Zurn:sha1:48ece29f828faa4c20452bfa252b34062dcaf173
This is the same as the TEST_LINTS exception list, plus the
nightly exception from our main lints list. It matches what
we have in crates/examples/*.rs.
add_warning: Use regexes and maps to find lists of lints2024-05-07T15:06:00ZNick Mathewsonnickm@torproject.org2024-05-07T15:06:00Zurn:sha1:c98990a2076746d3d362197b8ad9c4d2d90b6ecf
This keeps our begin/end lines consistent, and lets us add new lists.
add_warning: Allow suppression of marked lines, and avoid cfg().2024-05-06T13:25:17ZNick Mathewsonnickm@torproject.org2024-05-06T13:05:13Zurn:sha1:27a603fda9c5ab671ae39abeb09fc506ea69824a
Sometimes we want to enforce different lints
depending on whether we're running CI.
Until now we've been using `#[cfg(not(ci_arti_FOO))]` for this,
but that approach now seems to be somewhat deprecated,
and to cause warnings on nightly. (See #1395.)
Instead, I'm tweaking the add_warning script
so that it can conditionally suppress lines depending on
a command-line argument that it receives.
maint/add_warning: permit clippy::mixed_attributes_style in tests.2024-03-13T16:30:41ZNick Mathewsonnickm@torproject.org2024-03-13T16:25:23Zurn:sha1:166121d1967c7dd0ce71f1da3dc9504ce422eb9a
This is a new warning on nightly. It triggers for every one of our
test blocks that starts with `#[cfg(test)]` and then goes on to
have an `#![allow(...)]` block at the start of the module.
deny clippy::unchecked_duration_subtraction2024-02-29T17:16:49Ztrinity-1686atrinity@deuxfleurs.fr2024-02-29T17:06:46Zurn:sha1:ac5b36027ca825d27ef466501c660ce498fd9e3cclippy: Suppress needless_pass_by_value in tests2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:26:40Zurn:sha1:ce8b0184ec6d896a7c7d136467f40db34a6b61fd
Rationale: same as for useless_vec, as in 01cb7ee0a112.
Prompted by reading a commit where someone did makework to get rid of
an occurrence of this warning.