mirrors/arti.git/maint/add_warning, branch arti-v1.2.8 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.8 2024-09-03T08:09:02Z Fix typos 2024-09-03T08:09:02Z Dimitris Apostolou dimitris.apostolou@icloud.com 2024-09-03T08:09:02Z urn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57ad add_warning: fix a python mistake. 2024-05-07T16:43:23Z Nick Mathewson nickm@torproject.org 2024-05-07T16:43:23Z urn:sha1:23ff845bbec0d2f7b616f0baea63e2b0be72c536 add_warning: Add an "Example lints" list 2024-05-07T15:15:26Z Nick Mathewson nickm@torproject.org 2024-05-07T15:15:26Z urn:sha1:48ece29f828faa4c20452bfa252b34062dcaf173 This is the same as the TEST_LINTS exception list, plus the nightly exception from our main lints list. It matches what we have in crates/examples/*.rs. add_warning: Use regexes and maps to find lists of lints 2024-05-07T15:06:00Z Nick Mathewson nickm@torproject.org 2024-05-07T15:06:00Z urn:sha1:c98990a2076746d3d362197b8ad9c4d2d90b6ecf This keeps our begin/end lines consistent, and lets us add new lists. add_warning: Allow suppression of marked lines, and avoid cfg(). 2024-05-06T13:25:17Z Nick Mathewson nickm@torproject.org 2024-05-06T13:05:13Z urn:sha1:27a603fda9c5ab671ae39abeb09fc506ea69824a Sometimes we want to enforce different lints depending on whether we're running CI. Until now we've been using `#[cfg(not(ci_arti_FOO))]` for this, but that approach now seems to be somewhat deprecated, and to cause warnings on nightly. (See #1395.) Instead, I'm tweaking the add_warning script so that it can conditionally suppress lines depending on a command-line argument that it receives. maint/add_warning: permit clippy::mixed_attributes_style in tests. 2024-03-13T16:30:41Z Nick Mathewson nickm@torproject.org 2024-03-13T16:25:23Z urn:sha1:166121d1967c7dd0ce71f1da3dc9504ce422eb9a This is a new warning on nightly. It triggers for every one of our test blocks that starts with `#[cfg(test)]` and then goes on to have an `#![allow(...)]` block at the start of the module. deny clippy::unchecked_duration_subtraction 2024-02-29T17:16:49Z trinity-1686a trinity@deuxfleurs.fr 2024-02-29T17:06:46Z urn:sha1:ac5b36027ca825d27ef466501c660ce498fd9e3c clippy: Suppress needless_pass_by_value in tests 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:26:40Z urn:sha1:ce8b0184ec6d896a7c7d136467f40db34a6b61fd Rationale: same as for useless_vec, as in 01cb7ee0a112. Prompted by reading a commit where someone did makework to get rid of an occurrence of this warning. add_warning: Change missing_docs,unreachable_pub to warn 2023-08-04T11:43:16Z Nick Mathewson nickm@torproject.org 2023-08-04T11:40:27Z urn:sha1:9db1cc430a0da13a842edb68d45bb848dda5ccea Part of #951. See comments for explanation of why this is important. clippy: in tests, allow clippy::useless_vec 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:20:22Z urn:sha1:01cb7ee0a1122c435a1c782f08b42fa3bf6969e6 This is a perf issue, only. If tests are too slow, we will notice and ca speed them up. We should optimise for clarity and convenience, rather than speed. Forbidding this can result in churn between vec![] and [] as tests are updated and changed.