mirrors/arti.git/maint/add_warning, branch arti-v1.1.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.2 2023-01-27T13:28:02Z Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. Disable clippy::unlinlined-format-args 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748. shell: use /usr/bin/env instead of absolute paths 2023-01-25T17:35:53Z Emil Engler me@emilengler.com 2023-01-25T17:35:53Z urn:sha1:79097484de7401bf247e14c1bdf5982aee4518a1 This commit changes the shebang in all shell scripts from absolute paths (such as `/bin/bash` or `/usr/bin/python3`) to the `/usr/bin/env` binary with the accompanying interpreter as it's argument. The reason for this are as follows: - NixOS cannot work with absolute paths - BSD systems install their packages in /usr/local/bin add_warnings: ignore clippy::result_large_err 2022-11-03T15:05:14Z Nick Mathewson nickm@torproject.org 2022-11-03T15:05:14Z urn:sha1:e4ca2459dbb9489fe9a4acee32216846a62f4216 This is a temporary workaround for #587 until we get it fixed for real. add_warnings: work with more non-GNU finds. 2022-11-03T15:03:43Z Nick Mathewson nickm@torproject.org 2022-11-03T15:03:43Z urn:sha1:0cb886a098797a8674fd93b37125350d17c43677 We were doing `find -name '*.rs'`, but `find . -name '*.rs'` (with the .) is more standard. Allow "clippy::single_char_pattern" in tests. 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. format python script in maint 2022-08-16T17:15:35Z FAMASoon famasoon@gmail.com 2022-08-16T17:15:35Z urn:sha1:4cfdeca0f10f39dfa3ef8ec1700ed8cb2cad37f6 maint/add_warning: Fix parsing of --check 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:36:18Z urn:sha1:b7c03943f1dd638e41048d475bed99aaf410fd88 Previously this would eat the first filename! clippy: Consolidate many lints in maint/add_warning 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. maint/add_warning: Add two lints via add_warning as a test case 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:15:49Z urn:sha1:bebf013bef9902d5c8dfc57c0be62076de3fee51