mirrors/arti.git/maint/add_warning, branch arti-v1.1.11mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.112023-08-23T09:34:00Zclippy: Suppress needless_pass_by_value in tests2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:26:40Zurn:sha1:ce8b0184ec6d896a7c7d136467f40db34a6b61fd
Rationale: same as for useless_vec, as in 01cb7ee0a112.
Prompted by reading a commit where someone did makework to get rid of
an occurrence of this warning.
add_warning: Change missing_docs,unreachable_pub to warn2023-08-04T11:43:16ZNick Mathewsonnickm@torproject.org2023-08-04T11:40:27Zurn:sha1:9db1cc430a0da13a842edb68d45bb848dda5ccea
Part of #951. See comments for explanation of why this is important.
clippy: in tests, allow clippy::useless_vec2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:20:22Zurn:sha1:01cb7ee0a1122c435a1c782f08b42fa3bf6969e6
This is a perf issue, only. If tests are too slow, we will notice and
ca speed them up. We should optimise for clarity and convenience,
rather than speed.
Forbidding this can result in churn between vec![] and [] as tests are
updated and changed.
clippy: globally allow clippy::needless_raw_string_hashes2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:15:36Zurn:sha1:43bf89d54024c5d73246eefaea071ab6b3a764eb
Rationale: no-one writes these by default without thinkinh. If they
are unnecessary, then either the string must have had " in it
before (in which case it might do again), or it is near other strings
which *do* need it.
And having it does no harm; indeed IMO it can increase clarity.
Alternative to !1388's
Fix new "needless_raw_string_hashes" lint from clippy +nightly
add_warning: Tolerate clippy::missing_panics_doc2023-07-06T18:29:40ZNick Mathewsonnickm@torproject.org2023-07-06T18:29:40Zurn:sha1:7e2fa11065b569920cc7ce6ce7ec2ba8ed96389f
As of current nightly, this lint now includes expect()s,
which makes it trigger way more than we'd like.
See discussion on #950.
lints: Promote clippy::print_stderr and clippy::print_stdout2023-06-21T11:14:10ZIan Jacksonijackson@chiark.greenend.org.uk2023-06-21T10:29:18Zurn:sha1:802200e2382edaaf45a109721c2c5d1e8889d317
These are available in our MSRV now, so we don't need to handle
specially. We can just add them to the standard lint block.
(Lint block in every crate will be updated automatically in the next
commit.)
Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
Disable clippy::unlinlined-format-args2023-01-27T13:27:47ZNick Mathewsonnickm@torproject.org2023-01-27T12:49:39Zurn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2
This warning kind of snuck up on us! (See #748) For now, let's
disable it. (I've cleaned it up in a couple of examples, since
those are meant to be more idiomatic and user-facing.)
Closes #748.
shell: use /usr/bin/env instead of absolute paths2023-01-25T17:35:53ZEmil Englerme@emilengler.com2023-01-25T17:35:53Zurn:sha1:79097484de7401bf247e14c1bdf5982aee4518a1
This commit changes the shebang in all shell scripts from absolute
paths (such as `/bin/bash` or `/usr/bin/python3`) to the `/usr/bin/env`
binary with the accompanying interpreter as it's argument.
The reason for this are as follows:
- NixOS cannot work with absolute paths
- BSD systems install their packages in /usr/local/bin
add_warnings: ignore clippy::result_large_err2022-11-03T15:05:14ZNick Mathewsonnickm@torproject.org2022-11-03T15:05:14Zurn:sha1:e4ca2459dbb9489fe9a4acee32216846a62f4216
This is a temporary workaround for #587 until we get it fixed for
real.