mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.2.0 2022-03-30T14:39:09Z 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T22:25:52Z urn:sha1:ea520898fd66f0b2d56a02e5873c202a71b6ef7a 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T21:09:54Z urn:sha1:b28863f03d51ab051665f47b06bd54d3e7b966b4 2022-03-30T14:34:48Z Nick Mathewson nickm@torproject.org 2022-03-25T17:38:01Z urn:sha1:80b65c3a4d4108c6b4b0cb91722f89c8e5859b7d This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects. 2022-03-30T13:26:43Z eta tor@eta.st 2022-03-28T12:54:36Z urn:sha1:ac64bdea2744c6cd0ede0562954efcfe479afd94 The various background daemon tasks that `arti-client` used to spawn are now handled inside their respective crates instead, with functions provided to spawn them that return `TaskHandle`s. This required introducing a new trait, `NetDirProvider`, which steals some functionality from the `DirProvider` trait to enable `tor-circmgr` to depend on it (`tor-circmgr` is a dependency of `tor-dirmgr`, so it can't depend on `DirProvider` directly). While we're at it, we also make some of the tasks wait for events from the `NetDirProvider` instead of sleeping, slightly increasing efficiency. 2022-03-23T12:49:36Z Nick Mathewson nickm@torproject.org 2022-03-23T12:49:36Z urn:sha1:791394cd2b455646c5e8938e7592d73b28c7977b tor-proto: add the ability to learn clock skew from NETINFO cells See merge request tpo/core/arti!410 2022-03-23T12:24:36Z Nick Mathewson nickm@torproject.org 2022-03-14T18:33:11Z urn:sha1:0b2cf533ee5771fdb16255652837af69c316642e We now check the handshake certificates unconditionally, and only report them as _expired_ as a last resort. (Rationale: if somebody is presenting the wrong identity from a year ago, it is more interesting that they are presenting the wrong ID than it is that they are doing so with an expired cert. We also now report a different error if the certificate is expired, but its expiration is within the range of reported clock skew. (Rationale: it's helpful to distinguish this case, so that we can blame the failure on possible clock skew rather than definitely attributing it to a misbehaving relay.) Part of #405. 2022-03-23T12:24:36Z Nick Mathewson nickm@torproject.org 2022-03-14T15:51:06Z urn:sha1:3885a2c05b64e6d071adfabdf5eb957fab001a5d NETINFO cells, which are sent in every handshake, may contain timestamps. This patch adds an accessor for the timestamp in the Netinfo messages, and teaches the tor-proto code how to compute the minimum clock skew in the code. The computation isn't terribly precise, but it doesn't need to be: Tor should work fine if your clock is accurate to within a few hours. This patch also notes a Y2038 problem in the protocol: see torspec#80. Part of #405. 2022-03-21T13:06:32Z Nick Mathewson nickm@torproject.org 2022-03-18T16:03:48Z urn:sha1:acfa0f7770f0b7146908e1975d25976315bf2070 This commit refactors the dirclient error type into two cases: errors when constructing a circuit, and errors that occur once we already have a one-hop circuit. The latter can usually be attributed to the specific cache we're talking to. This commit also adds a function to expose the information about which directory gave us the info. 2022-03-21T13:06:32Z Nick Mathewson nickm@torproject.org 2022-03-18T15:57:39Z urn:sha1:d38aafa054a89d7e5217b48d9161d899d18553aa We already have the ability to get peer information from ChanMgr errors, and therefore from any RetryErrors that contain ChanMgr errors. This commit adds optional peer information to tor-proto errors, and a function to expose whatever peer information is available. 2022-03-21T13:06:32Z Nick Mathewson nickm@torproject.org 2022-03-17T13:33:47Z urn:sha1:d778a922255a75e36baa5296451e9982045ac777 It'll soon more convenient to pass in FallbackDirs as a slice of references, rather than just a slice of FallbackDirs: I'm going to be changing how we handle these in tor-dirmgr.