mirrors/arti.git/crates/tor-socksproto/src/handshake, branch tor-llcrypto-v0.4.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-llcrypto-v0.4.4 2023-02-09T15:20:31Z Change tor_bytes::Error::BadMessage to a Cow. 2023-02-09T15:20:31Z Nick Mathewson nickm@torproject.org 2023-02-08T13:51:27Z urn:sha1:48ab7b0463aaada172a426ad4b20a63d7f44cb84 Actually, to avoid making a breaking change, I'm deprecating BadMessage and creating a new InvalidMessage variant that takes a Cow. This way I don't need to track every crate that re-exposes tor_bytes::Error and call this a breaking change in those. Making this change will allow tor_bytes errors to be much more helpful. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. test lint blocks: Standardise one in tor-socksproto 2022-12-12T17:50:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:43:29Z urn:sha1:ec7720ae917ba2ca0e6af088a487d5914d4398bc The previous syntax was recognised by the real script, but not by the ad-hoc script I'm about to use to add all the missing ones. Allow "clippy::single_char_pattern" in tests. 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. Move generate_* methods in socks client impl. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-30T14:31:33Z urn:sha1:f81afe4930970a0f557d352acff0499f0b3a26b3 Tweak "handshake" docs. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-30T12:37:51Z urn:sha1:41be40694d4e04a6f84e567c1a92bc3353115922 Per a suggestion from Diziet, clarify that the socks handshake code only wants you to drain your buffers when it tells you to. Add a SocksReply type to capture address/port information. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-30T12:31:53Z urn:sha1:235bda121040889be8b6b2f71fa969aea60960fa I don't expect us to need this information much, but we may as well hang on to it. Tests for socks client handshake. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-28T13:29:02Z urn:sha1:3ae062911b7b00a4dcc98c73a8700d4f5309f6ff These tests include a few reference cases, as well as a little framework to make sure that the client and the proxy implementation will handshake with one another successfully. Bug fix: report empty SOCKS4 auth as "no auth". 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-28T13:23:21Z urn:sha1:cb4e32ddc7e560006f79c4ca4466aa1ddf21700c Previously we would report it as authenticating using the empty string.