mirrors/arti.git/crates/tor-socksproto/src/handshake/proxy.rs, branch arti-v1.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.5.02024-10-01T12:57:42Ztor-socksproto: Code motion to tidy up2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T16:58:15Zurn:sha1:df862342c9cf25b68f337b9b2f4f3f76a5d9ff76tor-socksproto: Deprecate old API2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T13:47:16Zurn:sha1:20ccfb7424f0c66e4930b239f0605b2e040f314ftor-socksproto: Introduce handshake_for_tests method (fmt)2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T15:52:16Zurn:sha1:ecad61135d04b21750d62a05b5233c456444751ftor-socksproto: Introduce handshake_for_tests method2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T14:59:03Zurn:sha1:d67a39b8335e7f8c5c6dccccf4bf80f97f10d7b9tor-socksproto: Add HasHandshakeOutput2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-17T14:36:19Zurn:sha1:21d75b67279b094ec6b58eaab47085b6e9fd5a72
Our new API implementation will need this.
Apply deferred rustfmt churn2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T12:50:39Zurn:sha1:c2e1b4bcc8a8f1dca4cc2d8cba60700fecb19976tor-socksproto: Make NextStepImpl an enum (tidy)2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T10:56:28Zurn:sha1:7535f079be733a4298e91eb90a9c3a109dd657a0
Remove redundant {} from construction of NextStepImpl::Finished.
(We kept these in the previous commit to reduce the size of the diff there.)
tor-socksproto: Make NextStepImpl an enum2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T10:38:16Zurn:sha1:e77799e91b317fccf9dd5448ed6f07507a487c6a
We never say both "finished" and "reply". Make this explicit.
Our new caller API is going to depend on this.
Also, notice if the implementation's behaviour implies an infinite
loop, and call that an internal error instead.
tor-socksproto: Introduce NextStepImpl and do drain centrally2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T10:32:21Zurn:sha1:306d3a13da3648e44bf56a6d711147a23b228bd5
This separates the public API from the internal API, which will allow
us to do more work centrally, and defend against various bugs on both
sides.
The name mirrors a new `NestStep` type we'll introduce as part of a
new caller API.
For now, we make only one centralisation change: Action.drain is now
computed centrally rather than ad-hoc in each protocol implementation
branch.
tor-socksproto: Move `handshake` to be a trait method2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-12T14:51:11Zurn:sha1:2e496795b0583ff5d09e436ac7b00eb18beea1f0
This deduplicates some docs and eliminates the two wrapper functiosn
for `run_handshake`, which is now just `handshake`.
We're going to make other API breaks too, and this isn't going to be
the primary API, so we might as well do this.
Proper description of the semver breakage will come at the end when
it's all done.