mirrors/arti.git/crates/tor-socksproto/src/handshake.rs, branch tor-llcrypto-v0.4.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-llcrypto-v0.4.4 2023-02-09T15:20:31Z Change tor_bytes::Error::BadMessage to a Cow. 2023-02-09T15:20:31Z Nick Mathewson nickm@torproject.org 2023-02-08T13:51:27Z urn:sha1:48ab7b0463aaada172a426ad4b20a63d7f44cb84 Actually, to avoid making a breaking change, I'm deprecating BadMessage and creating a new InvalidMessage variant that takes a Cow. This way I don't need to track every crate that re-exposes tor_bytes::Error and call this a breaking change in those. Making this change will allow tor_bytes errors to be much more helpful. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. Allow "clippy::single_char_pattern" in tests. 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. Add a SocksReply type to capture address/port information. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-30T12:31:53Z urn:sha1:235bda121040889be8b6b2f71fa969aea60960fa I don't expect us to need this information much, but we may as well hang on to it. Tests for socks client handshake. 2022-10-03T16:52:38Z Nick Mathewson nickm@torproject.org 2022-09-28T13:29:02Z urn:sha1:3ae062911b7b00a4dcc98c73a8700d4f5309f6ff These tests include a few reference cases, as well as a little framework to make sure that the client and the proxy implementation will handshake with one another successfully. Implement client-side SOCKS handshake 2022-09-28T13:29:56Z Nick Mathewson nickm@torproject.org 2022-09-27T16:41:48Z urn:sha1:af99979689f94bce07bd04a57e90c63f9d304097 socksproto: Rename SocksHandshake to SocksProxyHandshake. 2022-09-27T12:28:47Z Nick Mathewson nickm@torproject.org 2022-09-27T12:23:44Z urn:sha1:b08073c2d43d7be58db62d6c6a51721dc6f797f1 Retain "SocksHandshake" as a deprecated synonym. Also, make an (on-by-default) feature for SocksProxyHandshake. (There is about to be a SocksClientHandshake as well.) socksproto: Use fallible writers. 2022-07-11T15:18:51Z Nick Mathewson nickm@torproject.org 2022-07-09T17:33:42Z urn:sha1:9ca301faee791af6828835618bb737913a337de5 Also, make private a function that had formerly been `pub`. Convert each write_onto_infallible implementation into write_onto. 2022-07-11T15:18:51Z Nick Mathewson nickm@torproject.org 2022-07-08T15:37:50Z urn:sha1:8810af7f6522d43408e30d04d21c4ec6102d73b3 Rename "write" methods on tor-bytes to "write_infallible". 2022-07-11T15:18:51Z Nick Mathewson nickm@torproject.org 2022-07-08T15:20:50Z urn:sha1:7938f65c66020d6d7f143307f3336f340f398c63 This comprises four renames: ``` write_onto -> write_onto_infallible write_into -> write_into_infallible write -> write_infallible writer_and_consume -> write_and_consume_infallible. ``` The rest of this branch will be concerned with replacing these `_infallible` methods with ones that return a `Result`. This is part of #513.