mirrors/arti.git/crates/tor-socksproto/src/handshake.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
tor-socksproto: Handle 0-byte reads (EOF) correctly2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-25T18:14:07Zurn:sha1:369391a58cbddac054b494ac53bdd7973610994a
This restores the functionality of
socks users: detect closed sockets.
0c595818f713916d94b7b0e4062f953fad7c9799
which we reverted as part of rebasing this branch onto main.
tor-socksproto: Introduce handshake_for_tests method (fmt)2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T15:52:16Zurn:sha1:ecad61135d04b21750d62a05b5233c456444751ftor-socksproto: Introduce handshake_for_tests method2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T14:59:03Zurn:sha1:d67a39b8335e7f8c5c6dccccf4bf80f97f10d7b9tor-socksproto tests: Run test cases via new API in various modes2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T16:17:25Zurn:sha1:73e5b3ecb0e453940ee00e0f3eacb265998c57cetor-socksproto tests: Use crate::* rather than ad-hoc imports2024-10-01T12:57:42ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T16:12:19Zurn:sha1:3192eb5e1f37c00b3b733a432f090cf5a4b41186Apply deferred rustfmt churn2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-19T12:50:39Zurn:sha1:c2e1b4bcc8a8f1dca4cc2d8cba60700fecb19976tor-socksproto: Move `handshake` to be a trait method2024-10-01T12:54:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-12T14:51:11Zurn:sha1:2e496795b0583ff5d09e436ac7b00eb18beea1f0
This deduplicates some docs and eliminates the two wrapper functiosn
for `run_handshake`, which is now just `handshake`.
We're going to make other API breaks too, and this isn't going to be
the primary API, so we might as well do this.
Proper description of the semver breakage will come at the end when
it's all done.