mirrors/arti.git/crates/tor-socksproto/src/handshake.rs, branch derive-traits

Merge branch 'error-socksproto-autoconvert' into 'main'

2022-02-14T20:57:24Z

Provide, and use From impl for InternalError See merge request tpo/core/arti!315

Run rustfmt.

2022-02-14T19:47:42Z

Provide, and use From impl for InternalError

2022-02-14T18:48:35Z

Adding this autoconversion is quite safe since every error generation site is explicit and has its own context, and we don't really need to add more. This simplifies the code and will simplify future work.

ErrorKind::NotImplemented: fix two tests

2022-02-14T17:54:05Z

Split up ErrorKind::NoSupport

2022-02-14T16:06:45Z

socksproto: Simplify Truncated handling

2022-02-11T14:36:57Z

Refactor the Error type to remove the yucky internal hidden Truncated variant. Instead, there's now an embedded tor_bytes::Error value. If that tor_bytes::Error is Truncated, we bubble it up when we convert our handshake result to the nested error struct. Thus there is still (sadly) a variant of tor_socksproto::Error that shouldn't be exposed to user code. But refactoring every inner method under handshake.rs seemed like a bad idea: once we're using Result>, the ? operator no longer helps us much.

Move the Truncated error into tor-errors.

2022-02-11T14:36:57Z

Try to resolve the "Truncated" error in tor-socksproto

2022-02-11T14:36:57Z

I'm not in love with this solution; the others just seem a bit ugly too.

tor-socksproto: Implement HasKind

2022-02-11T14:36:57Z

(This error isn't yet wrapped in TorError, but it will be eventually when we implement socks proxy and PT support.)

Idle hacking to get tor-socksproto line coverage over 90%

2021-12-02T23:52:58Z

This was just a matter of adding a call to one function.