mirrors/arti.git/crates/tor-socksproto/src/err.rs, branch arti-v0.4.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-02-15T11:40:24Z tor-socksproto: Use bad_api_usage! rather than ad-hoc Invalid error 2022-02-15T11:40:24Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T16:54:53Z urn:sha1:97a0a7359bb57cfde916dd87a1e54032b811fd36 Make Bug from InternalError, add bad_api_usage! and into_bad_api_usage! 2022-02-15T11:40:24Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T18:31:45Z urn:sha1:b8f928e4f5cec07c8dff1de9f1c6f09b8dc17efc Including supporting machinery, new kind field, etc. New name and semantics for BadAPIUsage (was BadArgument) 2022-02-15T11:32:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T15:48:07Z urn:sha1:5d87ca8ad748e4b20a8f089f6f4e94fc4120a0f9 Merge branch 'error-socksproto-autoconvert' into 'main' 2022-02-14T20:57:24Z Nick Mathewson nickm@torproject.org 2022-02-14T20:57:24Z urn:sha1:e80d472beb3de3160a1cda2edcae210532ff4f15 Provide, and use From impl for InternalError See merge request tpo/core/arti!315 Merge remote-tracking branch 'origin/mr/313' 2022-02-14T19:25:28Z Nick Mathewson nickm@torproject.org 2022-02-14T19:25:28Z urn:sha1:e4321bbae202dee9ae55fa785efa862fa3b0d8a4 Merge branch 'error-kind-protocol' into 'main' 2022-02-14T19:07:00Z Ian Jackson iwj@torproject.org 2022-02-14T19:07:00Z urn:sha1:8db7ab8148bfc8eeed3f7badb3c2d72fbd69e773 Split up ErrorKind::ProtocolViolation See merge request tpo/core/arti!312 Provide, and use From impl for InternalError 2022-02-14T18:48:35Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T18:48:35Z urn:sha1:4774cbd18d06b2c3d6ece16784275b1d1a435fdc Adding this autoconversion is quite safe since every error generation site is explicit and has its own context, and we don't really need to add more. This simplifies the code and will simplify future work. Split up ErrorKind::ProtocolViolation 2022-02-14T17:55:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T16:09:39Z urn:sha1:4d14398fe19163812f0eb7b1d196803795d9a95f tor_socksproto::Error HasKind fix two delegations 2022-02-14T17:46:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T17:46:19Z urn:sha1:02959576bb034e38f4757aeeb0205b6aed968258 We should not generally explicitly specify a kind for errors which contain a more detailed error which itself has a kind. Stating the kind literally is a latent bug, which becomes a real bug if the contained type's kind changes or starts to vary. (There may be exceptions to this principle but this isn't one of them.) Split up ErrorKind::NoSupport 2022-02-14T16:06:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-14T15:58:23Z urn:sha1:30ebb1358ad4be7b804f9c5824d1a05e853e6f69