mirrors/arti.git/crates/tor-rtmock/src/net.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-08-23T09:34:00ZRun maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Add exceptions for some cases of diverging_sub_expression2023-07-10T11:33:21ZNick Mathewsonnickm@torproject.org2023-07-07T18:17:52Zurn:sha1:0b6cc7ba5ed6962bb6cf568a8bdc788de4c329f6
See here for documentation on the lint:
https://rust-lang.github.io/rust-clippy/master/index.html#/diverging_sub_expression
The issue here, from what I can tell, is that the lint triggers
whenever you use a diverging expression as a function body within an
tor-rtmock: Net: Make UDP sockets un-constructable2023-07-06T14:14:41ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-06T11:56:44Zurn:sha1:55329fe85b204c86f182d94a20a2e112b7cf894a
This will hopefully mean anyone trying to use this will notice that
it's not implemented.
Prompted by:
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1375#note_2919925
tor-rtmock: impl Default for MockNetProvider2023-07-06T14:14:40ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-05T10:34:13Zurn:sha1:70fdd920304a167cb21eb07ca9ee323582a98df9tor-rtmock: impl Default for MockNetProvider (prep)2023-07-06T14:14:40ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-05T10:33:37Zurn:sha1:24da490ef57faacf6d1eb066334bb0d189e08b0e
We want MockNetProvider to be Default.
In this commit: impl Default for MockNetwork and use it in new().
tor-rtmock: net: "Provide" a UDP "implementation" which doesn't work2023-07-06T14:14:40ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-05T11:28:41Zurn:sha1:395a616c9f1a513c2905548aa13d5345cd1b937c
Nothing in our tree actually *uses* the UDP in tests.
We want a mock UDP provider that isn't part of a real runtime, so that
we can make a totally-mock runtime for properly controlled testing.
It seems best to make this part of MockNetProvider rather than a
separate type.
Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
test lint blocks: Add many many automatically2022-12-12T18:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-12-12T17:58:40Zurn:sha1:125a455bdcca841931f33f83f206e57637ae85c4
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
Improve documentation around Cargo features; make Runtime require Debug2022-05-11T12:26:35Zetator@eta.st2022-05-11T12:26:35Zurn:sha1:864fd03917a0409c6a0380c258d96252359a559b
- arti#445 highlighted the lack of good documentation around Arti's
multiple runtime support, as well as it being difficult to determine
what runtime was actually in use.
- Improve the documentation to solve the first problem.
- To solve the second problem, make Runtime require Debug (which is
arguably a good idea anyway, since it makes them easier to embed in
things), and print out the current runtime's Debug information when
arti is invoked with `--version`.
- (It also prints out other Cargo features, too!)
fixes arti#445