mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.4 2022-01-27T20:52:59Z 2022-01-27T20:52:59Z Nick Mathewson nickm@torproject.org 2022-01-27T20:52:59Z urn:sha1:19f878b3aa7b648605487f94871ab3e5c5b949fd Nothing actually used these accessor functions, and it's not clear what would. We can add them later if they're needed. 2022-01-27T20:48:30Z Nick Mathewson nickm@torproject.org 2022-01-27T20:48:30Z urn:sha1:f7373f8b2001d90a63ca08c799e9f47e8f94144d These probably aren't for things that will fail IRL, but it's nice to have coverage on the code, just in case. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T18:59:37Z urn:sha1:bf8fa66d36298561cc868706f748049cec23f5eb This avoids a future confusion with the new `SpawnBlocking` trait in async_executors v0.5, and better describes what the trait provides. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T15:53:06Z urn:sha1:30b3818a9e31b0ebe96d4a32aa9bceb16610f994 This commit puts the native-tls crate behind a feature. The feature is off-by-default in the tor-rtcompat crate, but can be enabled either from arti or arti-client. There is an included script that I used to test that tor-rtcompat could build and run its tests with all subsets of its features. Closes #300 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-25T22:22:14Z urn:sha1:05a04220ccc4d0dcbab906db42abc97bad02f222 If we implement our own clone on CompoundRuntime, we no longer need Clone implementations on our TlsProvider implementations. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-25T22:58:44Z urn:sha1:99c59a8f2b3d1d97110ecdfc1021668f88177c85 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-25T21:52:33Z urn:sha1:668364d75d5fec06d235a684dfc6c8c89e543503 Having separate types here doesn't justify the (very limited) benefit of distinguishing between the case where we have created an executor that we own and the case where we have a handle to an already-running tokio executor. Part of #301. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-25T18:05:37Z urn:sha1:e4e691a790dc1dfe5b45261a40674a927085c206 Also, more comments on why these limitations are safe within the context of Tor, but you wouldn't want to use them elsewhere. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-24T20:12:49Z urn:sha1:d1d121aac6c6dd5bd0b31ef6e01614da36071221 This change uses the async-native-tls crate for everything, and deletes some duplicated code. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-21T14:28:11Z urn:sha1:8def5a0d89603c8f1cfd91109bb439f1881d968f This is based on @janimo's approach in !74, but diverges in a few important ways. 1. It assumes that something like !251 will merge, so that we can have separate implementations for native_tls and rustls compiled at the same time. 2. It assumes that we can implement this for the futures::io traits only with no real penalty. 3. It uses the `x509-signature` crate to work around the pickiness of the `webpki` crate. If webpki eventually solves their [bug 219](https://github.com/briansmith/webpki/issues/219), we can remove a lot of that workaround. Closes #86.