mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits 2022-01-27T20:52:59Z 2022-01-27T20:52:59Z Nick Mathewson nickm@torproject.org 2022-01-27T20:52:59Z urn:sha1:19f878b3aa7b648605487f94871ab3e5c5b949fd Nothing actually used these accessor functions, and it's not clear what would. We can add them later if they're needed. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T18:59:37Z urn:sha1:bf8fa66d36298561cc868706f748049cec23f5eb This avoids a future confusion with the new `SpawnBlocking` trait in async_executors v0.5, and better describes what the trait provides. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-25T22:58:44Z urn:sha1:99c59a8f2b3d1d97110ecdfc1021668f88177c85 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-25T21:52:33Z urn:sha1:668364d75d5fec06d235a684dfc6c8c89e543503 Having separate types here doesn't justify the (very limited) benefit of distinguishing between the case where we have created an executor that we own and the case where we have a handle to an already-running tokio executor. Part of #301. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-24T20:12:49Z urn:sha1:d1d121aac6c6dd5bd0b31ef6e01614da36071221 This change uses the async-native-tls crate for everything, and deletes some duplicated code. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-21T14:28:11Z urn:sha1:8def5a0d89603c8f1cfd91109bb439f1881d968f This is based on @janimo's approach in !74, but diverges in a few important ways. 1. It assumes that something like !251 will merge, so that we can have separate implementations for native_tls and rustls compiled at the same time. 2. It assumes that we can implement this for the futures::io traits only with no real penalty. 3. It uses the `x509-signature` crate to work around the pickiness of the `webpki` crate. If webpki eventually solves their [bug 219](https://github.com/briansmith/webpki/issues/219), we can remove a lot of that workaround. Closes #86. 2022-01-19T20:47:26Z Nick Mathewson nickm@torproject.org 2022-01-19T19:12:08Z urn:sha1:17920e43f84fd6c4c3f9abe77c7b477d6c17602c This will make it easier to implement them using some other TLS provider as well, without having to duplicate all of our code. 2021-12-07T17:00:40Z eta tor@eta.st 2021-12-02T11:44:29Z urn:sha1:b14c5f370eef0a4fc1d2504ce54de1a921472567 `tor-rtcompat`'s `TlsConnector` trait previously included a method to create a TLS-over-TCP connection, which implied creating a TCP stream inside that method. This commit changes that, and makes the function wrap a TCP stream, as returned from the runtime's `TcpProvider` trait implementation, instead. This means you can actually override `TcpProvider` and have it apply to *all* connections Arti makes, which is useful for issues like arti#235 and other cases where you want to have a custom TCP stream implementation. This required updating the mock TCP/TLS types in `tor-rtmock` slightly; due to the change in API, we now store whether a `LocalStream` should actually be a TLS stream inside the stream itself, and check this property on reads/writes in order to detect misuse. The fake TLS wrapper checks this property and removes it in order to "wrap" the stream, making reads and writes work again. 2021-09-07T12:44:47Z Nick Mathewson nickm@torproject.org 2021-09-07T12:44:47Z urn:sha1:bd2c9fd8c139303ff2965843c6e952e6ae152149 (The nightly version of clippy now includes macros for its missing_docs_in_private_items lint.) 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.