mirrors/arti.git/crates/tor-rtcompat/src/impls/streamops.rs, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-04-09T16:25:51ZAllow StreamOps import to be unused2025-04-09T16:25:51ZNick Mathewsonnickm@torproject.org2025-04-09T16:25:51Zurn:sha1:f79bb13bbd55957a8e67725455cc8460f5064ee0
This comes up on OSX; I hadn't seen it before, so I assume it is new
with Rust 1.86.
tor-rtcompat: Fix doc warning.2025-01-15T13:49:17ZGabriela Moldovangabi@torproject.org2025-01-09T13:33:20Zurn:sha1:b900e8b9e874498b37bede2d91ef2abfe71f6921tor-rtcompat: Add the ability to get a StreamOps handle.2025-01-15T13:49:17ZGabriela Moldovangabi@torproject.org2025-01-08T11:06:59Zurn:sha1:267235969df65d975b5deb01c342e1073d4c3847
Needed for cases where we wrap an object that implements `StreamOps` in
an external type, thereby losing access to the `StreamOps`
functionality. For example, during the channel handshake, we `.split()`
the stream that implements `StreamOps`, which leaves us with a
`SplitSink` and a `SplitStream`, neither of which implement `StreamOps`.
Getting a handle to the underlying object that implements `StreamOps`
(for example, a file handle) *before* the stream is `.split()` enables
us to use `StreamOps` to manipulate the underlying split stream.
This commit also introduces a special `UnsupportedStreamOpsHandle`,
which is a type that implements `StreamOps`, but always returns an
error. This type is meant to simplify error handling and usage, and is
meant to be used in cases where `StreamOps` is not supported. TODO: the
name of this type is pretty confusing (it's very similar to
`UnsupportedStreamOp`, which is an error type), and should probably be
renamed to something else (`NoOpStreamOpsHandle`,
`BrokenStreamOpsHandle`, `DummyStreamOpsHandle` come to mind...).
Note: this changes the `StreamOps` trait to be slightly different from
what I originally envisioned in !2660 and #1769
streamops: Resolve unused-variable warnings.2024-12-12T17:11:52ZNick Mathewsonnickm@torproject.org2024-12-12T17:11:52Zurn:sha1:3bd5afbeb2bb67804781cd0afce1eab9594571c7tor-rtcompat: Replace bad_api_usage with UnsupportedStreamOp (fmt).2024-12-10T10:34:48ZGabriela Moldovangabi@torproject.org2024-12-09T17:02:08Zurn:sha1:b4bbf07cad23c3d3b0cf57d77b89dc75e0420db3tor-rtcompat: Replace bad_api_usage with UnsupportedStreamOp.2024-12-10T10:34:48ZGabriela Moldovangabi@torproject.org2024-12-09T15:27:37Zurn:sha1:2d40f6cbc12543c068764bcaed2bdf3e2c556550tor-rtcompat: Add tests for set_tcp_notsent_lowat.2024-12-10T10:34:48ZGabriela Moldovangabi@torproject.org2024-12-09T12:04:13Zurn:sha1:edd0b0ead79aa3e40f9f96348d99f98504d21ac0tor-rtcompat: Implement StreamOps for all the stream types.2024-12-10T10:34:48ZGabriela Moldovangabi@torproject.org2024-12-05T15:00:11Zurn:sha1:56e9b79b09c65caee25a50c083fdd40f8c66f040
Part of #1769