mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.4 2022-01-27T20:48:30Z 2022-01-27T20:48:30Z Nick Mathewson nickm@torproject.org 2022-01-27T20:48:30Z urn:sha1:f7373f8b2001d90a63ca08c799e9f47e8f94144d These probably aren't for things that will fail IRL, but it's nice to have coverage on the code, just in case. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T18:59:37Z urn:sha1:bf8fa66d36298561cc868706f748049cec23f5eb This avoids a future confusion with the new `SpawnBlocking` trait in async_executors v0.5, and better describes what the trait provides. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T18:27:42Z urn:sha1:dec2c4ee639c3a3584f416116f286231d0a59df8 This took some refactoring, so that I wouldn't need to define 9 different versions of the function. It also required that we change the behavior of test_with_all_runtimes slightly, so that it asserts on _any_ failure rather than asserting on most but returning Err() for others. That in turn required changes to a few of its callers. There's probably a better way to do all of this macro business, but this is the best I could find. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T15:53:06Z urn:sha1:30b3818a9e31b0ebe96d4a32aa9bceb16610f994 This commit puts the native-tls crate behind a feature. The feature is off-by-default in the tor-rtcompat crate, but can be enabled either from arti or arti-client. There is an included script that I used to test that tor-rtcompat could build and run its tests with all subsets of its features. Closes #300 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T14:52:43Z urn:sha1:8af3528cd3d90a3aa827a5a9464c686c9250eb78 This helps us simplify our code in a few ways, and will help even more once native_tls is optional. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T13:40:35Z urn:sha1:6f29d485e460b30cba992bcb407bf3c7e2a479b7 This should help avoid some amount of temptation towards API proliferation. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T13:16:39Z urn:sha1:2333d0466e482810dbe91a6c17f6b363d7956f36 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-24T20:12:49Z urn:sha1:d1d121aac6c6dd5bd0b31ef6e01614da36071221 This change uses the async-native-tls crate for everything, and deletes some duplicated code. 2022-01-25T18:16:39Z Nick Mathewson nickm@torproject.org 2022-01-21T14:28:11Z urn:sha1:8def5a0d89603c8f1cfd91109bb439f1881d968f This is based on @janimo's approach in !74, but diverges in a few important ways. 1. It assumes that something like !251 will merge, so that we can have separate implementations for native_tls and rustls compiled at the same time. 2. It assumes that we can implement this for the futures::io traits only with no real penalty. 3. It uses the `x509-signature` crate to work around the pickiness of the `webpki` crate. If webpki eventually solves their [bug 219](https://github.com/briansmith/webpki/issues/219), we can remove a lot of that workaround. Closes #86. 2022-01-19T20:47:26Z Nick Mathewson nickm@torproject.org 2022-01-19T19:12:08Z urn:sha1:17920e43f84fd6c4c3f9abe77c7b477d6c17602c This will make it easier to implement them using some other TLS provider as well, without having to duplicate all of our code.