mirrors/arti.git/crates/tor-rpcbase, branch arti-v1.2.6

Bump versions for tor- and arti- crates to 0.21.0

2024-08-01T15:09:32Z

This is the result of: ``` for crate in $( ./maint/list_crates |grep '^$tor\|arti-$' ); do cargo set-version -p $crate 0.21.0 done ```

rpc: Remove special conversion for SendUpdateError.

2024-07-25T12:46:29Z

rpc: Rename the error codes for something like consistency.

2024-07-25T12:46:29Z

rpc: Remove RpcError data field and use Report

2024-07-25T12:46:29Z

Per discussion, this field isn't really specified in a way that lets us fill it sensibly at the moment. So for now, we're going to just omit it. Additionally, we said that we'd Report on our errors; this branch changes the implementation of RpcError to do that. Question: Will the blanket implementation for Into make it harder to re-add a Data field later on if we want to do so?

rpc: Refactor errors part 1: a new RpcMethod trait.

2024-07-25T12:43:30Z

It is no longer necessary to say, for every RPC method, that its error type is RpcError.

rpcbase: remove now-unused invoke methods

2024-07-25T12:43:30Z

These methods were defined on DispatchTable, and then replaced by top-level functions in the crate. (The reason for using top-level functions instead is so that we get the locking on the dispatch table correct.)

rpcbase: Remove a TODO RPC about duplication

2024-07-25T12:43:30Z

The duplication is only a few lines. I've looked into a couple of ways for removing it, but they make the code flow even less clear.

rpcbase: Replace a TODO with a set of notes and caveats

2024-07-25T12:43:30Z

We have decided not to remove the "anybody can define methods" property. This commit documents the consequences, and warns extenders away from some really bad ideas.

rpc: remove TODO about adding an extension trait

2024-07-25T12:43:30Z

These functions are called rarely enough that it is probably okay for the ergonomics to be a bit verbose.

rpc: Remove TODO about moving @special to a different macro.

2024-07-25T12:43:30Z