mirrors/arti.git/crates/tor-rpcbase/src/obj, branch arti-v1.1.9

Run maint/add_warning to add lint block everywhere

2023-08-23T09:34:00Z

Fix typos

2023-07-22T07:10:34Z

Run maint/add_warning to actually apply new lint allows

2023-07-10T12:49:51Z

rpc: Remove some verbiage about 'static, and demo that it's OK without

2023-06-15T11:07:11Z

It's now not actually possible to write code that doesn't work, even if `Tr` *isn't* 'static, because of the bounds on `CastTable::insert`. I tried to produce a non-working setup with a non-static `Simple`, but you can't implement `Object` for such a thing. Removing 'static from Object would stop the downcasts from Any to Object working. Prior to the new typesafe insert, this change - let f: fn(&dyn $crate::Object) -> &(dyn $traitname + 'static) = |self_| { + let f: fn(&dyn $crate::Object) -> &(dyn $traitname) = |self_| { would result in a runtime crash. Now it results in a compiler error.

rpc: Give the name `O` to "the type associated with this CastTable"

2023-06-15T11:03:53Z

This was locally bound to `S` in one place. Bind and use it throughout. Since this is an RPC object, `O` is a better name. In each item, use the description once and thereafter just the name.

rpc: Add Simple test case for CastTable

2023-06-15T11:03:53Z

rpc: Move boxing from macro to CastTable::insert (formatting)

2023-06-15T11:03:53Z

rpc: Move boxing from macro to CastTable::insert

2023-06-15T10:32:32Z

rpc: Make CastTable::insert be more type-safe

2023-06-15T10:13:26Z

This checks the Requirements.

RPC: Functionality to downcast dyn Object to a dyn Trait.

2023-06-12T17:35:28Z

This is a rather tricky piece of functionality. It works as follows. We introduce a `CastTable` type. Each `CastTable` tells us how to downcast `dyn Object` for objects of a single concrete type. The `Object` type now has a `get_casttable` method that returns an empty `CastTable` by default. `CastTable` is, internally, a map from the `TypeId` of the target dyn Trait reference type to a function `fn(&dyn Object) -> &dyn Trait`. These functions are stored as `Box`. (They are Boxed because they may refer to generic functions, which you can't get a static reference to, and they're Any because the functions have different types.) The `decl_object!` macro now implements `get_casttable` as appropriate. (The syntax is a bit janky, but that's what we get for not using derive_adhoc.) For non-generic types, `get_casttable` uses a Lazy`. to initialize a CastTable exactly once. For generic types, it use a `Lazy>` to build one CastTable per instantiation of the generic type. This could probably be optimized a bit more, the yaks could be shaved in a more scintillating hairstyle, and the syntax for generic `decl_object` could definitely be improved.