mirrors/arti.git/crates/tor-rpcbase/src/obj/cast.rs, branch tor-circmgr-v0.18.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-circmgr-v0.18.1 2024-04-11T12:56:53Z rpc: Move deftly attributes into an `rpc` namespace. 2024-04-11T12:56:53Z Nick Mathewson nickm@torproject.org 2024-04-11T12:56:53Z urn:sha1:f96ca62bed8bd1ab42fc069331aef049e9c4515e Port many of the macros in tor-rpcbase to use derive-deftly. 2024-04-04T20:42:57Z Nick Mathewson nickm@torproject.org 2024-04-04T20:04:39Z urn:sha1:66cfabc442bfc1779a4748b89d0be2d51f908fc9 This simplifies our implementation logic in a few places, and simplifies our invocation syntax greatly. There are a few infelicities, noted in `TODO RPC` comments. Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Fix typos 2023-07-22T07:10:34Z Dimitris Apostolou dimitris.apostolou@icloud.com 2023-07-22T07:10:34Z urn:sha1:947ddfff0cfac3fef0e3d7ebc14182c638a1d90b Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 rpc: Remove some verbiage about 'static, and demo that it's OK without 2023-06-15T11:07:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-15T10:29:26Z urn:sha1:1710ce54f4d3c731328491718cc70f0d92639670 It's now not actually possible to write code that doesn't work, even if `Tr` *isn't* 'static, because of the bounds on `CastTable::insert`. I tried to produce a non-working setup with a non-static `Simple`, but you can't implement `Object` for such a thing. Removing 'static from Object would stop the downcasts from Any to Object working. Prior to the new typesafe insert, this change - let f: fn(&dyn $crate::Object) -> &(dyn $traitname + 'static) = |self_| { + let f: fn(&dyn $crate::Object) -> &(dyn $traitname) = |self_| { would result in a runtime crash. Now it results in a compiler error. rpc: Give the name `O` to "the type associated with this CastTable" 2023-06-15T11:03:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-15T10:36:36Z urn:sha1:0eedf0e2548587b77295ba8180fd926d8eee3ee1 This was locally bound to `S` in one place. Bind and use it throughout. Since this is an RPC object, `O` is a better name. In each item, use the description once and thereafter just the name. rpc: Add Simple test case for CastTable 2023-06-15T11:03:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-15T10:28:51Z urn:sha1:2228751a007aeab35f40c97174520e0268469e5d rpc: Move boxing from macro to CastTable::insert (formatting) 2023-06-15T11:03:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-15T11:03:43Z urn:sha1:54b364cdcf324200c0dbfdc0012f7397510874ec