mirrors/arti.git/crates/tor-rpcbase/src/method.rs, branch arti-v1.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.02024-10-24T01:35:05Zrpc: Simplify method-dispatch-bypass logic a bit2024-10-24T01:35:05ZNick Mathewsonnickm@torproject.org2024-10-24T00:33:55Zurn:sha1:eb1d9acd10c5d500f56d637a7bba3acdd67dc9e8
This commit removes the separate function for asking whether to
bypass the dispatch code. Instead, it gives the "invoke with
bypass" function an error to return when no dispatch is warranted,
and moves the whole responsibility for method dispatch or
non-dispatch back into tor-rpcbase.
I had to add an ObjectId argument to `invoke_rpc_method` to make
this work, but that's probably a good thing.
Additionally, this commit tweaks the derive-deftly macro to prevent
you from asking for dispatch bypass on special methods, where it
isn't implemented (and doesn't really make sense).
rpc: Add a mechanism for method that bypass regular dispatch2024-10-24T01:35:05ZNick Mathewsonnickm@torproject.org2024-10-22T13:50:00Zurn:sha1:d6367f61169fd21830aeb37d8952b9f6792cb115
I'm about to use this for rpc:release, which is special
because it doesn't actually look at the type of the object that it's
invoked on. Later it might be useful for manipulating weakrefs,
cloning referenes, detecting reference equality, etc.
rpcbase: Facility for looking up RPC method information2024-08-13T00:19:20ZNick Mathewsonnickm@torproject.org2024-08-12T14:09:54Zurn:sha1:5883a585d74e2e95a13fd804b3281f72dd57525b
We'll need this to refer to the names of RPC methods as visible to
the caller, and to cross-reference them with their related types.
rpc: Refactor errors part 1: a new RpcMethod trait.2024-07-25T12:43:30ZNick Mathewsonnickm@torproject.org2024-07-23T17:23:58Zurn:sha1:c7c630c44d9e937d7185f591d75fd42c33ab5238
It is no longer necessary to say, for every RPC method,
that its error type is RpcError.
rpcbase: Replace a TODO with a set of notes and caveats2024-07-25T12:43:30ZNick Mathewsonnickm@torproject.org2024-07-23T14:20:15Zurn:sha1:593e0dfbc0da6ef4d3ed6e403122b178432eb571
We have decided not to remove the "anybody can define methods"
property. This commit documents the consequences, and warns
extenders away from some really bad ideas.
rpc: Tests for method name checking.2024-07-15T15:30:52ZNick Mathewsonnickm@torproject.org2024-07-15T15:30:52Zurn:sha1:45941b5fff66036a0833e21bb929bb19fef8a25aChange deftly syntax to post 0.12.1 version2024-06-17T18:13:06ZIan Jacksonijackson@chiark.greenend.org.uk2024-06-17T17:33:09Zurn:sha1:dddf07561868579ea687eeadaa8f863aa833c764
* Change `pub` to `export`
* Change the `=` in define to `:`
* Change `pub_template_semver_check` to `template_export_semver_check`
Right now, 0.12.1 supports both syntaxes. I have verified this branch
also compiles with
https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/merge_requests/402
ee171ffaf56d7dcb7d75584054921153fe19b222
Add a few "TODO RPC" notes2024-05-16T12:40:06ZNick Mathewsonnickm@torproject.org2024-05-16T12:35:18Zurn:sha1:854b1507c95ca7edde01c545b0c7375912168944RPC: Fill in documentation about invoke_special2024-05-16T12:40:06ZNick Mathewsonnickm@torproject.org2024-05-14T18:45:48Zurn:sha1:69510aaa1750362d6df9d7e92b9b139d70071e17RPC: Require an Error type in methods.2024-05-16T12:40:06ZNick Mathewsonnickm@torproject.org2024-05-14T18:19:30Zurn:sha1:98765e5a4cdf70356db38d324b0896d2b6f83c2f
This is needed so that we can cast special methods' return types
properly.
I wish I could make this optional, but Rust doesn't allow
defaulting an associated type.