mirrors/arti.git/crates/tor-rpcbase/src/lib.rs, branch arti-v1.4.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.22025-01-28T18:54:01ZMerge branch 'rpc-references-cleanup' into 'main'2025-01-28T18:54:01ZNick Mathewsonnickm@torproject.org2025-01-28T18:54:01Zurn:sha1:77b47ae94f8d525f55ecf0f962fc7159f0aa521b
rpc: Move support for weak references behind an experimental feature
See merge request tpo/core/arti!2742Merge branch 'strongrefs_are_not_deduped' into 'main'2025-01-28T13:22:09ZNick Mathewsonnickm@torproject.org2025-01-28T13:22:09Zurn:sha1:b0d75277c2f17acca97963685a6e223d5b67393f
rpc: Clean up comments surrounding strong references
See merge request tpo/core/arti!2741rpcbase: Make recognized namespace list optional.2025-01-27T21:10:47ZNick Mathewsonnickm@torproject.org2025-01-27T18:39:00Zurn:sha1:1d251c1e685b5c5afc4666e75293b62e8619d958rpcbase: Move is_valid_rpc_identifier to crate root.2025-01-27T21:10:47ZNick Mathewsonnickm@torproject.org2025-01-27T18:36:39Zurn:sha1:685702a9055459641dac6b830ceacff244f0f5acrpc: Move support for weak references behind an experimental feature2025-01-27T19:51:16ZNick Mathewsonnickm@torproject.org2025-01-27T19:11:34Zurn:sha1:31be122e79a2dc66209cd6077d09839f2de8298e
We haven't decided how these should work (see #868), so having them
present by default is a bad idea.
rpc: Clean up comments surrounding strong references2025-01-27T19:49:13ZNick Mathewsonnickm@torproject.org2025-01-27T19:49:13Zurn:sha1:4709e6891629fcd2c8ae4cd767494a6597bf519e
They used to be deduplicated, but they haven't been for a while.
rpc: Rename InvalidMethodName to InvalidRpcIdentifier.2025-01-27T18:33:33ZNick Mathewsonnickm@torproject.org2025-01-27T18:33:33Zurn:sha1:ee9c39ba6e35769a21d3010e44124d59206009b4
We're about to use this error type for other things too.
clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
add_warnings, *: Allow clippy::needless_lifetimes2024-12-03T14:27:26ZNick Mathewsonnickm@torproject.org2024-12-03T14:15:50Zurn:sha1:64cc3f2ed3eea0b7c5cc89ae07cbdadfdc1646fb
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
rpc: Simplify method-dispatch-bypass logic a bit2024-10-24T01:35:05ZNick Mathewsonnickm@torproject.org2024-10-24T00:33:55Zurn:sha1:eb1d9acd10c5d500f56d637a7bba3acdd67dc9e8
This commit removes the separate function for asking whether to
bypass the dispatch code. Instead, it gives the "invoke with
bypass" function an error to return when no dispatch is warranted,
and moves the whole responsibility for method dispatch or
non-dispatch back into tor-rpcbase.
I had to add an ObjectId argument to `invoke_rpc_method` to make
this work, but that's probably a good thing.
Additionally, this commit tweaks the derive-deftly macro to prevent
you from asking for dispatch bypass on special methods, where it
isn't implemented (and doesn't really make sense).