mirrors/arti.git/crates/tor-rpcbase/src/lib.rs, branch arti-v1.2.6

rpc: Remove special conversion for SendUpdateError.

2024-07-25T12:46:29Z

rpc: Remove RpcError data field and use Report

2024-07-25T12:46:29Z

Per discussion, this field isn't really specified in a way that lets us fill it sensibly at the moment. So for now, we're going to just omit it. Additionally, we said that we'd Report on our errors; this branch changes the implementation of RpcError to do that. Question: Will the blanket implementation for Into make it harder to re-add a Data field later on if we want to do so?

rpc: Refactor errors part 1: a new RpcMethod trait.

2024-07-25T12:43:30Z

It is no longer necessary to say, for every RPC method, that its error type is RpcError.

rpcbase: remove now-unused invoke methods

2024-07-25T12:43:30Z

These methods were defined on DispatchTable, and then replaced by top-level functions in the crate. (The reason for using top-level functions instead is so that we get the locking on the dispatch table correct.)

rpc: remove TODO about adding an extension trait

2024-07-25T12:43:30Z

These functions are called rarely enough that it is probably okay for the ergonomics to be a bit verbose.

rpcbase: remove "Nil" TODO.

2024-07-25T12:43:30Z

This change would take some serde magic that is probably not worth it.

rpcbase: tests for crate-level invoke functions.

2024-07-16T00:17:38Z

rpc: Add RPC method invocation based on Context, not dispatch table.

2024-06-10T14:33:01Z

Doing it this way will allow us to invoke methods without holding the read lock on the table, implicitly or via the future. I am not yet removing the methods on DispatchTable, since the tests need them; I've added TODOs to revisit and remove later.

rpc: Pass around our rpc::Context in an Arc.

2024-06-10T14:33:01Z

Formerly we used a Box. That was okay at first, but now that we want RPC methods to be able to invoke other RPC methods, we don't want the Invocable methods to have to consume the Context. This requires that Context become Sync.

RPC: Expose dispatch table from Context

2024-05-16T12:40:06Z

We need to do this so that we can actually invoke RPC functions from one another.