mirrors/arti.git/crates/tor-relay-selection/src, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Allow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Run script to add new warning2026-01-27T18:05:36ZGabriela Moldovangabi@torproject.org2026-01-27T18:05:36Zurn:sha1:a98faf72eb06b47700faeeac5a8a0dd0fc29b584
This adds the lint to all our crates.
RelayFlags: Use RelayFlag enum variant names everywhere2025-11-18T19:50:23ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T18:55:10Zurn:sha1:c37e44403416b7f1abbd62d080b698da35d04537
Abolish the constants with the transitional names.
This also abolishes the controversial name `H_S_DIR`, which Rust case
transformation rules generated from `HSDir`.
RelayFlags: Use the singular RelayFlag for naming individual flags2025-11-18T19:44:21ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T18:36:08Zurn:sha1:3245738729e1d93be48485f2877a9e17ba2e7f28
We're going to separate RelayFlag from RelayFlags.
We could continue to provide a bunch of constant values for
RelayFlags, for each individual type, but that would involve an ad-hoc
derive, and would still be a bit of an unusual API.
Instead, we're going to make ``RelayFlag` a normal enum.
In this commit, we change everyone to refer to it by its singular
name. Hopefully separating out this bulk change makes both this, and
the core commit, easier to review.
tor-netdoc: Remove the RelayFlags type alias in netstatus2025-11-18T17:06:51ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-10T14:52:43Zurn:sha1:3ecd75a43c41a57288abe0a7da23a80ec89d23e0
I would do `#[deprecated]` but empirically that has no effect...
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
tor-linkspec: Change HasAddrs::addrs to return an Iterator2025-10-06T18:52:44ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-01T11:56:57Zurn:sha1:dc9ff7b72e6a5f6746c5b6a6a6c50673d1c46688
This will let us model the actual structure of routerstatus entries in
netdocs more closely. They don't have the addresses in a single list.
When this code was written this would have been much more awkward,
but now we have RPITIT.
Remove "doc_auto_cfg" incantation from all crates.2025-09-29T19:30:03ZNick Mathewsonnickm@torproject.org2025-09-29T18:30:14Zurn:sha1:808b0ec2e3735a6dbbebeb857a3d6040ae02c697
This feature has been removed from nightly, in favor of doc_cfg.
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.