mirrors/arti.git/crates/tor-ptmgr/src/lib.rs, branch arti-v2.5.0

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

ptmgr: Defer proxy protocol string conversion

2026-05-26T13:21:57Z

ptmgr: pass outbound_proxy to managed PT processes

2026-05-26T13:21:55Z

Previously the [channel] outbound_proxy setting was applied to Arti's own direct connections but was not forwarded to managed PT processes. https://spec.torproject.org/pt-spec/configuration-environment.html

Allow clippy::collapsible_if to trigger

2026-02-16T15:22:24Z

`clippy::collapsible_if` started triggering after bumping the MSRV to 1.88. Since this triggers from a lot of places, and since there even are a couple of instances where we explicitly allow `clippy::collapsible_ifs`, I've opened #2342 for deciding what to do about it.

relay: Add a TLS acceptor in the ChanBuilder

2026-02-09T20:49:37Z

This requires the `TlsKeyAndCert` so be passed on the TLS acceptor settings. We assume that `RelayIdentities` has this information. The ChanBuilder::new() was getting a bit too convoluted and feature gated to instead we introduce new_client() and new_relay() and remove the need for `with_identities()`. Because of this, the ChanMgr::new() now returns a `Result<>`. Related to #1597 Signed-off-by: David Goulet

maint/add_warning: Run script to add new warning

2026-01-27T18:05:36Z

This adds the lint to all our crates.

chanmgr: Get rid of the builder outbound_chan_type

2026-01-13T18:46:18Z

Instead, we'll simply use `RelayInitiator` if the identity keys (identities) struct is set. This avoids the problem where someone could call outbound_chan_type() of the ChanMgrConfig and get the wrong channel type if with_identities() is set after. This way, a single call, `with_identities()` is what will define the outbound channel type so no chance of errors. This also removes the cfg_if {} around the builder creation in a much more simplified version. Related to #1599 Signed-off-by: David Goulet

chanmgr: Add ChannelType to channel manager config

2026-01-13T18:46:17Z

This allows us to pass it to the ChanBuilder which will be able to use this type for the outbound channels. For now, we do this trick where if we have relay identities, we always consider that all outbound channels will be RelayInitiator. Signed-off-by: David Goulet

chanmgr: Remove KeyMgr from constructor

2026-01-13T18:45:24Z

We'll rely on a RelayIdentities to pass in the right keys to the ChanMgr instead of the entire KeyMgr. Signed-off-by: David Goulet

Fix name of clippy lint to unchecked_time_subtraction (2)

2025-11-06T11:28:22Z

Run maint/add_warning