mirrors/arti.git/crates/tor-ptmgr/src/lib.rs, branch arti-v1.1.7 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.7 2023-07-10T12:49:51Z Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Run add_warning to remove `missing_panics_doc` deny. 2023-07-06T18:32:23Z Nick Mathewson nickm@torproject.org 2023-07-06T18:32:23Z urn:sha1:03f9f9987a7ba42368d82363bef7f569e32ffe2c Closes #950. lints: Run maint/add_warning to actually apply new lints 2023-06-21T11:15:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-21T10:29:46Z urn:sha1:161b9844dae0aaa2e63bbc77c512d061be6bb390 Use ErrorReport for errors in error! in tor-ptmgr 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:50:36Z urn:sha1:e159bf57d219ef2b0c4d24f12c75156fac3d3e9f Disable clippy::unlinlined-format-args 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748. ptmgr: Add more logs when looking/creating a PT. 2023-01-06T17:19:00Z Nick Mathewson nickm@torproject.org 2022-12-06T13:41:00Z urn:sha1:71dfaa312500ab522b5e983602f0b1521fa265af These are also based on temporary logs that I added locally while I was hunting bugs. Also part of #677. Hang onto a PT object after it is launched 2022-11-30T19:44:14Z Nick Mathewson nickm@torproject.org 2022-11-30T19:44:14Z urn:sha1:82f877ec79c1d93233ce94dffccff8a0060764fb If we don't do this, then snowflake's stdin will get closed and it will exit immediately. Found while investigating #333. ptmgr todo: Remove dead code allow 2022-11-30T16:42:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-30T16:42:40Z urn:sha1:fa676ce577d48871bcc1cfec4328ce9b6e14b4d3 ptmgr: No need for state_dir in PtMgr 2022-11-30T16:42:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-30T16:42:18Z urn:sha1:fe331129239e203169fa32768d2e98049df78d66 This is used exclusively by the reactor.