mirrors/arti.git/crates/tor-ptmgr/src/ipc.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-07-15T18:05:29ZRemove now-unneeded allow(clippy::cognitive_complexity)2026-07-15T18:05:29ZJim Newsomejnewsome@torproject.org2026-07-15T18:05:29Zurn:sha1:e4c00405e703b6e274af2e3cfb000cab5a7c7837ptmgr: Remove string slicing.2026-06-10T17:17:33ZNick Mathewsonnickm@torproject.org2026-06-10T16:45:15Zurn:sha1:f02b2ea93fd9f1b30222cb6f51637bfef840821beverywhere: Add #[allow(clippy::string_slice)]2026-06-09T16:02:36ZClara Englercve@cve.cx2026-06-09T16:00:38Zurn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
maint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-ptmgr: port to web-time-compat.2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T14:56:27Zurn:sha1:18a08a4d616db9850c162d8f00e0b90b0f514816Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
*: suppress cognitive_complexity warnings from nightly2025-05-29T14:21:17ZNick Mathewsonnickm@torproject.org2025-05-21T14:48:35Zurn:sha1:5327d3e22a83b8469a5d4191d92e1364344ddc93
Apparently clippy nightly is better (or worse?) about detecting
complex functions than before, so I'm suppressing these warnings
where they occur.
I have mixed feelings about these warnings: On the plus side,
they really do help to detect functions that are twistier than they
need to be. On the minus side, they get confused by tracing macros,
and the "allows" do pile up. But on the plus side, those "allows"
do provide a way to find functions that need to be refactored,
and they are never uglier than the functions they decorate.
Use mpsc_channel_no_memquota next to a TODO2024-10-15T11:03:18ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-09T18:19:00Zurn:sha1:507342b2119c760e9b79182bc8bfe6a04fee5509
We have a ticket for this. But the ticket number was wrong, so fix that.
memquota: Note a TODO about PT channels2024-10-02T15:05:12ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-01T16:11:46Zurn:sha1:17b4d312c433c6afa90bb29f09bed799742d5bb4