mirrors/arti.git/crates/tor-proto, branch arti-v1.2.4

Bump all the unstable tor- and arti- crates to 0.19.

2024-06-05T15:06:54Z

The unstable crates are: - tor-error - tor-config - tor-units - tor-geoip - tor-rtcompat - tor-rtmock - tor-log-ratelim - tor-rpcbase - tor-memquota - tor-llcrypto - tor-protover - tor-bytes - tor-hscrypto - tor-socksproto - tor-checkable - tor-cert - tor-linkspec - tor-cell - tor-proto - tor-netdoc - tor-consdiff - tor-netdir - tor-relay-selection - tor-persist - tor-chanmgr - tor-ptmgr - tor-guardmgr - tor-circmgr - tor-dirclient - tor-dirmgr - tor-keymgr - tor-hsclient - tor-hsservice - tor-hsrproxy - arti-client - arti-rpcserver - arti-hyper - tor-basic-utils - tor-async-utils Done using ``` for p in "${unstable[@]}"; do cargo set-version -p $p 0.19; done ``` where `unstable` contains the list above

Merge branch 'poll-ready-unpin-bool' into 'main'

2024-05-29T18:05:57Z

Tidy up the ChannelSender::poll_ready inherent method See merge request tpo/core/arti!2171

ChannelSender::poll_ready_unpin_bool: add otiose ext trait doc

2024-05-29T12:49:33Z

proto: Try to clarify why StreamReader has a StreamTarget.

2024-05-29T11:28:05Z

proto: Add a test for closing streams.

2024-05-29T11:28:05Z

This test verifies that when we invoke the code to close a stream, an END message is actually sent. The test comes in two versions: * `drop_stream` closes the stream by dropping it. It currently passes on main. * `close_stream` closes the stream by running `AsyncWriteExt::close` on the writer. It is a regression test for #1368. It currently fails on main.

proto: Improve documentation about DataStream lifetimes and closing

2024-05-29T11:28:05Z

In particular, clarify that dropping the DataWriter on its own does nothing unless the DataReader is also dropped. Related to #1368.

proto: Make DataWriter::close actually do something.

2024-05-29T11:28:01Z

Previously we had a bug where `::close` (or `shutdown` in tokio-land) would not actually have any effect. It _would_ drop the `StreamTarget` held by the `DataWriter`, but since the `DataReader` also held a `StreamTarget`, the MPSC channel would not get closed, and the circuit reactor would not realize that the stream wanted to shut down. Now we use `mpsc::Sender::close_channel` to make our closes effectual. Closes #1368. Additionally, we fix a bug where `poll_close()` never actually did anything if the buffer had nothing in it when it was called. Previously, `poll_flush_impl()` would exit immediately if it had no data to flush. That isn't what we want when we are closing!

ChannelSender::poll_ready_unpin_bool: move to util

2024-05-29T11:16:19Z

This is where it belongs.

ChannelSender::poll_ready_unpin_bool: extension trait

2024-05-29T11:16:15Z

This makes this available for any Sink + Unpin. Which we want because we're about to wrap our ChannelSender in a Sink wrapper. It's in the wrong place now; we'll move it in a moment.

ChannelSender::poll_ready_unpin_bool: rename from poll_ready

2024-05-29T11:15:53Z

This would otherwise shadow the poll_ready method, which is confusing. Also this paves the way for making it available for any Sink + Unpin. Improve the docs somewhat to explain what this thing actually is.