mirrors/arti.git/crates/tor-proto/src, branch main

tor-proto: disable flowctrl sidechannel mitigations for relays

2026-08-19T17:29:14Z

The end result should be: 1. outgoing streams - enable sidechannel mitigations 2. incoming hs streams - enable sidechannel mitigations 3. incoming exit streams - disable sidechannel mitigations

tor-proto: add `StreamHandler::flowctrl_sidechannel_mitigations()`

2026-08-19T17:27:23Z

tor-proto: add `WithSidechannelMitigations` for flow ctrl

2026-08-19T17:21:06Z

tor-proto: make 'testing_exports' available to own unit tests

2026-08-18T18:28:07Z

This fixes: ```text $ cargo test -p tor-proto --features relay error[E0603]: enum import `CtrlMsg` is private --> crates/tor-proto/src/relay/reactor.rs:463:33 | 463 | use crate::channel::CtrlMsg; | ^^^^^^^ private enum import | note: the enum import `CtrlMsg` is defined here... --> crates/tor-proto/src/channel.rs:117:5 | 117 | use testing_exports::*; | ^^^^^^^^^^^^^^^^^^ note: ...and refers to the enum import `CtrlMsg` which is defined here... ``` There are a few ways we could fix this, but I don't see an advantage of one over another.

proto: Extend test to check DESTROY is sent to the next hop

2026-08-18T16:13:57Z

This extends the `destroy_from_client()` test to also check that a DESTROY received from the client (or, more generally speaking, from the "inbound channel") is actually forwarded to the next hop. The reason the `assert_destroy_sent()` assertion is commented out is specified in the TODO that precedes it (tldr: testing the DESTROY behaviour involves both the channel reactor and the circuit reactor, and our test setup is currently quite limited, in that it doesn't actually exercise the right channel reactor code paths for the *inbound* channel). I plan to address this soon.

proto: Move assert_cell_is_destroy macro out of helper function

2026-08-18T16:13:57Z

I am about to need this in a test.

proto: Add comments explaining why the tests use DestroyDirection::Backward

2026-08-18T16:13:57Z

proto: Remove misleading comment and rename misnamed variable

2026-08-18T16:13:57Z

This fixes an old bad copy-paste that I've just noticed.

proto: Clarify what read_{inbound,outbound} are for

2026-08-18T16:13:57Z

This adds an example suggested by opara.

proto: Update the tests to check DESTROY is only sent when needed

2026-08-18T16:13:57Z