mirrors/arti.git/crates/tor-proto/src, branch arti-v1.1.13 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.13 2024-01-17T18:27:09Z Merge branch 'send_incoming_request_failures' into 'main' 2024-01-17T18:27:09Z gabi-250 gabi@torproject.org 2024-01-17T18:27:09Z urn:sha1:572078cd57fc3a916d7d4cc9a2ad3dfcd2d13fd8 Several clean-ups around failures in incoming stream request handlers. Closes #1190, #1189, and #1188 See merge request tpo/core/arti!1892 Remove TODO for #1191 2024-01-17T16:19:54Z Nick Mathewson nickm@torproject.org 2024-01-17T16:19:54Z urn:sha1:25258bfc1061429f99a62426d41824be29d46df1 The bug described here was already fixed as #1065 via !1681. Closes #1191. proto: Use log_ratelim to report problems delivering BEGIN messges. 2024-01-17T14:25:56Z Nick Mathewson nickm@torproject.org 2024-01-17T14:25:56Z urn:sha1:c5478deab5b8bb4a1ea55946483bad948ff9eca0 Give an error on duplicate call to allow_stream_requests. 2024-01-17T14:00:34Z Nick Mathewson nickm@torproject.org 2024-01-17T14:00:34Z urn:sha1:8bff4734d70bc1260cfd5fdfb230e479b79065fc Closes #1190 proto: Close circuit _intentionally_ when Request Sink is dropped. 2024-01-17T13:45:54Z Nick Mathewson nickm@torproject.org 2024-01-17T13:45:54Z urn:sha1:163aec238f5cba8434826130d5637f6ae3a24a4b In theory, it might be better to just un-register the IncomingStreamRequestHandler when the Receiver for the stream requests is dropped. However, there are two reasons not to do so: 1. It's tricky. We never actually poll on the corresponding Sink, so there isn't a place where the Reactor would expect to get a prompt notification of closure. We only find out that the Receiver has been dropped when an attempt to send on the Sink returns an `is_disconnected` error. 2. It's unnecessary. In the Tor protocols, once we have decided to accept incoming stream requests on a circuit, we want to continue to do so until one of the parties closes the circuit. I've documented this in several comments, in case whe want to get fancier in the future. Closes #1188. proto: Send END when buffer of IncomingRequests is full 2024-01-17T13:16:48Z Nick Mathewson nickm@torproject.org 2024-01-17T13:16:48Z urn:sha1:428285a3b9df515e25a4b4265950b3a0fc788430 Closes #1189. proto: Convert a TODO HSS to ticket #1191 2024-01-10T15:04:27Z Nick Mathewson nickm@torproject.org 2024-01-10T15:04:27Z urn:sha1:ca44209c77d2c1267c3fe9e5a0fa707e88e5868b Downgrade and convert TODO HSSs to #1190. 2024-01-10T14:58:58Z Nick Mathewson nickm@torproject.org 2024-01-10T14:58:58Z urn:sha1:0c4b31b631d16baa7432822bfe0c0e969f28461d These are about making allow_incoming_streams give an error if a handler is already installed. I'm calling these non-MUST, since they don't affect the actual API here, and we already have comments telling you not to do that. We can add them later. Convert a TODO HSS about excessive BEGINs to #1189. 2024-01-10T14:53:51Z Nick Mathewson nickm@torproject.org 2024-01-10T14:53:51Z urn:sha1:862d041e2adfe633d182d97c1bf321b2af1e2f00 proto: Downgrade TODO HSS about HopNum in IncomingStreamRequestComment 2024-01-10T14:29:53Z Nick Mathewson nickm@torproject.org 2024-01-10T14:24:28Z urn:sha1:64f78cf1fea5a81578d618d20d5689ad44d89e06 These comments are about internal representations and future extensions. Also, add a fail-safe check to make sure that hop_num consistency is enforced.