mirrors/arti.git/crates/tor-proto/src, branch arti-v1.1.12

clippy: consequential rustfmt

2024-01-02T15:04:18Z

clippy nightly: For now, locally allow blocks_in_conditions

2024-01-02T15:04:18Z

Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1176 proposing a final fix.

clippy: Use infallible calls

2024-01-02T13:56:22Z

Resolves clippy complaints about needless fallible conversions.

clippy: Replace many calls to .get(0) with .first()

2024-01-02T13:56:08Z

FTR I don't think agree with clippy on this question, but then I often don't.

Rename {Any}RelayCell to {Any}RelayMsgOuter

2023-12-14T16:56:58Z

This commit is pure renaming, done automatically with rust-analyzer. Comment fixes and other cleanups will be in the subsequent commits. We're doing this renaming because we need a name for the combination of a `RelayMsg` and an `Option` that we use when we have a `RelayMsg` we intend to route to a given stream or circuit internally. Previously we called this a `RelayCell`, but that name was already somewhat inaccurate, and will become _very_ inaccurate with the arrival of prop340, which breaksthe 1:1 relationship between relay cells and relay messages. (If we didn't do this renaming now, we'd soon be making the relationship between `UnparsedRelayCell`and `RelayCell` many-to-many, which would be ridiculous and confusing.) The `RelayMsgOuter` name is a placeholder: We expect that we'll want to rename this type, and may also want to rename `RelayMsg`, and unify our vocabulary in other areas too. But such a renaming will have to wait for a larger discussion affecting the specifications, so that we can use the same vocabulary everywhere.

NtorV3Extension set encoding/decoding: include n_extensions

2023-12-07T15:45:45Z

An encoded set of extensions in the ntorv3 handshake includes a header with the number of extensions. This change adds that header. It also changes `write_many_onto` to take a slice instead of an iterator, since we need to know the number of extensions up-front. In principle we could take a clonable iterator instead and use Iterator::count, but it's probably not worth the extra complexity.

Merge branch 'semver-breaking-upgrade-of-the-daleks' into 'main'

2023-11-29T20:51:12Z

Convert to the latest versions of dalek-cryptography Closes #808 See merge request tpo/core/arti!1767

debug log: Downgrade circuit lifecycle messages to trace

2023-11-29T18:51:30Z

This makes it possible to see the wood for the trees. This may be controversial, but I think it's an improvement.

Downgrade some messages to trace

2023-11-29T18:51:30Z

These messages are very verbose and I doubt anyone will want them, usually, even when debugging.

Remove RngCompatExt.

2023-11-29T15:55:04Z

This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.)