mirrors/arti.git/crates/tor-proto/src, branch arti-v1.1.11mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.112023-11-29T20:51:12ZMerge branch 'semver-breaking-upgrade-of-the-daleks' into 'main'2023-11-29T20:51:12ZNick Mathewsonnickm@torproject.org2023-11-29T20:51:12Zurn:sha1:bdea25be86cd3e0e327d34f6748140af1c6f3b69
Convert to the latest versions of dalek-cryptography
Closes #808
See merge request tpo/core/arti!1767debug log: Downgrade circuit lifecycle messages to trace2023-11-29T18:51:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-29T18:49:27Zurn:sha1:e1b952cb964df91be6904eced2ad5120bcdc6b06
This makes it possible to see the wood for the trees.
This may be controversial, but I think it's an improvement.
Downgrade some messages to trace2023-11-29T18:51:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-11-29T18:44:06Zurn:sha1:d67519d71b2f452dcc947acc12b3bdc50e3e7920
These messages are very verbose and I doubt anyone will want them,
usually, even when debugging.
Remove RngCompatExt.2023-11-29T15:55:04ZNick Mathewsonnickm@torproject.org2023-11-29T15:49:26Zurn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef
This code was needed with the old version of dalek-cryptography,
which wasn't compatible with up-to-date versions of the `rand`
crate(s). But now that we've upgraded, we can drop this.
(We could have left it around and deprecated it, but we are already
making a breaking change to tor-llcrypto by upgrading
dalek-cryptography.)
Convert to the latest versions of dalek-cryptography2023-11-29T15:34:58ZNick Mathewsonnickm@torproject.org2023-11-21T15:58:29Zurn:sha1:98037a2c788bd901679139178d25f855324637f3
The main changes that we have to adjust for are as follows:
* In x25519-dalek:
* `StaticSecret` is now behind a feature.
* `StaticSecret::new` is deprecated in favor of
`StaticSecret::random_from_rng`.
* StaticSecret no longer does its own clamping.
* In ed25519-dalek:
* `SecretKey` has (in effect) been renamed to `SigningKey`. The name
`SecretKey` is now an alias for `[u8; 32]`.
* `SigningKey` is effectively a keypair, since it contains a
public key as well.
* `PublicKey` has been renamed to `VerifyingKey`.
* The functions to extract a signing key and verifying key have
been renamed as you might expect.
* `ExpandedSecretKey` has been moved to `hasmat` and no longer
implements `sign`.
* `ExpanededSecretKey` now has as its elements a scalar and a hash
prefix.
* Various functions that took `&[u8]` now take `&[u8; N]`.
* We no longer need a wrapper for older versions of rand.
There is a single test in tor-keymgr that does not pass. I've
marked it as ignore for now, in hopes that @gabi-250 can help me
figure it out.
This closes #808. There are several changes I want to make before
we merge, however. They are marked with TODO DALEK.
Fix 'target' in doc comment for create_firsthop_ntor2023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-22T19:04:22Zurn:sha1:36389473ede9bb8c7d123991e037a1a788984357Test extend_ntor_v32023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-15T21:13:59Zurn:sha1:9f9dc604153322637301a1df988cccb740c79f44Parameterize circuit-extension test by handshake type2023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-02T15:27:31Zurn:sha1:678619384ade5c1c1904469bbe012eea0ab7ba79Add `ClientCirc::extend_ntor_v3`2023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-15T21:12:41Zurn:sha1:6149409574b57e919d9fc76cf0c0aa9a33d447actor-proto::circuit::reactor: handle server auxiliary handshake data2023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-16T17:30:13Zurn:sha1:c7929ea886289e4ef2d5d327321f044ee2efb136